From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33066)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hhEZI-0007vT-GB
 for guix-patches@gnu.org; Sat, 29 Jun 2019 10:43:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hhEZF-0007wp-EE
 for guix-patches@gnu.org; Sat, 29 Jun 2019 10:43:07 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:59503)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hhEZD-0007uw-34
 for guix-patches@gnu.org; Sat, 29 Jun 2019 10:43:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hhEZC-0001Di-Uh
 for guix-patches@gnu.org; Sat, 29 Jun 2019 10:43:02 -0400
Subject: [bug#36404] [PATCH 1/5] ssh: Add 'identity' keyword to
 'open-ssh-session'.
Resent-Message-ID: <handler.36404.B36404.15618193654645@debbugs.gnu.org>
References: <87o92ianbj.fsf@sdf.lonestar.org>
 <CAJ=RwfZ4GOBvkzwkeX0cA691ik9O1xGrTfWsc_wPJNo5ODJXPg@mail.gmail.com>
 <87imspj0ks.fsf_-_@sdf.lonestar.org> <87ef3dj0j9.fsf_-_@sdf.lonestar.org>
From: Christopher Lemmer Webber <cwebber@dustycloud.org>
In-reply-to: <87ef3dj0j9.fsf_-_@sdf.lonestar.org>
Date: Sat, 29 Jun 2019 10:42:40 -0400
Message-ID: <87lfxklafz.fsf@dustycloud.org>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 36404@debbugs.gnu.org

Jakob L. Kreuze writes:

> * guix/ssh.scm (open-ssh-session): Add 'identity' keyword argument.
> ---
>  guix/ssh.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/ssh.scm b/guix/ssh.scm
> index 9b9baf54ea..a2387564a4 100644
> --- a/guix/ssh.scm
> +++ b/guix/ssh.scm
> @@ -57,12 +57,13 @@
>  (define %compression
>    "zlib@openssh.com,zlib")
>  
> -(define* (open-ssh-session host #:key user port
> +(define* (open-ssh-session host #:key user port identity
>                             (compression %compression))
>    "Open an SSH session for HOST and return it.  When USER and PORT are #f, use
>  default values or whatever '~/.ssh/config' specifies; otherwise use them.
>  Throw an error on failure."

Looks good, but could you add to the docstring here explaining the new
identity keyword?

>    (let ((session (make-session #:user user
> +                               #:identity identity
>                                 #:host host
>                                 #:port port
>                                 #:timeout 10       ;seconds