From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:51039)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hyz9f-0005Qi-AI
 for guix-patches@gnu.org; Sat, 17 Aug 2019 09:54:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hyz9e-00025a-CC
 for guix-patches@gnu.org; Sat, 17 Aug 2019 09:54:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46612)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hyz9e-00025Q-92
 for guix-patches@gnu.org; Sat, 17 Aug 2019 09:54:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hyz9e-0001zw-3U
 for guix-patches@gnu.org; Sat, 17 Aug 2019 09:54:02 -0400
Subject: [bug#36653] [PATCH v2] guix import stackage: default to a LTS release
 compatible with GHC 8.4
Resent-Message-ID: <handler.36653.B36653.15660499857613@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190714193843.23405-1-rob@vllmrt.net>
 <20190716134122.21947-1-rob@vllmrt.net>
Date: Sat, 17 Aug 2019 15:52:53 +0200
In-Reply-To: <20190716134122.21947-1-rob@vllmrt.net> (Robert Vollmert's
 message of "Tue, 16 Jul 2019 15:41:23 +0200")
Message-ID: <87lfvrew5m.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 36653@debbugs.gnu.org

Hi Robert,

Too bad this patch is still in the queue!  I=E2=80=99m not familiar with
Stackage but I trust your judgment.  One minor comment:

Robert Vollmert <rob@vllmrt.net> skribis:

> In particular, this means that guix lint won't warn to update to
> versions that won't necessarily fit our package set well.
>
> Also some minor clean-up tweaks.
>
> * guix/import/stackage.scm (%stackage-url): Change to https, avoiding
> redirect log messages.
> (%default-lts-version): New field.
> (stackage-lts-info-fetch, stackage->guix-package, latest-lts-release): Us=
e it.
> (lts-info-ghc-version): Remove unused function.
> (lts-info-packages, latest-lts-release): Fix documentation typos.

[...]

> +;;; Latest LTS version compatible with bundled ghc version.
> +(define %default-lts-version "12.26")

What about storing this elsewhere?  Perhaps in the =E2=80=98properties=E2=
=80=99 field of
the =E2=80=98ghc=E2=80=99 package?  That should make it easier to keep thes=
e numbers in
sync.

Besides, it=E2=80=99s usually clearer to separate unrelated cleanups, but i=
t=E2=80=99s
no big deal in this case.

Thanks,
Ludo=E2=80=99.