From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:53786)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i9lpk-0002Z0-PX
 for guix-patches@gnu.org; Mon, 16 Sep 2019 03:54:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i9lpj-0003gv-Ot
 for guix-patches@gnu.org; Mon, 16 Sep 2019 03:54:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40267)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i9lpi-0003fY-JI
 for guix-patches@gnu.org; Mon, 16 Sep 2019 03:54:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i9lpi-0003Xq-Gf
 for guix-patches@gnu.org; Mon, 16 Sep 2019 03:54:02 -0400
Subject: [bug#37412] [PATCH 2/2] services: Add the Guix Data Service.
Resent-Message-ID: <handler.37412.B37412.156862042913605@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190915182127.10525-1-mail@cbaines.net>
 <20190915182127.10525-2-mail@cbaines.net>
Date: Mon, 16 Sep 2019 09:53:39 +0200
In-Reply-To: <20190915182127.10525-2-mail@cbaines.net> (Christopher Baines's
 message of "Sun, 15 Sep 2019 19:21:27 +0100")
Message-ID: <87lfuofzi4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 37412@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/services/guix.scm: New file.
> * gnu/tests/guix.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add both new files.

Yay, nice!

> +  (commits-getmail-retriever-configuration
> +   guix-data-service-commits-getmail-retriever-configuration

New world record: longer than =E2=80=98call-with-current-continuation=E2=80=
=99.  :-)

> +(define (guix-data-service-shepherd-services config)
> +  (match config
> +    (($ <guix-data-service-configuration> package user group
> +                                          port host)

Perhaps use =E2=80=98match-record=E2=80=99 here and elsewhere, to avoid mis=
takes when
the record type changes.

> +(define %test-guix-data-service
> +  (system-test
> +   (name "guix-data-service")
> +   (description "Connect to a running Guix Data Service.")
> +   (value (run-guix-data-service-test))))

Nice.

Could you add a bit to guix.texi, maybe under =E2=80=9CContinuous Integrati=
on=E2=80=9D?
You don=E2=80=99t have to go into too much detail if you think some of the
configuration elements are subject to change.

Thank you!

Ludo=E2=80=99.