unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 37465@debbugs.gnu.org
Cc: ludo@gnu.org
Subject: [bug#37465] add xftwidth displayed textwidth calculator package
Date: Sun, 29 Sep 2019 17:32:31 +0200	[thread overview]
Message-ID: <87lfu7p180.fsf@nckx> (raw)
In-Reply-To: <c848b277852137e37670a1c4db0c795f2136897d.camel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

Kyle,

Thanks for the patch.

Kyle Andrews 写道:
> I've fixed the notes I saw from guix lint:
>
> 1. https -> http for github urls

I thought this was just a typo, but the patch agrees.  Our linter 
doesn't recommend HTTP over HTTPS for GitHub (or indeed any) URLs. 
In fact, it should now warn about a

  gnu/packages/xftwidth@20170402: permanent redirect from
  http://github.com/vixus0/xftwidth to
  https://github.com/vixus0/xftwidth

Also, the GNU/Guix style is to…
- never use tabs for indentation, only spaces.
- use two spaces between prose sentences: ‘…Xft fonts.  It is…’.
                                                      ^^
The linter should have warned you about both of these, too.

It sounds like yours is behaving quite strangely.  What, exactly, 
did it say?

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-09-29 15:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20  0:25 [bug#37465] add xftwidth displayed textwidth calculator package Kyle Andrews
2019-09-25 13:32 ` Ludovic Courtès
2019-09-29 14:24   ` Kyle Andrews
2019-09-29 15:32     ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2019-09-29 19:46     ` bug#37465: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfu7p180.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=37465@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).