From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45683) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIBox-00028L-NS for guix-patches@gnu.org; Wed, 09 Oct 2019 09:16:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIBow-0007ZV-Cn for guix-patches@gnu.org; Wed, 09 Oct 2019 09:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIBow-0007ZL-2A for guix-patches@gnu.org; Wed, 09 Oct 2019 09:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIBov-0004w4-ST for guix-patches@gnu.org; Wed, 09 Oct 2019 09:16:01 -0400 Subject: [bug#37642] [PATCH] gnu: Add filters Resent-Message-ID: References: <6f4a21523a30dcf3e3045aad994d8958c78a7b72.camel@gmail.com> <87lftv1dwb.fsf@nckx> <14cbe887a25f732826a1e920e2d0140dbce51893.camel@gmail.com> In-reply-to: <14cbe887a25f732826a1e920e2d0140dbce51893.camel@gmail.com> Date: Wed, 09 Oct 2019 15:14:52 +0200 Message-ID: <87lftu9i2b.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: Jesse Gibbons Cc: 37642@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jesse, Jesse Gibbons =E5=86=99=E9=81=93=EF=BC=9A > That review was a bit of a mess. Let's see if I can rephrase=20 > what you want, > in a human-friendly format (no emacs involved): Yes, I'm so sorry. It looked fine while writing; I'm not actually=20 on crack. >> * gnu/packages/filters.scm: New file. >> * gnu/local.mk: Add it. >> * gnu/packages/cvassistant.scm (filters): New variable. > Spot my "commit message template" remnants! > > You want me to put it into either games.scm or toys.scm,=20 > preferrably > toys.scm, for the sake of organization. Yes. File naming and package categorization are an impromptu=20 mess. Single-package files exist, most of them probably shouldn't=20 *or* they should be the norm as in Nix. I suspect the reason that=20 Guix diverged was mainly technical: many things about Guix can=20 (still) be explained by =E2=80=98Guile does a bad thing otherwise=E2=80=99. >> I had previously started a discussion on the guix-devel list=20 >> with a similar > concern and was convinced that it is fine to have some packages=20 > isolated in > their own files. That's why I put rednotebook cv-assistant=20 > isolated in their > own sources. Sure. It's impossible to document the current scheme because it's=20 self-contradictory. =E2=80=98Feels wrong to nckx=E2=80=99 is no great argu= ment=20 but it's all you're going to get here. Even the name =E2=80=98filter=E2=80= =99=20 would only make sense in the context of this package (hey, gzip is=20 a filter too=E2=80=A6). This has officially got to much attention now :-) > However, since you asked, and there are two different files it > would fit in, I will put filters in toys.scm. I'll leave it to=20 > you to > convince the others that packages like cmatrix, cowsay,=20 > fortune-mod, and no- > more-secrets should be moved to toys because they are not games. As much as I =E2=99=A5 irrelevant things, that would just be noise. > Make sure these are indented when I add a new file. > I guess indent-code.el doesn't look outside the package=20 > definition... Good point, I hadn't thought of that. Must be how we subtly force=20 you to switch to emacs. > Use a patch instead or move this to the source's snippet so=20 > kenny is removed > from the raw source. A patch would contain a =E2=80=98negative=E2=80=99 verbatim copy of the non= -free=20 code so isn't an option here. >> + #:tests? #f)) > clarify we have no tests suite Yep. Ideally that comment would be redundant because we'd never=20 flat-out disable tests in packages that have them, but we do. >> +The GNU project hosts a similar collection of filters, the GNU >> talkfilters. Due >> +to copyright concerns and difficulty in communication between >> maintainers, these >> +collections have not been merged.") > You want me to remove this. > I think it's appropriate to say something about gnu talkfilters=20 > and note > that this is not the same package, given that filters and=20 > talkfilters > packages are often confused with each other on the internet, OK. I didn't know they were often confused. Would it make sense=20 to add it to GNU's, too? > but I will remove the last sentence. Great. It's the one that bothered me. > If the comments go beyond 80 characters I will move the=20 > comments above the license. For such whole-line comments you *would* use =E2=80=98;;=E2=80=99, start wi= th a=20 capital letter, and end with a full stop=E2=80=A6 > indent-code.el missed these comments. Sounds like indent-code.el needs love from someone who likes=20 writing elisp. > Am I missing anything? Not that I'm aware of. Sorry again for the beastly formatting of=20 my original message. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl2d3UwACgkQ2Imw8BjF STwwJhAAtR1Zac2d4n6+t4lts5aWmULLs/0NUm0DYgbsCGjc/xD6yBq9+kEYNyOv W2E25pTpsxiA9pZ5YtbullSeYAPsk5iVNKRN5bV/8F60JtVQ/Hx0akGibxnO/y0L Vsd5ZG8Jwf3dV5EOyIZZVdskjQlQ2GOCDr1ATqFj50BNABMEN1FjmfahEMaiF5UG R3mdM8MPko7pc33shptrtEK9UNerO+/9zxUuBdSjSRJWk3f91eJgc8w72h0AXV2f CdxGRmBD3+f2sREL7bG2fX+SLVLwJ9jdbZIOmLM1j4AGGi+gZXZd8NO1KB4OmV4x fSk12nt0GPRqZ4ciJtLu36Hba632OCi6PfqBGwEaFk1gtz1bsQL6E9GFv31Ymcis t13iQezxVyerlXQEz89PKHMTTUK4ouRhrd/mra9IRkRWHEASK9wHAFHqYn89mHBn 12VPEMycNmSM80kjz3fyDq6ChIasB+oai7PeIu+18TgoEe4fDOwkQGiauxa+2J+q u8EacQuOx8EMk8H+TR3VpWMsolD9i8l/6F8PLZ4gqXEOjykCFeew/ujzn95vmzic dl0nHeZfe2p2n6ok5l4xwPEsD4Yg9pRzIjX8XPa5aHnyhQdsT9wfR6PIOTDPy+XB ICe8IX2/8WjMbAf7bqs4ZfuCN1IOq1LSGDtbjRIgEGTGssheK2c= =f3X4 -----END PGP SIGNATURE----- --=-=-=--