unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: 38286@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Sun, 24 Nov 2019 12:03:36 +0100	[thread overview]
Message-ID: <87lfs5zgc7.fsf@gnu.org> (raw)
In-Reply-To: <cd5ab7d8-685c-48b7-be48-4545f4876528@www.fastmail.com> (Alex Griffin's message of "Thu, 21 Nov 2019 22:15:47 +0000")

Hello!

"Alex Griffin" <a@ajgrf.com> skribis:

> From 41abd13973e20750815b5f395acb9fc4893c6817 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a@ajgrf.com>
> Date: Tue, 19 Nov 2019 19:59:32 -0600
> Subject: [PATCH] gnu: Add netcat-openbsd.
>
> * gnu/packages/admin.scm (netcat-openbsd): New variable.

Overall LGTM; I like that we’re not taking responsibility for all these
patches.  :-)

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://salsa.debian.org/debian/netcat-openbsd.git")
> +                    (commit (string-append "debian/" version))))
> +              (sha256
> +               (base32
> +                "0j85gzbjzs6yrhgabh3zkwzd27qkr5s0zjjczl0hah8q7yhrjk3m"))))

I suspect ‘guix lint’ suggests a ‘file-name’ field here.  :-)

> +    (home-page "https://packages.debian.org/sid/netcat-openbsd")
> +    (synopsis "TCP/IP swiss army knife")

Could you make that more factual, like “Read and write data over TCP/IP”
(same as for ‘netcat’ actually)?

> +    (description
> +     "A simple Unix utility which reads and writes data across network
         ^
Please write full sentences.

OK to push with changes along these lines!

Thanks,
Ludo’.

  reply	other threads:[~2019-11-24 11:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  2:10 [bug#38286] [PATCH] gnu: Add netcat-openbsd Alex Griffin
2019-11-21  9:09 ` Ludovic Courtès
2019-11-21 10:17   ` Efraim Flashner
2019-11-21 21:49     ` Alex Griffin
2019-11-21 22:09       ` Alex Griffin
2019-11-21 22:15         ` Alex Griffin
2019-11-24 11:03           ` Ludovic Courtès [this message]
2019-11-25 15:50             ` bug#38286: " Alex Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfs5zgc7.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=38286@debbugs.gnu.org \
    --cc=a@ajgrf.com \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).