unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: John Soo <jsoo1@asu.edu>
Cc: 39309@debbugs.gnu.org
Subject: [bug#39309] [PATCH WIP] gnu: add stack.
Date: Wed, 11 Mar 2020 10:18:10 -0400	[thread overview]
Message-ID: <87lfo72cwt.fsf@ngyro.com> (raw)
In-Reply-To: <2FD91328-10FF-41C7-AFDF-E14F66916116@asu.edu> (John Soo's message of "Wed, 11 Mar 2020 02:17:15 -0700")

Hi John,

John Soo <jsoo1@asu.edu> writes:

> I like the idea of offering more cabal file semantics to package
> authors. In that regards I have no issues with your patches.  My only
> thought is we should make the flags lists instead of booleans. Not
> only would lists match the cabal file specification, but I think
> having the extra detail would be a nice way to verify against existing
> cabal files. I can’t imagine just yet how but I could see wanting to
> be able to specify which paths were being used and their order.

My first attempt did exactly that, but I ran into some problems with it.
IIRC, I had to worry about paths for transitive dependencies, which made
it really hard to get working (and would make it really hard to
maintain).  This patch was take two.  :)  It’s a little less specific
but much easier to work with.

> I am not opposed to the names of the fields either, I like that they
> match the cabal fields.

Good to hear.  Maybe they’re not so bad.

> Thanks again!

I still need to take another look at this, but I’m not sure when I’ll
get the chance.  I’ll try to carve out some time soon.  Thanks again to
you for the patches.  :)


-- Tim

  reply	other threads:[~2020-03-11 14:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 14:56 [bug#39309] .[PATCH] WIP gnu: add stack John Soo
2020-01-29 15:17 ` [bug#39309] [PATCH WIP] " John Soo
2020-02-07 17:32   ` John Soo
2020-02-10  6:06     ` Timothy Sample
2020-02-13 13:52       ` John Soo
2020-02-13 13:59         ` John Soo
2020-02-13 17:36           ` John Soo
2020-02-13 22:59             ` Timothy Sample
2020-02-16  1:56               ` Timothy Sample
2020-02-19 14:56                 ` John Soo
2020-02-20  4:55                   ` Timothy Sample
2020-02-22 15:34                     ` Timothy Sample
2020-03-11  9:17                       ` John Soo
2020-03-11 14:18                         ` Timothy Sample [this message]
2020-03-13 15:05                           ` John Soo
2021-01-01 18:04                             ` [bug#39309] .[PATCH] WIP " John Soo
2021-01-01 18:18                               ` John Soo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfo72cwt.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=39309@debbugs.gnu.org \
    --cc=jsoo1@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).