From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48156) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRhv9-0005y2-D9 for guix-patches@gnu.org; Thu, 23 Apr 2020 15:54:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRhv9-0001TR-17 for guix-patches@gnu.org; Thu, 23 Apr 2020 15:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRhv8-0001TM-Lt for guix-patches@gnu.org; Thu, 23 Apr 2020 15:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRhv8-0007CZ-L1 for guix-patches@gnu.org; Thu, 23 Apr 2020 15:54:02 -0400 Subject: [bug#40691] [PATCH v3 1/1] gnu: Add gromacs. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87k12b15ki.fsf@gnu.org> <36e8a145-1ca8-c380-9864-dbf8b1fd53cb@gmail.com> <87y2qnv8da.fsf@gnu.org> Date: Thu, 23 Apr 2020 21:52:51 +0200 In-Reply-To: (Vincent Legoll's message of "Thu, 23 Apr 2020 15:07:42 +0200") Message-ID: <87lfmmnfn0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vincent Legoll Cc: 40691@debbugs.gnu.org Hi Vincent, Vincent Legoll skribis: >> It may be reasonable to just skip it. > > Hope you don't mind trading a test suite failure for a (harmless) > test suite build warning... > > How's the crude disabling in the attached patch v3 look to you ? > > And does it fix the failure ? > This test is not failing here (kvm on ryzen). Oh that=E2=80=99s guix-daemon inside QEMU/KVM? Then what can happen, unlik= e on real hardware, is that hwloc doesn=E2=80=99t discrepancies between the actu= al number of cores and the info it gathers from /sys or whatever. > From 660371d5a3e7c7c763fc123357ddd6c31f730553 Mon Sep 17 00:00:00 2001 > From: Vincent Legoll > Date: Sat, 18 Apr 2020 00:14:56 +0200 > Subject: [PATCH] gnu: Add gromacs. > > * gnu/packages/bioinformatics.scm (gromacs): New variable. [...] > + (add-after 'unpack 'disable-hwloc-test > + (lambda _ > + ;; This test warns about the build host hardware > + (substitute* "src/gromacs/hardware/tests/hardwaretopology.c= pp" > + (("TEST\\(HardwareTopologyTest, HwlocExecute\\)") > + "void __guix_disabled()")) I was thinking it=E2=80=99d be nice to use whatever mechanism gtest has to = mark a test as skipped but I didn=E2=80=99t find anything, so it=E2=80=99s proba= bly OK like this. However, there=E2=80=99s another issue I hadn=E2=80=99t noticed (apologies!= ): src/external bundles a few things like googletest, tinyxml2, zlib (indirectly), etc. Could you check if we can use our own dependencies instead of the bundled ones? For gtest it=E2=80=99s good if we can unpack the source of our =E2=80=98goo= gletest=E2=80=99 package in place of the bundled copy, but it=E2=80=99s optional (I think th= ere are cases where we found this wasn=E2=80=99t possible for some reason). Thank you! Ludo=E2=80=99.