From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53604) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jShr9-0001Nj-MO for guix-patches@gnu.org; Sun, 26 Apr 2020 10:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jShr8-0004mx-W4 for guix-patches@gnu.org; Sun, 26 Apr 2020 10:02:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jShr8-0004mq-J4 for guix-patches@gnu.org; Sun, 26 Apr 2020 10:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jShr8-0005zb-He for guix-patches@gnu.org; Sun, 26 Apr 2020 10:02:02 -0400 Subject: [bug#40753] gnu: spacefm: Add dependencies for extra functionality. Resent-Message-ID: From: Jan Nieuwenhuizen References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <20200424153558.2aa79ef0.raghavgururajan@disroot.org> <87h7x8wsr8.fsf@gnu.org> <20200425221143.1a587483.raghavgururajan@disroot.org> Date: Sun, 26 Apr 2020 16:00:57 +0200 In-Reply-To: <20200425221143.1a587483.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Sat, 25 Apr 2020 22:11:43 -0400") Message-ID: <87lfmis5wm.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 40753@debbugs.gnu.org Raghav Gururajan writes: Hello Raghav, >> Pushed to master with small cosmetic change below. >>=20 >> Thanks for the patch! > > I accidentally sent the wrong patch that missed some things. So sorry. I = have > attached a patch with this email to append the previous. Could you please= push > it as new commit. Thanks! Don't worry, we all make mistakes. > From ea9e9909c2929639c1b6574ae61ca9fb0b319177 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Sat, 25 Apr 2020 21:43:25 -0400 > Subject: [PATCH] gnu: spacefm: Fix privilege management and icons. >>>HERE<<< > * gnu/packages/lxde.scm (spacefm): Fix privilege management and icons. Please move this remark: > This commit contains changes that were accidentally left out in > commit bf37b49cdd345bcedeb7142f61968d3a6e15e8d8. beteen subject and "* gnu/packages/lxde", so to >>>HERE<<< > (arguments > - `(#:configure-flags (list (string-append "--with-bash-path=3D" > - (assoc-ref %build-inputs "= bash") > - "/bin/bash") > - (string-append "--sysconfdir=3D" > - (assoc-ref %outputs "out") > - "/etc")))) > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-spacefm-conf > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "etc/spacefm.conf" > + (("#terminal_su=3D/bin/su") > + (string-append "terminal_su=3D" > + (string-append (assoc-ref inputs "sudo") > + "/bin/sudo")))) Does this work; SU is not SUDO? Also, I don't see how /bin/sudo would work. When I run this $(guix build sudo)/bin/sudo=20 I get sudo: /gnu/store/l320ig872ny66d1yi6v7n4zb93iz50dx-sudo-1.8.31p1/bin/sud= o must be owned by uid 0 and have the setuid bit set Am I missing something? > + (substitute* "etc/spacefm.conf" > + (("#graphical_su=3D/usr/bin/gksu") > + (string-append "graphical_su=3D" > + (string-append (assoc-ref inputs "ktsuss") > + "/bin/ktsuss")))) > + #t))) Changing the default configurations does not seem to work for me. When I select /File/Root Window there is a pop-up that says: Please configure a valid Terminal SU command. Does it work for You? > + #:configure-flags (list=20 ^ Trailing space. Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com