From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +TtdIwhzrV6oGwAA0tVLHw (envelope-from ) for ; Sat, 02 May 2020 13:18:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id APTJMhFzrV5yKwAAB5/wlQ (envelope-from ) for ; Sat, 02 May 2020 13:18:09 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 04B39940A37 for ; Sat, 2 May 2020 13:18:09 +0000 (UTC) Received: from localhost ([::1]:48734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUs1x-00056s-66 for larch@yhetil.org; Sat, 02 May 2020 09:18:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUs1s-00056W-OI for guix-patches@gnu.org; Sat, 02 May 2020 09:18:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUs1q-0005Tl-8T for guix-patches@gnu.org; Sat, 02 May 2020 09:18:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUs1p-0005Sw-ST for guix-patches@gnu.org; Sat, 02 May 2020 09:18:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUs1p-0002ME-Oq for guix-patches@gnu.org; Sat, 02 May 2020 09:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 May 2020 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41022 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 41022@debbugs.gnu.org Received: via spool by 41022-submit@debbugs.gnu.org id=B41022.15884254639017 (code B ref 41022); Sat, 02 May 2020 13:18:01 +0000 Received: (at 41022) by debbugs.gnu.org; 2 May 2020 13:17:43 +0000 Received: from localhost ([127.0.0.1]:51544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUs1S-0002LJ-Fs for submit@debbugs.gnu.org; Sat, 02 May 2020 09:17:43 -0400 Received: from mira.cbaines.net ([212.71.252.8]:54014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUs1M-0002L6-Tr for 41022@debbugs.gnu.org; Sat, 02 May 2020 09:17:37 -0400 Received: from localhost (unknown [46.237.174.129]) by mira.cbaines.net (Postfix) with ESMTPSA id 172A127BBE1; Sat, 2 May 2020 14:17:32 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 52cdf5e4; Sat, 2 May 2020 13:17:28 +0000 (UTC) References: <20200502110314.30403-1-mail@cbaines.net> <87ees24lyr.fsf@devup.no> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines In-reply-to: <87ees24lyr.fsf@devup.no> Date: Sat, 02 May 2020 14:17:28 +0100 Message-ID: <87lfmamq6v.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-3.11 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49495110433496]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.15), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FREEMAIL_TO(0.00)[fastmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mail@cbaines.net,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[centricular.com:email,meson.build:url,fastmail.com:email,cbaines.net:email,gitlab.freedesktop.org:url]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MIME_TRACE(0.00)[0:+,1:+,2:~]; DMARC_NA(0.00)[cbaines.net]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: BramLsndAxjN --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> Add a patch based on an upstream commit [1]. >> >> 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362 >> >> * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add it. >> * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch. > > [...] > >> diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >> new file mode 100644 >> index 0000000000..49f41e0c03 >> --- /dev/null >> +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >> @@ -0,0 +1,41 @@ >> +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001 >> +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= >> +Date: Fri, 13 Dec 2019 10:46:20 +0200 >> +Subject: [PATCH] Fix build with Python 3.8 by also checking for >> + python-3.X-embed.pc >> + >> +Since Python 3.8 the normal checks don't include the Python libraries >> +anymore and linking of the gst-python module would fail. >> + >> +See also https://github.com/mesonbuild/meson/issues/5629 >> + >> +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 >> +--- >> + meson.build | 11 +++++++++-- >> + 1 file changed, 9 insertions(+), 2 deletions(-) > > Instead of the git patch format, can you add a short comment at the top > along with links to the upstream commit and issue like we usually do? I usually avoid messing with patches, they're often uncooperative. Would something I this do? Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since Python 3.8 the normal checks don't include the Python libraries anymore and linking of the gst-python module would fail. See also https://github.com/mesonbuild/meson/issues/5629 Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 Patch based on upstream commit: https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6tcuhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcHTw//bCIAyOGWEtdqTuhTXSAOFKExl5A130qc0sk0I5bZa8YOztn1qzA0SNL7 mYtiZuWWnmixTvvPRwBRlOAIQfsAHDwjr7XYYUqon9POusYO6yANKo7ja3XpcuVz 7q+7cOHjYjaFG6hOJCpxXqgjd9VuQsKj0UzQO/rUCws9I0KkE9HPU7OWhcxN0nGp BIvU56v3s8MbArGwwf/FpAIA64mS16yerp2N7ZpRXTLL4Qd5G0O/nw9GZZJN0eQo xvKY2Q/EfkWhQqhkF+RAG601lVt8xhVeIdRuwiI02ilhY54UL1Dc/6+lYiBbiu4p ixoyE1koEKY9aXnZBJxIwE/uQ6+LbJsICnFrunXOZd5MtF+s5cClpY2sE+iE+fSs igDo6RIq1K19yxPkBlJjRO4gWCbpB/MN7ZGLCj3SbgEVa0SZ7ZePyIrxHL5eT9oP /bDrsnpac3TzQCMMlUEdSxSZbnm+Ty1q6CF7Bw0RdnM6FygEBJ6egx+LGbNqnFM4 ezn2UZt79eus6xKGb/iBeoZUQz++ckTaYnJ6QKXqwOhoVTDDmzr/xFcVHiXMgXgw uzrexQQ9TXACLnJFfUh0b6ELI472qX/wtFgWESS5L22X5aaA8h/KuxalMuP+6PZL zex8g6fgQeB+Q1Nq+F2O0u7x8MFV9Oso/EqKU+U1Hz5aDVcpBJc= =LSeh -----END PGP SIGNATURE----- --=-=-=--