From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8MBtGAFpNl/eDAAA0tVLHw (envelope-from ) for ; Fri, 14 Aug 2020 10:35:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yGlkFAFpNl+IBAAAB5/wlQ (envelope-from ) for ; Fri, 14 Aug 2020 10:35:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC980940223 for ; Fri, 14 Aug 2020 10:35:44 +0000 (UTC) Received: from localhost ([::1]:37808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6X3m-0007kL-Vq for larch@yhetil.org; Fri, 14 Aug 2020 06:35:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6WWE-0002mo-65 for guix-patches@gnu.org; Fri, 14 Aug 2020 06:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6WWD-0000cU-R2 for guix-patches@gnu.org; Fri, 14 Aug 2020 06:01:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6WWD-0004bA-Ph for guix-patches@gnu.org; Fri, 14 Aug 2020 06:01:01 -0400 Subject: bug#42735: [PATCH] pre-inst-env: don't use GUIX_PACKAGE_PATH Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 14 Aug 2020 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42735 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Denis 'GNUtoo' Carikli Cc: 42735-done@debbugs.gnu.org Mail-Followup-To: 42735@debbugs.gnu.org, go.wigust@gmail.com, GNUtoo@cyberdimension.org Received: via spool by 42735-done@debbugs.gnu.org id=D42735.159739922915814 (code D ref 42735); Fri, 14 Aug 2020 10:01:01 +0000 Received: (at 42735-done) by debbugs.gnu.org; 14 Aug 2020 10:00:29 +0000 Received: from localhost ([127.0.0.1]:51872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6WVh-00046d-5p for submit@debbugs.gnu.org; Fri, 14 Aug 2020 06:00:29 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:46528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6WVe-0003zD-NU for 42735-done@debbugs.gnu.org; Fri, 14 Aug 2020 06:00:28 -0400 Received: by mail-lf1-f65.google.com with SMTP id i80so4503274lfi.13 for <42735-done@debbugs.gnu.org>; Fri, 14 Aug 2020 03:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sgcfYYomf7IYNT42zC+T9jOvbJ5wvILBcttTSQ1rNe8=; b=nOL77KisZ7vIcE3GTjP3kQRAMjoX4uWgdGrPHAih5iBGXyGZeBM5aVOimam9IEO5vK 7aIw8nmSPDZDffaLVZMh70+khawXl4o68SbR7lsgUqKiWlsd3ON1QJfbrwbUCnKCAFvg ZhY3PEToHXX/NjkvzeXNBeCVXRQUzIWLlu6G5Lm6ZAWC1/L1LANGNysiCrNWSAiRlx1O j0oftuyJleWmJ7FUiJYqBg/MlauCtnNVZEMcuj+SQFGiVwdI1YhPaZHK8l5ObK6gElVo +7l2xHuwIRUHk8Hu2eLF7wsMqA/J6WiicYrw/jwnPdpl7lboXsxTv/dnuBvm/Pq6hcY8 aYpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sgcfYYomf7IYNT42zC+T9jOvbJ5wvILBcttTSQ1rNe8=; b=aEgZK6viwlu+bK8Nmtg9QIhV6TsUyashvGh2bdGRWCm66QPoYSxKiWB5OVI2zB9f3M VxBEs5X4v7FKqk32kjS8KQI0qC2Y78gCfvNcq3covpuXhf7yaaGIoVlfm5GGv5llaTKA FjMTMGdKaxJzayMipYX2BXPickiYbUgSxUyRQ+tTdglKkPn+HgUDTfT/UsAWUPBlKuM6 waVdSlKaAV1Q+FyPU3ONufM5tJMegV1cgBvPKcJxXhjsSYK5Y6uHXXF2sgZWGObOcprJ GJFxWf8RdVF9II6kHJ2CWnc1yenWNtqv028cmBahTDA+v6k0Hx2lK1UA687p8lO+zyyq 1IMQ== X-Gm-Message-State: AOAM532a0p80TAkVh11u+q5g3xH9ydE8l2UDtFXH+fsQuFiAZ8yNXGAx VwMego4KZuagtWNpCpD1US/v6hpSCQE= X-Google-Smtp-Source: ABdhPJyTYKrwZM6t3/LeLxxNMVZ2vKL+ZOs+iFs3zZkLE/nL+buM4OBOGWSy4TEDoBHJ5OTIrFQPUw== X-Received: by 2002:a05:6512:314a:: with SMTP id s10mr815672lfi.123.1597399220152; Fri, 14 Aug 2020 03:00:20 -0700 (PDT) Received: from guixsd (ppp91-122-98-213.pppoe.avangarddsl.ru. [91.122.98.213]) by smtp.gmail.com with ESMTPSA id o24sm1659103ljg.69.2020.08.14.03.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 03:00:19 -0700 (PDT) From: Oleg Pykhalov References: <20200807022142.26296-1-GNUtoo@cyberdimension.org> <87mu36onjj.fsf@gnu.org> <20200809110939.407b0bb9@primarylaptop.localdomain> Date: Fri, 14 Aug 2020 13:00:16 +0300 In-Reply-To: <20200809110939.407b0bb9@primarylaptop.localdomain> (Denis Carikli's message of "Sun, 9 Aug 2020 11:09:39 +0200") Message-ID: <87lfihsg27.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=nOL77Kis; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: VTMPVEpyM8uL --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Denis 'GNUtoo' Carikli writes: [=E2=80=A6] > Should a warning be emitted when packages come from GUIX_PACKAGE_PATH > with ./pre-inst-env ? I don't think a user needs another warning for an environment variable which he setted by himself. Also, user could use =E2=80=98-L=E2=80=99 flag= instead of =E2=80=98GUIX_PACKAGE_PATH=E2=80=99. Currently, with =E2=80=98hello=E2=80=99 package in GUIX_PACKAGE_PATH: =2D-8<---------------cut here---------------start------------->8--- oleg@guixsd ~/src/guix-master$ GUIX_PACKAGE_PATH=3D/home/oleg/src/guix-wigu= st/guix ./pre-inst-env guix build --no-grafts --no-offload hello guix build: warning: ambiguous package specification `hello' guix build: warning: choosing hello@2.10 from /home/oleg/src/guix-wigust/gu= ix/wigust/packages/games.scm:174:2 /gnu/store/a462kby1q51ndvxdv3b6p0rsixxrgx1h-hello-2.10 =2D-8<---------------cut here---------------end--------------->8--- without =E2=80=98hello=E2=80=99 package in GUIX_PACKAGE_PATH: =2D-8<---------------cut here---------------start------------->8--- oleg@guixsd ~/src/guix-master$ GUIX_PACKAGE_PATH=3D/home/oleg/src/guix-wigu= st/guix ./pre-inst-env guix build --no-grafts --no-offload hello /gnu/store/a462kby1q51ndvxdv3b6p0rsixxrgx1h-hello-2.10 =2D-8<---------------cut here---------------end--------------->8--- > The issue is if it picks dependencies from GUIX_PACKAGE_PATH which are > not in Guix source code yet. In that case it might be more complicated > to make sure that people will see the warning as it might be hidden in > the huge build log. > > Another option which can also be combined with the previous one would be > to warn people in the manual. It's already documented, isn't it? https://www.gnu.org/software/guix/manual/html_node/Package-Modules.html =2D-8<---------------cut here---------------start------------->8--- -- Environment Variable: GUIX_PACKAGE_PATH This is a colon-separated list of directories to search for additional package modules. Directories listed in this variable take precedence over the own modules of the distribution. =2D-8<---------------cut here---------------end--------------->8--- I'll close the bug. Feel free to reopen if I miss something. Regards, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl82YLAACgkQFn+OpQAa +pzL0Q/+KW2sLToAcjSjGm+yQv+4iwdepo/Zb5f0QkjeGhl6DpJDnFHV5FB7mqQz 4nznrC88NmpUMLrxAOjI+NHgVGLPRDdx26gMNu8nG4vHdL/D0UjzkMvtGfTUbZlu +eT2i3aElqfz3Hl9nnE+14uxhG+MlTWCq7JIOn6636O+b+Im0ynVKGNH+Eb1c/6r AMuTgOn7+IT5kzuqWduSblNsWrunis8vkCaMjSFyCjV79XuIL/jybRgXFJ+WB0MO tvs2WF+SYacKev2DpAcwbt6+AwTSfxkuI6qYEc/zETxwAjSYbcGnA4uJAvTlFScx zJ3A8dAk7WTuTDxVCxCPs4mkDBzS7r4AbHIzZBwaIag6ZHKgHjcnqOQ3b0R+7fOQ WeVLbQCVxsRe8mGATRbvUOAgQa2qTH4D+GjVn57Y/9F2OEIa4vjtM9vwknXBCcGE 47RGfdCPo7iNMjeCtIsdgtljyGw8vDQRXX6sP21KwcALrU56UZjFyzQDHQqM1hnB oMhZvswxWGXeb0cM3tO0ibgNsgDDyfO/CSQIfhZxSJA7rQ/2tAjamIQjoIr59VXh /iT/awabGJsd7UTq5vUKSBSPO/7LDA5c2PvuAjKh9yEfL080GgGgLB+oYLEx4x0p rDpmfiO/NFikvYzQaK8i8KT+q5mOCKttA73hZIK2d7tQH+zou7U= =7gdY -----END PGP SIGNATURE----- --=-=-=--