From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yCMLCYv8TF95OwAA0tVLHw (envelope-from ) for ; Mon, 31 Aug 2020 13:35:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aEPNBIv8TF+yfwAA1q6Kng (envelope-from ) for ; Mon, 31 Aug 2020 13:35:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8A689404CE for ; Mon, 31 Aug 2020 13:35:06 +0000 (UTC) Received: from localhost ([::1]:55706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCjxh-0008VW-1R for larch@yhetil.org; Mon, 31 Aug 2020 09:35:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCjxe-0008VQ-4Q for guix-patches@gnu.org; Mon, 31 Aug 2020 09:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCjxd-0001w2-S6 for guix-patches@gnu.org; Mon, 31 Aug 2020 09:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCjxd-0006s9-Pv for guix-patches@gnu.org; Mon, 31 Aug 2020 09:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43064] [PATCH v2] gexp: computed-file: Prevent mistakenly overriding default option values. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 31 Aug 2020 13:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43064 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 43064@debbugs.gnu.org Received: via spool by 43064-submit@debbugs.gnu.org id=B43064.159888089526401 (code B ref 43064); Mon, 31 Aug 2020 13:35:01 +0000 Received: (at 43064) by debbugs.gnu.org; 31 Aug 2020 13:34:55 +0000 Received: from localhost ([127.0.0.1]:51839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjxW-0006rl-Si for submit@debbugs.gnu.org; Mon, 31 Aug 2020 09:34:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCjxV-0006rX-Qi for 43064@debbugs.gnu.org; Mon, 31 Aug 2020 09:34:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56208) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCjxQ-0001v8-I2; Mon, 31 Aug 2020 09:34:48 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=36214 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCjxQ-0005xZ-4x; Mon, 31 Aug 2020 09:34:48 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <877dtfj50o.fsf@gnu.org> <20200831043744.11165-1-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 31 Aug 2020 15:34:46 +0200 In-Reply-To: <20200831043744.11165-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Mon, 31 Aug 2020 00:37:44 -0400") Message-ID: <87lfhvc51l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: vXgA+AGvH3HR Hi, Maxim Cournoyer skribis: > In order to do so, default to an empty options list, and expose options w= hose > default values are sensitive directly as keyword arguments. > > * guix/gexp.scm (computed-file): Extract the LOCAL-BUILD? parameter from = the > OPTIONS parameter to make it a stand-alone keyword argument. Introduce an > OPTIONS* binding which is obtained by combining the LOCAL-BUILD? keyword = and > its value with OPTIONS. > > Suggested-by: Ludovic Court=C3=A8s [...] > (define* (computed-file name gexp > - #:key guile (options '(#:local-build? #t))) > + #:key guile (local-build? #t) (options '())) > "Return an object representing the store item NAME, a file or directory > -computed by GEXP. OPTIONS is a list of additional arguments to pass > -to 'gexp->derivation'. > +computed by GEXP. When LOCAL-BUILD? is #t (the default), it ensures the > +corresponding derivation is built locally. OPTIONS may be used to pass > +additional arguments to 'gexp->derivation'. >=20=20 > This is the declarative counterpart of 'gexp->derivation'." Please update doc/guix.texi as well. Otherwise LGTM, thanks! Ludo=E2=80=99.