From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cAnGEFWMXl+XTAAA0tVLHw (envelope-from ) for ; Sun, 13 Sep 2020 21:17:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6FkDC1WMXl9xXAAAB5/wlQ (envelope-from ) for ; Sun, 13 Sep 2020 21:17:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BEA879404D7 for ; Sun, 13 Sep 2020 21:17:08 +0000 (UTC) Received: from localhost ([::1]:37714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHZMx-00074P-4W for larch@yhetil.org; Sun, 13 Sep 2020 17:17:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHZMt-00074G-9c for guix-patches@gnu.org; Sun, 13 Sep 2020 17:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHZMs-0003Iw-FO for guix-patches@gnu.org; Sun, 13 Sep 2020 17:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHZMs-0005sr-AY for guix-patches@gnu.org; Sun, 13 Sep 2020 17:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43338] [PATCH] gnu: Add ripmime. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Sep 2020 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43338 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?S=C3=A9bastien?= Lerique Cc: 43338@debbugs.gnu.org Received: via spool by 43338-submit@debbugs.gnu.org id=B43338.160003181322599 (code B ref 43338); Sun, 13 Sep 2020 21:17:02 +0000 Received: (at 43338) by debbugs.gnu.org; 13 Sep 2020 21:16:53 +0000 Received: from localhost ([127.0.0.1]:51916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZMi-0005sR-Q0 for submit@debbugs.gnu.org; Sun, 13 Sep 2020 17:16:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHZMh-0005s7-PQ for 43338@debbugs.gnu.org; Sun, 13 Sep 2020 17:16:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38565) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHZMa-0003II-Rh; Sun, 13 Sep 2020 17:16:44 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47988 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHZMY-00044h-TJ; Sun, 13 Sep 2020 17:16:44 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87wo10fmgx.fsf@eauchat.org> Date: Sun, 13 Sep 2020 23:16:33 +0200 In-Reply-To: <87wo10fmgx.fsf@eauchat.org> ("=?UTF-8?Q?S=C3=A9bastien?= Lerique"'s message of "Fri, 11 Sep 2020 15:54:06 +0200") Message-ID: <87lfhd9y32.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: VBwCa7oWEH3l Hello S=C3=A9bastien! S=C3=A9bastien Lerique skribis: > * gnu/packages/mail.scm (ripmime): New variable. > --- > gnu/packages/mail.scm | 44 > +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) Looks like your mail client mangled the patch. Could you send it as an attachment or using =E2=80=98git send-email=E2=80=99? (See for a tutorial.) > diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm > index 7af7e8a8d7..48e9a11522 100644 > --- a/gnu/packages/mail.scm > +++ b/gnu/packages/mail.scm > @@ -627,6 +627,50 @@ Extension (MIME).") > (base32 > "0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi")))= ))) > > +(define-public ripmime > + (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9") > + (revision "1")) > + (package > + (name "ripmime") > + (version (git-version "1.4.0.10" revision commit)) In general we provide released versions, unless there=E2=80=99s a good reas= on to pick a development snapshot. If it falls in this category, could you add a short comment above the commit ID explaining why? > + (add-after 'unpack 'strip-buildcodes > + (lambda _ > + (substitute* "generate-buildcodes.sh" > + (("`date \\+%s`") "0") > + (("`date`") "0") > + (("`uname -a`") "Guix")))) Please return #t at the end of the phase (it=E2=80=99s a convention). > + ;; https://github.com/inflex/ripMIME/pull/16 makes > `mkdir-p-bin-man unnecessary > + (add-before 'install 'mkdir-p-bin-man > + (lambda _ > + (mkdir-p (string-append (assoc-ref %outputs "out") > "/bin")) > + (mkdir-p (string-append (assoc-ref %outputs "out") > "/man"))))) Likewise. > + (synopsis "Extract attachments from MIME-encoded email") > + (description > + "ripMIME is a small program which is used to extract the > attached files s/which is used//g > +out of a MIME-encoded email package.") Could you send an updated patch? Thanks for this first contribution! :-) Ludo=E2=80=99.