From: "Ludovic Courtès" <ludo@gnu.org>
To: "Sébastien Lerique" <sl@eauchat.org>
Cc: 43338@debbugs.gnu.org
Subject: [bug#43338] [PATCH] gnu: Add ripmime.
Date: Sun, 13 Sep 2020 23:16:33 +0200 [thread overview]
Message-ID: <87lfhd9y32.fsf@gnu.org> (raw)
In-Reply-To: <87wo10fmgx.fsf@eauchat.org> ("Sébastien Lerique"'s message of "Fri, 11 Sep 2020 15:54:06 +0200")
Hello Sébastien!
Sébastien Lerique <sl@eauchat.org> skribis:
> * gnu/packages/mail.scm (ripmime): New variable.
> ---
> gnu/packages/mail.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
Looks like your mail client mangled the patch. Could you send it as an
attachment or using ‘git send-email’? (See <https://git-send-email.io/>
for a tutorial.)
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 7af7e8a8d7..48e9a11522 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -627,6 +627,50 @@ Extension (MIME).")
> (base32
> "0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))
>
> +(define-public ripmime
> + (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
> + (revision "1"))
> + (package
> + (name "ripmime")
> + (version (git-version "1.4.0.10" revision commit))
In general we provide released versions, unless there’s a good reason to
pick a development snapshot. If it falls in this category, could you
add a short comment above the commit ID explaining why?
> + (add-after 'unpack 'strip-buildcodes
> + (lambda _
> + (substitute* "generate-buildcodes.sh"
> + (("`date \\+%s`") "0")
> + (("`date`") "0")
> + (("`uname -a`") "Guix"))))
Please return #t at the end of the phase (it’s a convention).
> + ;; https://github.com/inflex/ripMIME/pull/16 makes
> `mkdir-p-bin-man unnecessary
> + (add-before 'install 'mkdir-p-bin-man
> + (lambda _
> + (mkdir-p (string-append (assoc-ref %outputs "out")
> "/bin"))
> + (mkdir-p (string-append (assoc-ref %outputs "out")
> "/man")))))
Likewise.
> + (synopsis "Extract attachments from MIME-encoded email")
> + (description
> + "ripMIME is a small program which is used to extract the
> attached files
s/which is used//g
> +out of a MIME-encoded email package.")
Could you send an updated patch?
Thanks for this first contribution! :-)
Ludo’.
next prev parent reply other threads:[~2020-09-13 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 13:54 [bug#43338] [PATCH] gnu: Add ripmime Sébastien Lerique
2020-09-13 21:16 ` Ludovic Courtès [this message]
2020-09-14 8:59 ` Sébastien Lerique
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfhd9y32.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43338@debbugs.gnu.org \
--cc=sl@eauchat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).