From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YCS1EcoYXl/HBAAA0tVLHw (envelope-from ) for ; Sun, 13 Sep 2020 13:04:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AM7pC8oYXl8PWwAAbx9fmQ (envelope-from ) for ; Sun, 13 Sep 2020 13:04:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA70694050D for ; Sun, 13 Sep 2020 13:04:09 +0000 (UTC) Received: from localhost ([::1]:50852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHRfr-0001ty-58 for larch@yhetil.org; Sun, 13 Sep 2020 09:04:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHRfm-0001tm-S1 for guix-patches@gnu.org; Sun, 13 Sep 2020 09:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHRfm-0004Ws-Is for guix-patches@gnu.org; Sun, 13 Sep 2020 09:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHRfm-0001Pz-Eo for guix-patches@gnu.org; Sun, 13 Sep 2020 09:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43159] [PATCH 1/2] scripts: Use 'define-command' and have 'guix help' use that. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Sep 2020 13:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43159 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 43159@debbugs.gnu.org Received: via spool by 43159-submit@debbugs.gnu.org id=B43159.16000022015406 (code B ref 43159); Sun, 13 Sep 2020 13:04:02 +0000 Received: (at 43159) by debbugs.gnu.org; 13 Sep 2020 13:03:21 +0000 Received: from localhost ([127.0.0.1]:49685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRf7-0001P7-3F for submit@debbugs.gnu.org; Sun, 13 Sep 2020 09:03:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHRf5-0001Ot-BQ for 43159@debbugs.gnu.org; Sun, 13 Sep 2020 09:03:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57839) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHRf0-0004U0-1e; Sun, 13 Sep 2020 09:03:14 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47046 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kHRez-0007fV-Jf; Sun, 13 Sep 2020 09:03:13 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200901203520.21103-1-ludo@gnu.org> <20200901204136.21375-1-ludo@gnu.org> <87r1rk595p.fsf@gmail.com> <87blinx9ii.fsf@gnu.org> <878sdg6sz8.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 13 Sep 2020 15:03:04 +0200 In-Reply-To: <878sdg6sz8.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 11 Sep 2020 14:58:19 -0400") Message-ID: <87lfhd7rsn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: j4kmhWFCjmdu Hi, Maxim Cournoyer skribis: > Sorry I couldn't reply faster. No problem. I went ahead with this patch series, but nothing=E2=80=99s set= in stone and I=E2=80=99m open to further changes. > Thanks for the detailed measurements! It does indeed seem your approach > is better, especially considering memory usage. Perhaps the commands > could have been moved to dedicated modules not using much dependency at > all so that their closure would have been small hence fast to load, but > keeping the commands definitions local to where they are useful is > definitely a nice property. We can=E2=80=99t really reduce the closure of commands. In particular, (gu= ix scripts system) has to load pretty much =E2=80=9Ceverything=E2=80=9D. What we could do is use #:autoload aggressively in the (guix scripts =E2=80= =A6) modules, such that startup time would be as small as possible=E2=80=94e.g., =E2=80=98--help=E2=80=99 would not trigger loading of a zillion modules. It=E2=80=99s a bit tedious though and not necessarily helpful in the general case where one is doing something non-trivial with the command. Well dunno, we could try! >> In summary, while this approach undoubtedly looks awkward to any Lisper, >> I think it=E2=80=99s a good way to not contribute to the general impress= ion of >> sluggishness and resource-hungriness of =E2=80=98guix=E2=80=99 commands.= :-) >> >>>> + (define (display-commands commands) >>>> + (let* ((names (map (lambda (command) >>>> + (string-join (command-name command))) >>>> + commands)) >>>> + (max-width (reduce max 0 (map string-length names)))) >>> >>> You can drop reduce and use (max (map string-length names)) instead. >> >> I could do (apply max (map =E2=80=A6)) but I don=E2=80=99t like the idea= of abusing >> variadic argument lists in that way=E2=80=94I know, it=E2=80=99s very su= bjective. ;-) > > Eh, I wonder why? I may be missing something, but if max allows it, > doesn't it mean it's a valid use? Anyway, just curious to know what are > the grounds for this personal preference :-). It=E2=80=99s mostly aesthetic, but it comes from the idea that there could = be limitations on the maximum number of arguments a procedure can take, or inefficiencies with dealing with many arguments. Now, in today=E2=80=99s G= uile, there are no such issues=E2=80=A6 (And now I look really silly!) :-) Ludo=E2=80=99.