From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UAQLAJYZZV+TCAAA0tVLHw (envelope-from ) for ; Fri, 18 Sep 2020 20:33:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SNeZN5UZZV/lCQAA1q6Kng (envelope-from ) for ; Fri, 18 Sep 2020 20:33:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E9599404C5 for ; Fri, 18 Sep 2020 20:33:25 +0000 (UTC) Received: from localhost ([::1]:45740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMsX-0002zj-Pv for larch@yhetil.org; Fri, 18 Sep 2020 16:21:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJMhm-0001Tl-2g for guix-patches@gnu.org; Fri, 18 Sep 2020 16:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJMhl-0001Ka-Om for guix-patches@gnu.org; Fri, 18 Sep 2020 16:10:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJMhl-0005Yr-J8 for guix-patches@gnu.org; Fri, 18 Sep 2020 16:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43494] [PATCH 1/4] gnu: Add guix-build-coordinator. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Sep 2020 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 43494@debbugs.gnu.org Received: via spool by 43494-submit@debbugs.gnu.org id=B43494.160045974621304 (code B ref 43494); Fri, 18 Sep 2020 20:10:01 +0000 Received: (at 43494) by debbugs.gnu.org; 18 Sep 2020 20:09:06 +0000 Received: from localhost ([127.0.0.1]:44514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJMgs-0005XY-8w for submit@debbugs.gnu.org; Fri, 18 Sep 2020 16:09:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJMgq-0005X5-2F for 43494@debbugs.gnu.org; Fri, 18 Sep 2020 16:09:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55939) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMgk-0001Ex-R1; Fri, 18 Sep 2020 16:08:58 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45400 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJMgk-0006Dg-Ez; Fri, 18 Sep 2020 16:08:58 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87o8m39bnc.fsf@cbaines.net> <20200918184042.22660-1-mail@cbaines.net> Date: Fri, 18 Sep 2020 22:08:56 +0200 In-Reply-To: <20200918184042.22660-1-mail@cbaines.net> (Christopher Baines's message of "Fri, 18 Sep 2020 19:40:39 +0100") Message-ID: <87lfh6vodj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: /X3pi9y9pfXc Hi! Christopher Baines skribis: > * gnu/packages/package-management.scm (guix-build-coordinator): New varia= ble. [...] > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (guile (assoc-ref inputs "guile")) > + (guile-effective-version > + (read-line > + (open-pipe* OPEN_READ > + (string-append guile "/bin/guile") > + "-c" "(display (effective-version))"))) Maybe use =E2=80=98target-guile-effective-version=E2=80=99 from (guix build guile-build-system). > + (wrap-program (string-append bin "/" file) > + `("PATH" ":" prefix > + (,bin ,(assoc-ref inputs "sqitch"))) > + `("PERL5LIB" ":" prefix > + (,(getenv "PERL5LIB"))) Do we really need PERL5LIB here? Shouldn=E2=80=99t it be done in the wrapp= er of =E2=80=98sqitch=E2=80=99 directly? > + (scandir bin > + (match-lambda > + ((or "." "..") #f) > + (_ #t)))) I think you could just use (find-files bin). > + (inputs > + `(("guile" ,guile-3.0-latest) Rather ,@(assoc-ref (package-native-inputs guix) "guile"). > + ("sqitch" ,sqitch) > + ("perl-dbd-sqlite" ,perl-dbd-sqlite))) Shouldn=E2=80=99t perl-dbd-sqlite be a dependency of sqitch? > + (home-page "https://git.cbaines.net/guile/guix/build-coordinator") > + (synopsis "") > + (description > + "") Missing! :-) LGTM with changes along these lines! Ludo=E2=80=99.