unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 43458@debbugs.gnu.org
Subject: [bug#43458] [PATCH] guix: build: Add a hint for unspecified value
Date: Fri, 18 Sep 2020 22:35:26 +0200	[thread overview]
Message-ID: <87lfh6u8kx.fsf@gnu.org> (raw)
In-Reply-To: <20200916234003.35f2ac07@tachikoma.lepiller.eu> (Julien Lepiller's message of "Wed, 16 Sep 2020 23:40:03 +0200")

Julien Lepiller <julien@lepiller.eu> skribis:

>>From b29a325ef52d402c9618bfe9f02e478134297c0f Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Wed, 16 Sep 2020 23:32:00 +0200
> Subject: [PATCH] guix: build: Add a hint for unspecified value.
                   ^
I tend to use “guix build:” as the prefix for this file.

> * guix/scripts/build.scm (options->things-to-build): Add a hint when we
> cannot build something.

Great idea!

> +      (raise (make-compound-condition
> +               (formatted-message (G_ "~s: not something we can build~%") x)
> +               (condition
> +                (&fix-hint
> +                 (hint
> +                   (if (unspecified? x)
> +                       (G_ "If you build from a file, make sure the last scheme
> +expression returns a package value.  @code{define-public} defines a variable,
> +but returns #<unspecified>.  To fix this, add a scheme expression at the end of
               ^
@code

> +the file that consists only of the package's variable name you defined. ex:

s/. ex:/as in this example:/

> +@example
> +(define-public my-package
> +  (package
> +    ...))
> +
> +my-package
> +@end example")
> +                       (G_ "If you build from a file, make sure the last scheme
> +expression returns a package, gexp, derivation value or a list of such
> +values.")))))))))

s/derivation value/derivation/

Also s/scheme/Scheme/ throughout.

OK with these changes, thank you!

Ludo’.




  reply	other threads:[~2020-09-18 20:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 21:40 [bug#43458] [PATCH] guix: build: Add a hint for unspecified value Julien Lepiller
2020-09-18 20:35 ` Ludovic Courtès [this message]
2020-09-29 13:16   ` bug#43458: " Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfh6u8kx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43458@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).