unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 43881@debbugs.gnu.org
Subject: [bug#43881] [PATCH 1/2] system: Add %base-packages-disk-utils.
Date: Wed, 14 Oct 2020 11:17:08 +0200	[thread overview]
Message-ID: <87lfg9f9pn.fsf@gnu.org> (raw)
In-Reply-To: <20201009134253.26375-1-efraim@flashner.co.il> (Efraim Flashner's message of "Fri, 9 Oct 2020 16:42:52 +0300")

Hi!

Efraim Flashner <efraim@flashner.co.il> skribis:

> * gnu/system.scm (%base-packages-disk-utils): New variable.


[...]

>    #:use-module (guix diagnostics)
> +  #:use-module (gnu packages admin)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages bash)
> +  #:use-module (gnu packages compression)
>    #:use-module (gnu packages cross-base)
> +  #:use-module (gnu packages cryptsetup)
> +  #:use-module (gnu packages disk)
> +  #:use-module (gnu packages file-systems)
> +  #:use-module (gnu packages firmware)
> +  #:use-module (gnu packages gawk)
>    #:use-module (gnu packages guile)
>    #:use-module (gnu packages guile-xyz)
> -  #:use-module (gnu packages admin)
>    #:use-module (gnu packages hurd)
> -  #:use-module (gnu packages linux)
> -  #:use-module (gnu packages pciutils)
> -  #:use-module (gnu packages package-management)
>    #:use-module (gnu packages less)
> -  #:use-module (gnu packages zile)
> -  #:use-module (gnu packages nano)
> -  #:use-module (gnu packages gawk)
> +  #:use-module (gnu packages linux)
>    #:use-module (gnu packages man)
> +  #:use-module (gnu packages nano)
> +  #:use-module (gnu packages package-management)
> +  #:use-module (gnu packages pciutils)
>    #:use-module (gnu packages texinfo)
> -  #:use-module (gnu packages compression)
> -  #:use-module (gnu packages firmware)
> +  #:use-module (gnu packages zile)
>    #:use-module (gnu services)
>    #:use-module (gnu services shepherd)
>    #:use-module (gnu services base)

Does it pull new modules or just reorder them?  If the latter, fine with me!

> @@ -159,6 +163,7 @@
>              %base-packages-interactive
>              %base-packages-linux
>              %base-packages-networking
> +            %base-packages-disk-utils
>              %base-packages-utils

Now there’s a precedent but I think we should have written “utilities”
for consistency with the rest of the code base.

Maybe you can do that here and then we can deprecate
‘%base-packages-utils’ in favor of ‘%base-package-utilities’.

Thanks,
Ludo’.




  parent reply	other threads:[~2020-10-14  9:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 13:39 [bug#43881] [PATCH 0/2] Deduplicate package sets Efraim Flashner
2020-10-09 13:42 ` [bug#43881] [PATCH 1/2] system: Add %base-packages-disk-utils Efraim Flashner
2020-10-09 13:42   ` [bug#43881] [PATCH 2/2] install: Deduplicate packages with %base-package sets Efraim Flashner
2020-10-14  9:19     ` Ludovic Courtès
2020-10-14  9:24       ` Efraim Flashner
2020-10-14  9:17   ` Ludovic Courtès [this message]
2020-10-14  9:21     ` [bug#43881] [PATCH 1/2] system: Add %base-packages-disk-utils Efraim Flashner
2020-10-15  7:55   ` bug#43881: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfg9f9pn.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43881@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).