From: EuAndreh via Guix-patches via <guix-patches@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: , 44721@debbugs.gnu.org
Subject: [bug#44721] [PATCH] gnu: Add terraform.
Date: Mon, 23 Nov 2020 09:12:34 -0300 [thread overview]
Message-ID: <87lfesjmq5.fsf@euandre.org> (raw)
In-Reply-To: <87o8jojn52.fsf@euandre.org>
EuAndreh <eu@euandre.org> writes:
> Now I get it: the Terraform repo used to vendor all of its dependencies,
> and has just stopped doing it recently [0].
>
> But the release tarball still contains all of the vendored dependencies.
> I'm still not sure if that is deliberate, or just left over from the
> previous model of vendoring everything from the source code repository
> itself.
>
> I'll check if the vendoring on the release tarball is deliberate now,
> and start packaging the dependencies as Christopher sugested.
>
> [0]: https://github.com/hashicorp/terraform/pull/26358
The commit [0] that removed the vendoring was done in September 24th,
and the release of v0.13.5 [1] was done in October 21st.
However the release of v0.13.5 was a backport, and didn't include the
commit that removed the vendoring. Only v0.14.0-rc1 (the current latest
release) onwards that has removed the vendoring.
So the "go-build-system" just worked because all of the dependencies
were already there. Switching to v0.14.0-rc1 should probably break the
build, and require the dependencies to be packaged individually.
[0]: https://github.com/hashicorp/terraform/commit/a7c5a72c3d079fd65b29dd99c1cd0210a4dd1d57
[1]: https://github.com/hashicorp/terraform/releases/tag/v0.13.5
next prev parent reply other threads:[~2020-11-23 12:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 13:31 [bug#44721] [PATCH] gnu: Add terraform EuAndreh via Guix-patches via
2020-11-20 9:21 ` Christopher Baines
2020-11-22 22:11 ` EuAndreh via Guix-patches via
2020-11-23 0:37 ` EuAndreh via Guix-patches via
2020-11-23 12:03 ` EuAndreh via Guix-patches via
2020-11-23 12:12 ` EuAndreh via Guix-patches via [this message]
2020-11-24 17:33 ` EuAndreh via Guix-patches via
2020-11-25 22:49 ` Marius Bakke
2020-11-25 23:34 ` EuAndreh via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfesjmq5.fsf@euandre.org \
--to=guix-patches@gnu.org \
--cc=44721@debbugs.gnu.org \
--cc=eu@euandre.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).