unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 45860-done@debbugs.gnu.org
Subject: bug#45860: [PATCH v2 5/5] services: postgresql: Add postgresql-role-service-type.
Date: Thu, 28 Jan 2021 13:05:47 +0100	[thread overview]
Message-ID: <87lfcd8dwk.fsf@gnu.org> (raw)
In-Reply-To: <87eei6hiiy.fsf@cbaines.net> (Christopher Baines's message of "Wed, 27 Jan 2021 08:48:53 +0000")


Hey,

> Why only support these two permissions/options? Accepting strings or
> symbols, and then just converting to an upper case string would allow
> all the permission options to be specified.

Sure, fixed.

> I'm guessing this service will fail if it's run twice, as the
> role/database will already exist?

Yes, I added a check for already existing roles before pushing.

Thanks,

Mathieu




      reply	other threads:[~2021-01-28 12:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 13:36 [bug#45860] Improve PostgreSQL service Mathieu Othacehe
2021-01-14 21:56 ` Christopher Baines
2021-01-15  8:56   ` Mathieu Othacehe
2021-01-16 11:44     ` Christopher Baines
2021-01-18 10:16 ` [bug#45860] [PATCH v2 0/5] services: postgresql: Improve service Mathieu Othacehe
2021-01-18 10:16   ` [bug#45860] [PATCH v2 1/5] services: postgresql: Use Guile datatypes Mathieu Othacehe
2021-01-18 10:16   ` [bug#45860] [PATCH v2 2/5] services: postgresql: Add socket directory support Mathieu Othacehe
2021-01-27  8:35     ` Christopher Baines
2021-01-28 12:04       ` Mathieu Othacehe
2021-01-18 10:16   ` [bug#45860] [PATCH v2 3/5] services: postgresql: Add log " Mathieu Othacehe
2021-01-18 10:16   ` [bug#45860] [PATCH v2 4/5] services: postgresql: Wrap long lines Mathieu Othacehe
2021-01-18 10:16   ` [bug#45860] [PATCH v2 5/5] services: postgresql: Add postgresql-role-service-type Mathieu Othacehe
2021-01-27  8:48     ` Christopher Baines
2021-01-28 12:05       ` Mathieu Othacehe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfcd8dwk.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=45860-done@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).