unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Stefan Reichör" <stefan@xsteve.at>
Cc: 48384-done@debbugs.gnu.org
Subject: bug#48384: [PATCH] gnu: Add emacs-tshell.
Date: Sat, 15 May 2021 00:07:20 +0200	[thread overview]
Message-ID: <87lf8ht1ev.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210512210507.230812-1-stefan@xsteve.at> ("Stefan Reichör"'s message of "Wed, 12 May 2021 23:05:07 +0200")

Hello,

Stefan Reichör <stefan@xsteve.at> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tshell): New variable.

I applied it with the changes explained below. Thank you!

> +(define-public emacs-tshell
> +  (let ((commit "47ef3a6c537b06eb422d9a124e1c44062223e323")
> +        (revision "0"))

I added a comment explaining why we are not using a tagged release.

> +    (package
> +      (name "emacs-tshell")
> +      (version (git-version "0.1" revision commit))

I changed "0.1" into "0.1.0" because that is what the Version keywords
says.

> +      (synopsis "A buffer-oriented Emacs shell.")

Synopsis must not start with an article and end with a period. You may
want to run "guix lint" to catch these.

> +      (description
> +       "This shell allows to run one line commands by hitting RET.  It supports
> +shell and emacs lisp commands.")

I slightly reworded the description.

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2021-05-14 22:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 21:05 [bug#48384] [PATCH] gnu: Add emacs-tshell Stefan Reichör
2021-05-14 22:07 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf8ht1ev.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=48384-done@debbugs.gnu.org \
    --cc=stefan@xsteve.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).