From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KC9pA9Ftw2Bl5QAAgWs5BA (envelope-from ) for ; Fri, 11 Jun 2021 16:06:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SJM/OtBtw2CpKgAAB5/wlQ (envelope-from ) for ; Fri, 11 Jun 2021 14:06:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 81DA01916C for ; Fri, 11 Jun 2021 16:06:08 +0200 (CEST) Received: from localhost ([::1]:46648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrhnT-0005WE-F9 for larch@yhetil.org; Fri, 11 Jun 2021 10:06:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrhnP-0005UE-5H for guix-patches@gnu.org; Fri, 11 Jun 2021 10:06:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrhnO-000838-TX for guix-patches@gnu.org; Fri, 11 Jun 2021 10:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lrhnO-0007fW-H1 for guix-patches@gnu.org; Fri, 11 Jun 2021 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48696] [PATCH 0/3] Documenting commit reverts and revocation Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Jun 2021 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48696 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 48696@debbugs.gnu.org Received: via spool by 48696-submit@debbugs.gnu.org id=B48696.162342032329431 (code B ref 48696); Fri, 11 Jun 2021 14:06:02 +0000 Received: (at 48696) by debbugs.gnu.org; 11 Jun 2021 14:05:23 +0000 Received: from localhost ([127.0.0.1]:39765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrhmk-0007ec-SW for submit@debbugs.gnu.org; Fri, 11 Jun 2021 10:05:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lrhmi-0007eP-WB for 48696@debbugs.gnu.org; Fri, 11 Jun 2021 10:05:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57078) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrhmd-0007Xn-CU; Fri, 11 Jun 2021 10:05:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49316 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrhmW-00063M-3F; Fri, 11 Jun 2021 10:05:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210527123554.4267-1-ludo@gnu.org> <20210527123554.4267-2-ludo@gnu.org> <87y2c0f0i4.fsf@cbaines.net> <87eedpet69.fsf@gnu.org> <87k0ngfra8.fsf@cbaines.net> <87tumgwrhh.fsf_-_@gnu.org> <87bl8gtpxk.fsf@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Prairial an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 11 Jun 2021 16:05:06 +0200 In-Reply-To: <87bl8gtpxk.fsf@cbaines.net> (Christopher Baines's message of "Tue, 08 Jun 2021 15:02:31 +0100") Message-ID: <87lf7g7azx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623420368; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=GAzN8Q7PyIquUQ13vw+LG7+opUQ2TAhmNFYLnES3658=; b=UmF5j6T/IsgxJ3k+Wt/Rq1ODScWCcGSU44v4qFALBwLnQFAd7eJLYp9vqaSEVbj4O5ox8+ rpQ38v5ahJ7N6KW6C/2GvDhUIKLHUGyN56hSMJExE3mlt9P0tB5/b/fwbocDocb43T/aYB 3C7BFuHITx4JLG/v/b6mwFGTMubjuX8vnj2MfOUvEI8lNwqRnFhDr6jRRRsAF1OJ1lWnFb 3CHRR5FAw0x9FF352JcRxq1ioF8j+/vuEadRGpWFdCFSywdvMeID3LAS7kU51KtacjGKHX eFucQtv3zVE5v3O6ZXMEBuIBTVFMBlvXqhggUmtdJSsAf3uUk5+woiw9v6WLYw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623420368; a=rsa-sha256; cv=none; b=Be+uf6xmRQ6kMWDdWjZ4MqB7fewATQk66+jg190etVlECfyjC/gNw372EJaIaTQAfy+22M fqYDKG0qC7NWlz6lL3hLSc0kOWMD5n1MTTMcCG4MQOcYp4P18w4naqZQvXNWWij9N6m0fK Xuyj4UxDn5tRvz2D6fMys71ygbIH3deMP94AEs4hOt250uDydGZZQXzfp5EBlVfAtme1HO thAvZIzgXVaZF4St825pCyiqpKLw2HzHagEwlO/y5QSjpcO1C8dY8ZlPoLZGUwc60fsP7i zH3JbPXacy5oZUtHG/x3bT+KutOEWJwaBAZZbSnn0uxxvJx5BbM6Wjjs1nwusQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 81DA01916C X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: XYNMdLFTB+fV Hi Chris, Christopher Baines skribis: > Ludovic Court=C3=A8s writes: [...] >> @subsection Addressing Issues >> >> Peer review (@pxref{Submitting Patches}) and tools such as >> @command{guix lint} (@pxref{Invoking guix lint}) and the test suite >> (@pxref{Running the Test Suite}) should catch issues before they are >> pushed. Yet, commits that ``break'' functionality might occasionally >> go through. When that happens, there are two priorities: mitigating >> the impact, and understanding what happened to reduce the chance of >> similar incidents in the future. The responsibility for both these >> things primarily lies with those involved, but like everything this is >> a group effort. >>=20=20=20 >> Some issues can directly affect all users---for instance because they >> make @command{guix pull} fail or break core functionality, because they >> break major packages (at build time or run time), or because they >> introduce known security vulnerabilities. > > I'm not sure what this paragraph is getting at? It=E2=80=99s supposed to be provide concrete guidance to a committer wonder= ing whether they can/should/are entitled to revert a given commit. > In any case, for security vulnerabilities, to affect all users they > would also have to occur in major packages. Agreed. The word =E2=80=9Cknown=E2=80=9D is important here: if I remove *-= CVE-*.patch, or if I downgrade a package, I=E2=80=99m likely introducing a =E2=80=9Cknow= n=E2=80=9D vulnerability; if I=E2=80=99m adding a new package that later happens to be vulnerable, it=E2=80=99s not a =E2=80=9Cknown=E2=80=9D vulnerability (it=E2= =80=99s just routine ;-)). > I think the above text looks good. As noted above, I'm unsure about the > second paragraph, but that's not a big issue. OK, thanks for taking the time to discuss it. I=E2=80=99ll send a v2 so everyone gets a chance to chime in. Ludo=E2=80=99.