From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gCImMrFtxmAYegEAgWs5BA (envelope-from ) for ; Sun, 13 Jun 2021 22:42:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eIZ5LbFtxmAIdQAAbx9fmQ (envelope-from ) for ; Sun, 13 Jun 2021 20:42:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 38C7016FEC for ; Sun, 13 Jun 2021 22:42:25 +0200 (CEST) Received: from localhost ([::1]:36494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsWw3-0004Rz-Nn for larch@yhetil.org; Sun, 13 Jun 2021 16:42:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsWvi-0004RW-EB for guix-patches@gnu.org; Sun, 13 Jun 2021 16:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsWvi-0004Sy-61 for guix-patches@gnu.org; Sun, 13 Jun 2021 16:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lsWvi-0002Gh-0v for guix-patches@gnu.org; Sun, 13 Jun 2021 16:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48909] [PATCH] gnu: Add goldendict. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Jun 2021 20:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48909 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sergey Trofimov Cc: 48909@debbugs.gnu.org, mail@brendan.scot Received: via spool by 48909-submit@debbugs.gnu.org id=B48909.16236168648634 (code B ref 48909); Sun, 13 Jun 2021 20:42:01 +0000 Received: (at 48909) by debbugs.gnu.org; 13 Jun 2021 20:41:04 +0000 Received: from localhost ([127.0.0.1]:44440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsWul-0002FC-Th for submit@debbugs.gnu.org; Sun, 13 Jun 2021 16:41:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsWuj-0002Ea-HB for 48909@debbugs.gnu.org; Sun, 13 Jun 2021 16:41:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52454) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsWuc-0003dk-8B; Sun, 13 Jun 2021 16:40:54 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57648 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsWuc-0000dl-0o; Sun, 13 Jun 2021 16:40:54 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <1051806061.54116.1623162973231@office.mailbox.org> <87tum8qfwo.fsf@sarg.org.ru> Date: Sun, 13 Jun 2021 22:40:52 +0200 In-Reply-To: <87tum8qfwo.fsf@sarg.org.ru> (Sergey Trofimov's message of "Tue, 08 Jun 2021 22:07:19 +0200") Message-ID: <87lf7dzeej.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623616945; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=89HsQ+r3yJmYaMseh7QFtqu8oIMRZflfjApQ4DKeso0=; b=R3KXKTzBjI2kWAuP+LcmZFInxYOILBjmK4E0DOJRDeBjAI0q+KwfkE/MjMUGdVOGxcLqCO e5VJNSuRBcHYkxeMaGkZtJvbaiFzprf2mhLLGwuwnW/oitNWrelvxGcU306YU4Akw9RZla RpZigL2LJk2AoIS1aIsYFfV5h7ZHeAPo53lflx+0qtqvInnjodL3CoLGOnSKQ2AoLpVHVI Y9vzsjF1F5taisLjjVciYPsUmO8LOo+JmVFF40Io6Pr4BcFYfMo2U+S96ZClEptE2wupzo 2CGxw83djMpyWW3HfBhKLktAnNcpgLj9hws3QZpoy9sSe89+979ITc/Ao0LL7g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623616945; a=rsa-sha256; cv=none; b=o8dr0SXscrjGrAB2LVvVxsZPdom9lGDKB893r7CO3vsNResHG0BMVMGfHU/DEvMpxCwvoV qnB3b+qUWpJU4F+5ODyDwnVitRpC9cYOLfFph4u8rb14TX21ERTtpeFtyvJnwI4VCGW4yP 78q5neYbf8wsmdjtBGow6376gurxMhlBsH3WiBlyNnUvF5e0yw8voyjXi3N38DQNloua0s Abkb0KK/5oHlkvcNiyEDGO9JR8IN/XtBuNovaQbkKINB40injgdZpm56+bu11CKpgw/+/z O1Icvka/Hu10LmCT2fFeMTFLFurtvDR4nF25eaWj51ugyXcsSUvt51KSjT1QTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 38C7016FEC X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: zfhoDOCIYjsL Hi Sergey, Sergey Trofimov skribis: > I've reused the patch from nixpkgs and added opencc dependency. > >>>From e5c96b58f23f56da605b4ccdf3cef7d04ef379c9 Mon Sep 17 00:00:00 2001 > From: Sergey Trofimov > Date: Mon, 7 Jun 2021 21:50:30 +0200 > Subject: [PATCH] gnu: Add goldendict. > > --- > gnu/packages/dictionaries.scm | 65 +++++++++++++++++++ > .../goldendict-remove-check-for-update.patch | 49 ++++++++++++++ > 2 files changed, 114 insertions(+) > create mode 100644 gnu/packages/patches/goldendict-remove-check-for-upda= te.patch Overall it LGTM, and it=E2=80=99s great that you addressed the issue Brendan mentioned. Minor issues: [...] > +++ b/gnu/packages/patches/goldendict-remove-check-for-update.patch > @@ -0,0 +1,49 @@ > +diff --git i/config.cc w/config.cc Please add a line or two at the top explaining what the patch does. Also add this file to =E2=80=98gnu/local.mk=E2=80=99. Bonus points if you attempt a ChangeLog-style commit log. :-) (See .) Could you send an updated patch? Thank you! Ludo=E2=80=99.