unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Sergey Trofimov <sarg@sarg.org.ru>
Cc: 48909@debbugs.gnu.org, mail@brendan.scot
Subject: [bug#48909] [PATCH] gnu: Add goldendict.
Date: Sun, 13 Jun 2021 22:40:52 +0200	[thread overview]
Message-ID: <87lf7dzeej.fsf_-_@gnu.org> (raw)
In-Reply-To: <87tum8qfwo.fsf@sarg.org.ru> (Sergey Trofimov's message of "Tue,  08 Jun 2021 22:07:19 +0200")

Hi Sergey,

Sergey Trofimov <sarg@sarg.org.ru> skribis:

> I've reused the patch from nixpkgs and added opencc dependency.
>
>>From e5c96b58f23f56da605b4ccdf3cef7d04ef379c9 Mon Sep 17 00:00:00 2001
> From: Sergey Trofimov <sarg@sarg.org.ru>
> Date: Mon, 7 Jun 2021 21:50:30 +0200
> Subject: [PATCH] gnu: Add goldendict.
>
> ---
>  gnu/packages/dictionaries.scm                 | 65 +++++++++++++++++++
>  .../goldendict-remove-check-for-update.patch  | 49 ++++++++++++++
>  2 files changed, 114 insertions(+)
>  create mode 100644 gnu/packages/patches/goldendict-remove-check-for-update.patch

Overall it LGTM, and it’s great that you addressed the issue Brendan
mentioned.

Minor issues:


[...]

> +++ b/gnu/packages/patches/goldendict-remove-check-for-update.patch
> @@ -0,0 +1,49 @@
> +diff --git i/config.cc w/config.cc

Please add a line or two at the top explaining what the patch does.

Also add this file to ‘gnu/local.mk’.

Bonus points if you attempt a ChangeLog-style commit log.  :-)
(See <https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html>.)

Could you send an updated patch?

Thank you!

Ludo’.




  reply	other threads:[~2021-06-13 20:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 20:05 [bug#48909] [PATCH] gnu: Add goldendict Sergey Trofimov
2021-06-08 14:36 ` Brendan Tildesley
2021-06-08 20:07   ` Sergey Trofimov
2021-06-13 20:40     ` Ludovic Courtès [this message]
2021-06-14  6:26 ` Sergey Trofimov
2021-07-03 14:13 ` Sergey Trofimov
2021-07-03 17:30 ` [bug#48909] Rebased on the latest commit in master Sergey Trofimov
2021-07-03 17:32 ` [bug#48909] [PATCH] gnu: Add goldendict Sergey Trofimov
2022-01-22 21:06 ` Pāladhammika via Guix-patches via
2022-03-27 16:09 ` Maxime Devos
2022-03-28  8:26 ` Sergey Trofimov
2022-03-28  9:46 ` [bug#48909] Package definition updated Sergey Trofimov
2024-01-23 22:30 ` [bug#48909] [PATCH] gnu: Add goldendict Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf7dzeej.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=48909@debbugs.gnu.org \
    --cc=mail@brendan.scot \
    --cc=sarg@sarg.org.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).