unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: Vagrant Cascadian <vagrant@debian.org>
Cc: Mathieu Othacehe <othacehe@gnu.org>,
	Pierre Langlois <pierre.langlois@gmx.com>,
	49552-done@debbugs.gnu.org
Subject: bug#49552: [PATCH] gnu: u-boot: Update to 2021.07.
Date: Mon, 02 Aug 2021 13:31:02 +0100	[thread overview]
Message-ID: <87lf5k81qm.fsf@gmx.com> (raw)
In-Reply-To: <87lf5k6fo4.fsf@yucca>

[-- Attachment #1: Type: text/plain, Size: 2502 bytes --]

Hi!

Vagrant Cascadian <vagrant@debian.org> writes:

> [[PGP Signed Part:Undecided]]
> On 2021-07-26, Pierre Langlois wrote:
>> Vagrant Cascadian writes:
>>
>>> On 2021-07-25, Mathieu Othacehe wrote:
>>>>> * gnu/packages/bootloaders.scm (u-boot): Update to 2021.07.
>>>>> [native-inputs]: Add python-pycryptodomex.
>>>>> (u-boot-2021.07): Delete variable.
>>>>> (u-boot-tools)[arguments]: Adapt 'patch phase, disable failing test_spl test.
>>>>> (u-boot-sifive-unmatched): Use default u-boot package.
>>>>> (u-boot-pinebook-pro-rk3328): Use default u-boot package.
>>>>
>>>> This seems fine to me, Vagrant any objections here?
>>>
>>> Heh. Just uploaded 2021.07 to Debian last night! Been meaning to look at
>>> updating in guix, but apparently someone beat me to it :)
>>>
>>> Overall, sounds fine to me, with one relatively minor change...
>>>
>>> u-boot-sifive-unmatched will need a pretty trivial patch in order to
>>> update to 2021.07:
>>>
>>>   https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/1937246
>>>   https://salsa.debian.org/debian/u-boot/-/blob/debian/latest/debian/patches/riscv64/unmatched-prevent-relocating-initrd-and-fdt.patch
>>>
>>> At least, it did when building on Debian (and apparently Ubuntu)...
>>
>> Sure, I've added the patch! I don't have any HW to test sifive unmatched
>> support though, I did test the update on a pinebookpro and rockpro64
>> when originally posting this, the new patch shouldn't affect them.
>
> I have pretty high confidence it's needed, has low risk for breaking
> other u-boot platforms, and riscv64 support in guix is pretty
> experimental at this point so I would say safe to go with it untested at
> this point... though at some point I can test it on actual hardware if
> it really is needed.

Sounds good to me!

>
>
>> That being said, while it works on pinebookpro, I still need an extra
>> patch on the rockpro64 in order to boot, both on master with u-boot
>> 2021.07 :-/ (see #49550).
>>
>> Were you able to confirm the issue? I see it looks like we have the same
>> configuration in debian and guix, CONFIG_USE_PREBOOT=y and the
>> "inno-usb" patch applied, mmmm
>
> Seems like you fixed the core of that problem in another commit!
>
> Patch looks good to me, thanks for working on it!

Thanks for the review! I've just pushed it as
eb46c6c5c81695af475f7e1e416d05e51157fe60, with a couple of tweaks to
make `guix lint' happy (the patch filename was a little too long, as
well as a line was over the column limit).

Thanks,
Pierre

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

  reply	other threads:[~2021-08-02 12:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 19:56 [bug#49552] [PATCH] gnu: u-boot: Update to 2021.07 Pierre Langlois
2021-07-25 15:55 ` Mathieu Othacehe
2021-07-25 17:06   ` Vagrant Cascadian
2021-07-26 10:54     ` Pierre Langlois
2021-08-01 21:03       ` Vagrant Cascadian
2021-08-02 12:31         ` Pierre Langlois [this message]
2021-08-02 16:02           ` Pierre Langlois
2021-08-02 19:32             ` Vagrant Cascadian
2021-08-05 12:37               ` Pierre Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf5k81qm.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=49552-done@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    --cc=vagrant@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).