From: Xinglu Chen <public@yoctocell.xyz>
To: 50873@debbugs.gnu.org
Cc: "Antero Mejr" <antero@mailbox.org>,
"Ludovic Courtès" <ludo@gnu.org>,
"Andrew Tropin" <andrew@trop.in>
Subject: [bug#50873] [bug#50796] [PATCH] gnu: Add pn.
Date: Tue, 28 Sep 2021 20:59:52 +0200 [thread overview]
Message-ID: <87lf3g34rb.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210925032815.68194-1-antero@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 5267 bytes --]
On Fri, Sep 24 2021, Antero Mejr via Guix-patches via wrote:
> * gnu/packages/telephony.scm (pn): New variable.
The ‘libphonenumber’ package is also added; this should be split into
patches, each adding one new package.
> ---
> Add pn and its dependencies.
> It's a phone number CLI tool used by Linux phone GUIs like SXMO.
>
> gnu/packages/telephony.scm | 72 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index 48bbe12920..9015cf536a 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -20,6 +20,7 @@
> ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
> ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
> +;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -54,12 +55,14 @@
> #:use-module (gnu packages documentation)
> #:use-module (gnu packages file)
> #:use-module (gnu packages protobuf)
> + #:use-module (gnu packages gawk)
> #:use-module (gnu packages gettext)
> #:use-module (gnu packages gl)
> #:use-module (gnu packages glib)
> #:use-module (gnu packages gnome)
> #:use-module (gnu packages gnupg)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages icu4c)
> #:use-module (gnu packages image)
> #:use-module (gnu packages libcanberra)
> #:use-module (gnu packages linphone)
> @@ -907,3 +910,72 @@ Initiation Protocol (SIP) and a multimedia framework.")
> telephony functionality into custom Telegram clients.")
> (home-page "https://github.com/zevlg/libtgvoip")
> (license license:unlicense)))
> +
> +(define-public libphonenumber
> + (package
> + (name "libphonenumber")
> + (version "8.12.33")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/google/libphonenumber")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f
There should be a comment explaining why tests are disabled.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-dir
> + (lambda _ (chdir "cpp") #t)))))
Phases don’t have to return #t.
> + (inputs
> + `(("boost" ,boost)
> + ("googletest" ,googletest)
> + ("protobuf" ,protobuf)
> + ("icu4c" ,icu4c)))
> + (home-page "https://github.com/google/libphonenumber")
> + (synopsis "C++ library for phone number parsing")
> + (description
> + "libphonenumber is Google's common Java, C++ and JavaScript library for
> +parsing, formatting, and validating international phone numbers.")
I would use @code{libphonenumber}.
The package doesn’t seem to be reproducible; ‘guix build libphonenumber
--rounds=2’ fails with
--8<---------------cut here---------------start------------->8---
guix build: error: derivation `/gnu/store/a0vycg9ic70bziygn098bbvw4hy39zzb-libphonenumber-8.12.33.drv' may not be deterministic: output `/gnu/store/1ifj4ndpf3mv8nwbjp0gzrx5jpjvghgb-libphonenumber-8.12.33' differs
--8<---------------cut here---------------end--------------->8---
Could you look into this?
> + (license license:asl2.0)))
> +
> +(define-public pn
> + (package
> + (name "pn")
> + (version "0.9.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/Orange-OpenSource/pn")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f
Why are tests disabled?
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'sub-bin-path
> + (lambda _
> + (substitute* "CMakeLists.txt" (("DESTINATION \\$\\{AWKLIBPATH\\}")
> + "DESTINATION bin")))))))
> + (inputs
> + `(("libphonenumber" ,libphonenumber)
> + ("icu4c" ,icu4c)
> + ("protobuf" ,protobuf)
> + ("gawk" ,gawk)))
> + (home-page "https://github.com/Orange-OpenSource/pn")
> + (synopsis "Command-line validation tool for phone numbers")
> + (description
> + "pn is a tool that allows command line user/programmers to operate on
> +phone numbers (get validity information, reformat them, or extract numbers
> +from a text snippet), using libphonenumber.")
I suggest
@code{pn} provides a command line tools that allows on to operate on
phone numbers (get validity information, reformat them, or extract
numbers from a text snippet), using @code{libphonenumber}.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-09-28 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 3:28 [bug#50796] [PATCH] gnu: Add pn Antero Mejr via Guix-patches via
2021-09-28 18:59 ` Xinglu Chen [this message]
2021-09-28 20:56 ` [bug#50796] [PATCH 0/2] " Antero Mejr via Guix-patches via
2021-09-28 20:56 ` [bug#50796] [PATCH 1/2] gnu: Add libphonenumber Antero Mejr via Guix-patches via
2021-09-29 11:42 ` Xinglu Chen
2022-01-17 10:06 ` Nicolas Goaziou
2021-09-28 20:56 ` [bug#50796] [PATCH 2/2] gnu: Add pn Antero Mejr via Guix-patches via
2022-08-11 19:11 ` [bug#50796] [PATCH] " Antero Mejr via Guix-patches via
2022-08-12 14:39 ` bug#50796: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf3g34rb.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50873@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=antero@mailbox.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).