unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: jgart <jgart@dismail.de>
Cc: 51039-done@debbugs.gnu.org
Subject: bug#51039: [PATCH] gnu: python-gitpython: Update to 3.1.20.
Date: Sat, 16 Oct 2021 15:49:43 +0530	[thread overview]
Message-ID: <87lf2ts24g.fsf@systemreboot.net> (raw)
In-Reply-To: <20211005151957.19756-1-jgart@dismail.de>

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]


Hi jgart,

Thanks for the updated patch! I have pushed this patch to master with
the following changes.

> * gnu/packages/version-control.scm (python-gitpython): Update to 3.1.24.
>
> [propagated-inputs]: Add python-typing-extensions.

I removed the blank line above before [propagated-inputs], added a
copyright header for you, removed the #t return from the custom
embed-git-reference phase, and mentioned the removal in the commit
message.

>      (arguments
>       `(#:tests? #f ;XXX: Tests can only be run within the GitPython
>       repository.

If you have the time and are interested, you could also try getting the
tests working for this package, and send a patch with me on Cc. I'll be
happy to review it. Judging from the comment, it seems like switching
from PyPI to the GitHub source might be the solution.

Thanks!
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

      parent reply	other threads:[~2021-10-16 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 15:19 [bug#51039] [PATCH] gnu: python-gitpython: Update to 3.1.20 jgart via Guix-patches via
2021-10-09 14:40 ` Arun Isaac
2021-10-10  6:29 ` [bug#51039] jgart via Guix-patches via
2021-10-10  6:29   ` [bug#51039] [PATCH] gnu: python-gitpython: Update to 3.1.24 jgart via Guix-patches via
2021-10-16 10:19 ` Arun Isaac [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf2ts24g.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=51039-done@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).