unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Wiktor Żelazny" <wz@freeshell.de>
Cc: 45565-done@debbugs.gnu.org
Subject: bug#45565: [PATCH 0/2] Add more r-mlr3 add-ons
Date: Fri, 31 Dec 2021 20:20:53 +0100	[thread overview]
Message-ID: <87lf00fujz.fsf@elephly.net> (raw)
In-Reply-To: <20201231124608.1090-1-wz@freeshell.de>


Hi Wiktor,

I’m terribly sorry for the delay.  These two patches are fine and
slipped through the cracks.  I updated the packages to the new input
style and pushed them to the “master” branch.

> As for r-mlr3ordinal, the linter reported
>
> ./gnu/packages/cran.scm:25616:15: r-mlr3ordinal@0.1.0-9000-0.9febac9: the source file name should contain the package name
>
> I don’t know what “source file name” is referenced here, so I’m
> submitting the definition as it is.

This is due to the use of git-reference; you need to provide “file-name”
to give a name to the source checkout.  I did this when I applied your
patches.

Thanks for these patches!

-- 
Ricardo




      parent reply	other threads:[~2021-12-31 19:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-31 12:46 [bug#45565] [PATCH 0/2] Add more r-mlr3 add-ons Wiktor Żelazny
2020-12-31 12:53 ` [bug#45565] [PATCH 1/2] gnu: Add r-mlr3pipelines Wiktor Żelazny
2020-12-31 12:53   ` [bug#45565] [PATCH 2/2] gnu: Add r-mlr3ordinal Wiktor Żelazny
2021-12-31 19:20 ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf00fujz.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=45565-done@debbugs.gnu.org \
    --cc=wz@freeshell.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).