unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#53495] [PATCH] gnu: FreeCAD: Replace QtWebKit with QtWebEngine.
@ 2022-01-24  8:06 Leo Famulari
  2022-01-25 10:40 ` Guillaume Le Vaillant
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2022-01-24  8:06 UTC (permalink / raw)
  To: 53495

See <https://issues.guix.gnu.org/53289> for more information about this change.

* gnu/packages/engineering.scm (freecad)[inputs]: Remove QTWEBKIT. Add
QTDECLARATIVE, QTWEBCHANNEL, and QTWEBENGINE.
---
 gnu/packages/engineering.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index f4c5d73e00..23133a50eb 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2483,8 +2483,10 @@ (define-public freecad
            python-shiboken-2
            python-wrapper
            qtbase-5
+           qtdeclarative
            qtsvg
-           qtwebkit
+           qtwebchannel
+           qtwebengine
            qtx11extras
            qtxmlpatterns
            sqlite
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#53495] [PATCH] gnu: FreeCAD: Replace QtWebKit with QtWebEngine.
  2022-01-24  8:06 [bug#53495] [PATCH] gnu: FreeCAD: Replace QtWebKit with QtWebEngine Leo Famulari
@ 2022-01-25 10:40 ` Guillaume Le Vaillant
  2022-01-25 18:39   ` bug#53495: " Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Guillaume Le Vaillant @ 2022-01-25 10:40 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 53495

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Leo Famulari <leo@famulari.name> skribis:

> See <https://issues.guix.gnu.org/53289> for more information about this change.
>
> * gnu/packages/engineering.scm (freecad)[inputs]: Remove QTWEBKIT. Add
> QTDECLARATIVE, QTWEBCHANNEL, and QTWEBENGINE.
> ---
>  gnu/packages/engineering.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index f4c5d73e00..23133a50eb 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -2483,8 +2483,10 @@ (define-public freecad
>             python-shiboken-2
>             python-wrapper
>             qtbase-5
> +           qtdeclarative
>             qtsvg
> -           qtwebkit
> +           qtwebchannel
> +           qtwebengine
>             qtx11extras
>             qtxmlpatterns
>             sqlite

LGTM

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#53495: [PATCH] gnu: FreeCAD: Replace QtWebKit with QtWebEngine.
  2022-01-25 10:40 ` Guillaume Le Vaillant
@ 2022-01-25 18:39   ` Leo Famulari
  0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2022-01-25 18:39 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: 53495-done

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

On Tue, Jan 25, 2022 at 10:40:34AM +0000, Guillaume Le Vaillant wrote:
> LGTM

Thanks for the review! Pushed as
676de0a34c7fab3c12e36e0d8349db6ee8da65da

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-25 18:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-24  8:06 [bug#53495] [PATCH] gnu: FreeCAD: Replace QtWebKit with QtWebEngine Leo Famulari
2022-01-25 10:40 ` Guillaume Le Vaillant
2022-01-25 18:39   ` bug#53495: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).