bug#53879: [PATCH] gnu: Add emacs-everywhere.

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Jai Vetrivelan <jaivetrivelan@gmail.com> writes:

Thanks for the update. I'm sorry: I pointed you, as an example, to
a package using old syntax.

> +(define-public emacs-everywhere
> +  ;; No upstream release.  Extract version from main file.
> +  (let ((commit "ace53396a66ed4b753f42c04a5a0db2bcd770423")
> +        (revision "0"))
> +    (package
> +      (name "emacs-everywhere")
> +      (version (git-version "0.0.1" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/tecosaur/emacs-everywhere")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "0p55shxvqm1713af33mfglny7rpi31d42wvgwylcsfy4jvnsq8bb"))))
> +      (arguments
> +       `(#:phases (modify-phases %standard-phases

We're now using G-expressions, which are less ambiguous than quasi-quotes:

(arguments
 (list
  #:phases
  #~(modify-phases %standard-phases

> +                    (add-after 'unpack 'patch-exec-paths
> +                      (lambda* (#:key inputs #:allow-other-keys)
> +                        (let ((xclip (assoc-ref inputs "xclip"))
> +                              (xdotool (assoc-ref inputs "xdotool"))
> +                              (xprop (assoc-ref inputs "xprop"))
> +                              (xwininfo (assoc-ref inputs "xwininfo")))

We don't use (assoc-ref inputs ...) expressions anymore. It is possible
to replace those calls with `search-input-file'.

> +                          (substitute* "emacs-everywhere.el"
> +                            (("\"xclip\"") (string-append "\"" xclip
> +                                                          "/bin/xclip\""))

For example, here, it is possible to write

  (string-append "\"" (search-input-file inputs "/bin/xclip") "\"")

> +                        #t)))))

Phases do not need to end with "#t" anymore, so this can be dropped.

I made the changes above on your behalf and applied your patch.

Regards,
-- 
Nicolas Goaziou