From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +JAAEiOOB2LwfgAAgWs5BA (envelope-from ) for ; Sat, 12 Feb 2022 11:38:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qJe1CiOOB2LkgAEAG6o9tA (envelope-from ) for ; Sat, 12 Feb 2022 11:38:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9B6FBEB0E for ; Sat, 12 Feb 2022 11:38:26 +0100 (CET) Received: from localhost ([::1]:44114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIpnN-0003qh-E8 for larch@yhetil.org; Sat, 12 Feb 2022 05:38:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIpn0-0003qQ-76 for guix-patches@gnu.org; Sat, 12 Feb 2022 05:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIpmz-0002Ix-Tz for guix-patches@gnu.org; Sat, 12 Feb 2022 05:38:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIpmz-0008VW-QT for guix-patches@gnu.org; Sat, 12 Feb 2022 05:38:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53781] [PATCH shepherd] support: Use XDG_STATE_HOME for log files. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Feb 2022 10:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53781 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 53781@debbugs.gnu.org Received: via spool by 53781-submit@debbugs.gnu.org id=B53781.164466225832673 (code B ref 53781); Sat, 12 Feb 2022 10:38:01 +0000 Received: (at 53781) by debbugs.gnu.org; 12 Feb 2022 10:37:38 +0000 Received: from localhost ([127.0.0.1]:33568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIpmc-0008Uu-E4 for submit@debbugs.gnu.org; Sat, 12 Feb 2022 05:37:38 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:33727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIpma-0008Ug-5j for 53781@debbugs.gnu.org; Sat, 12 Feb 2022 05:37:37 -0500 Received: (Authenticated sender: brice@waegenei.re) by mail.gandi.net (Postfix) with ESMTPSA id 4E29540002; Sat, 12 Feb 2022 10:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waegenei.re; s=gm1; t=1644662249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xKzgbXTQuXbrfgbYvlM1vHD2/3R7SnJXaAkzGuGmDoY=; b=XnJomd8jxQBGAwTLCxQcMEOC5D8bpRGAaTCMxQE9Rmb0+m0VIXd8LqZR+IABfXOZuy8EnU 9aRi5V+GDXkeL8jkO9vGZm/pgEoWW3x8Tm1o+holJypxH2iESOUHt90B/QFW3f+tVfldS9 nG9/Q/cz1rrRt8xkR7JeyW3R/BCutt8ZXJ2d0fQGVaoxh4jw+QiF3kV6iTVonXCpQJI3kR tvU+PIq2/OOhPp6Al4ZP72VCxSU/N80AAbVzZXTRLLI99iBiHcZl84is2DqKSDWUIWmXgh tPXjxIYIBq2I8oYjbC7Cg/g3Z5VF1oE5OTy8b1mDc37OCxrLQAuz/2pnJegBcw== From: Brice Waegeneire References: <062d00aaa485dd2c8524f6822a524cb3cb3bdc55.camel@gmail.com> Date: Sat, 12 Feb 2022 11:37:26 +0100 In-Reply-To: <062d00aaa485dd2c8524f6822a524cb3cb3bdc55.camel@gmail.com> (Liliana Marie Prikler's message of "Fri, 4 Feb 2022 09:07:09 +0100") Message-ID: <87leygweu1.fsf@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644662306; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=xKzgbXTQuXbrfgbYvlM1vHD2/3R7SnJXaAkzGuGmDoY=; b=lDf1v2xq2eiCYxwT9s5TH6gSJX4g6UvTfdxEwBvLInBcCcTNdBNeAKgsJs8rJ8qpHEiS+0 BrSUsvV1Hl6GTYwc8GFi55qpxmA3nwdLBe6k/5dIW6m/rtqkuj0wobeLHUALNau/eO4en6 7f9aZiYBYEokjs88PvvJ9AdQpYJpesFPKmjZ6G7hShoBs5/qodGM7qjqM6Pk6QPcMp56WJ 4iGcvKiL6nisL5T8gAu0cStos15yG3RpY7B3ERvB0yloWYIr6GM342ijzBBriaguEiqtDi baPRLUN+8VMhJKKDVF0HIF4q4N/hPAtx69rqZKo0n5g8rJqkTSwuYaWp1JzBdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644662306; a=rsa-sha256; cv=none; b=qu5NBQMmW8RQwpRCKQVJsHhC8QXwxCIZQXwg2AaAC2rClpUQk86xT4S0eFbLLCldsfl6G0 iPGcV4hDZskMlqfS7ZR4YUOBkNz4tJOaN+qQQ5QXIbbntJ4LFoTPX70k43QsFquxm+X5t8 0lwxb49weQDT45d4jIEMOouSVhOoTsgBD2Y+e/MqZoPqR/IbK7HumE+1c62yL0TrBcyyYq cKTHSflcpKE4mB/diYJqkM1XLppkTmCK6O+PU09e2w5neBRzJiXjFg6dpSPAPxlLl15eTm HvZ1Kve3y1BllCwS/OKv/dmCxZDDds0yZx6DRNLWIThaPD9lGBwHwiR4Iyhh3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=waegenei.re header.s=gm1 header.b=XnJomd8j; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=waegenei.re header.s=gm1 header.b=XnJomd8j; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9B6FBEB0E X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZaLfxG+IPUey Hello Liliana, Liliana Marie Prikler writes: > As per XDG Base Directory Specification 0.8, "action history" (such as logs) > ought to be stored in $XDG_STATE_HOME, defaulting to $HOME/.local/state. > Respect this specification. > > * modules/shepherd/support.scm (%user-log-dir): Define in terms of > XDG_STATE_HOME. > * doc/shepherd.texi: Adjust accordingly. > * tests/basic.sh: Adjust accordingly. > --- > doc/shepherd.texi | 3 ++- > modules/shepherd/support.scm | 4 ++-- > tests/basic.sh | 4 +++- > 3 files changed, 7 insertions(+), 4 deletions(-) [...] > diff --git a/tests/basic.sh b/tests/basic.sh > index 5079aa1..5ef1fb0 100644 > --- a/tests/basic.sh > +++ b/tests/basic.sh > @@ -260,7 +260,9 @@ test -f "$log" > > # Set XDG_CONFIG_HOME for configuration files. > export XDG_CONFIG_HOME=$confdir > -export XDG_DATA_DIR=$datadir > +export XDG_DATA_HOME=$datadir > +# Reuse XDG_DATA_HOME as XDG_STATE_HOME for backwards compatibility. > +export XDG_STATE_HOME=$datadir > mkdir -p $confdir/shepherd > mkdir -p $datadir/shepherd > mv $conf $confdir/shepherd/init.scm I don't get why you define XDG_DATA_HOME here, as it wasn't used before and it is a test and shouldn't need to be backward compatible except for testing such backward compatibility. Otherwise it LGTM! Thank you for the patch. Cheers, - Brice