From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54235@debbugs.gnu.org
Subject: [bug#54235] [PATCH v2 2/3] gnu: Add ck.
Date: Tue, 08 Mar 2022 09:38:02 -0500 [thread overview]
Message-ID: <87lexktsqd.fsf@gmail.com> (raw)
In-Reply-To: <5c45c324b79db0a56403c0e42787b28f61ebe02a.camel@telenet.be> (Maxime Devos's message of "Tue, 08 Mar 2022 10:45:12 +0100")
Hi,
Maxime Devos <maximedevos@telenet.be> writes:
> Maxim Cournoyer schreef op ma 07-03-2022 om 23:38 [-0500]:
>> + (define (gnu-triplet->machine target)
>> + (letrec-syntax
>> + ((matches (syntax-rules (=>)
>> + ((_ (target-prefix => machine) rest ...)
>> + (if (string-prefix? target-prefix target)
>> + machine
>> + (matches rest ...)))
>> + ((_)
>> + (error "unsupported target" target)))))
>> + ;; This basically reproduces the logic handling the
>> + ;; PLATFORM variable in the configure script.
>> + (matches ("x86_64" => "x86_64")
>> + ("i586" => "x86")
>> + ("i686" => "x86")
>> + ("aarch64" => "aarch64")
>> + ("arm" => "arm")
>> + ("ppc64" => "ppc64")
>> + ("ppc" => "ppc")
>> + ("s390x" => "s390x")
>> + ("sparc64" => "sparcv9"))))
>
> I would move this outside the build code, such that new targets can be
> added without having to rebuild ck and dependents.
Done!
> Also, there are a few 'target-foo?' procedures in (guix utils) that can be used here (if
> it were moved outisde the build code).
I left the code as-is, as it seemed more uniform this way.
Thanks,
Maxim
next prev parent reply other threads:[~2022-03-08 14:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 13:53 [bug#54235] [PATCH 0/3] Add sysbench Maxim Cournoyer
2022-03-03 14:05 ` [bug#54235] [PATCH 1/3] gnu: docbook-xml-4.1.2: Install an XML catalog file Maxim Cournoyer
2022-03-03 14:05 ` [bug#54235] [PATCH 2/3] gnu: Add ck Maxim Cournoyer
2022-03-03 16:55 ` Maxime Devos
2022-03-07 18:57 ` Maxim Cournoyer
2022-03-07 20:57 ` Maxime Devos
2022-03-08 1:47 ` Maxim Cournoyer
2022-03-08 4:06 ` Maxim Cournoyer
2022-03-03 14:05 ` [bug#54235] [PATCH 3/3] gnu: Add sysbench Maxim Cournoyer
2022-03-03 16:42 ` Maxime Devos
2022-03-07 18:59 ` Maxim Cournoyer
2022-03-08 4:38 ` [bug#54235] [PATCH v2 1/3] gnu: docbook-xml-4.1.2: Install an XML catalog file Maxim Cournoyer
2022-03-08 4:38 ` [bug#54235] [PATCH v2 2/3] gnu: Add ck Maxim Cournoyer
2022-03-08 9:39 ` Maxime Devos
2022-03-08 14:36 ` Maxim Cournoyer
2022-03-08 9:45 ` Maxime Devos
2022-03-08 14:38 ` Maxim Cournoyer [this message]
2022-03-08 9:49 ` Maxime Devos
2022-03-08 14:38 ` Maxim Cournoyer
2022-03-08 4:38 ` [bug#54235] [PATCH v2 3/3] gnu: Add sysbench Maxim Cournoyer
2022-03-08 9:42 ` Maxime Devos
2022-03-08 14:39 ` Maxim Cournoyer
2022-03-08 17:27 ` Maxime Devos
2022-03-18 5:38 ` bug#54235: [PATCH 0/3] " Maxim Cournoyer
2022-03-08 14:36 ` [bug#54235] [PATCH v3 1/4] gnu: docbook-xml-4.1.2: Install an XML catalog file Maxim Cournoyer
2022-03-08 14:36 ` [bug#54235] [PATCH v3 2/4] utils: Add ar-for-target and ld-for-target procedures Maxim Cournoyer
2022-03-08 14:36 ` [bug#54235] [PATCH v3 3/4] gnu: Add ck Maxim Cournoyer
2022-03-08 14:36 ` [bug#54235] [PATCH v3 4/4] gnu: Add sysbench Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lexktsqd.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=54235@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).