From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0H9jAT3JK2J6DgAAgWs5BA (envelope-from ) for ; Fri, 11 Mar 2022 23:12:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oAtvOjzJK2KNygAA9RJhRA (envelope-from ) for ; Fri, 11 Mar 2022 23:12:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB7351F9A9 for ; Fri, 11 Mar 2022 23:12:12 +0100 (CET) Received: from localhost ([::1]:41244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSnUZ-0007yl-EN for larch@yhetil.org; Fri, 11 Mar 2022 17:12:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnUQ-0007yU-BR for guix-patches@gnu.org; Fri, 11 Mar 2022 17:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSnUQ-0002rh-2m for guix-patches@gnu.org; Fri, 11 Mar 2022 17:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSnUP-00051b-UI for guix-patches@gnu.org; Fri, 11 Mar 2022 17:12:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54273] [PATCH] gnu: nicotine+: update to 3.2.1. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54273 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fatima Toothpaste Cc: 54273@debbugs.gnu.org Received: via spool by 54273-submit@debbugs.gnu.org id=B54273.164703671619298 (code B ref 54273); Fri, 11 Mar 2022 22:12:01 +0000 Received: (at 54273) by debbugs.gnu.org; 11 Mar 2022 22:11:56 +0000 Received: from localhost ([127.0.0.1]:38586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnUJ-00051C-SE for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:11:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSnUH-00050x-My for 54273@debbugs.gnu.org; Fri, 11 Mar 2022 17:11:54 -0500 Received: from [2001:470:142:3::e] (port=34038 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnUC-0002m4-I2; Fri, 11 Mar 2022 17:11:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tDd81XxTocTrPQh617xk87QQtPhFWjh7aSdH+Vr5ppg=; b=KYduy3TDpMhIFrHf1i52 qLi8dNsLnmL7fX9rGeM9PGPzLbC0vjILOoRcNUCv+02vKnrf2Cd5uoMfTodRJggB/ANIv/RFSsi5u XL940+aw4kCxB/mqO5LEQK0aK2A+yVfvJF9sHMLB1LDb+KY+uU4f4xd2ZN2Z2WRINH5lvZjColYDC eEBAgSePMTus5G37Xf5LLvhdTGCl3jvljW+OBcXyayA7Qs8sEv8J4m+DU0ihOZIjD58uQM8zF8KGe KGK/CXBlEA6stH7qU8kJgzrq2AWQqDbqE1J+I8gsKHexW9fqalF3ZC82uCrR1rPWOP5A3sONe3gZ6 Ek38cEf82/NrRQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:64247 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSnUC-0002S2-1L; Fri, 11 Mar 2022 17:11:48 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220306054551.19383-1-fatimatoothpaste@disroot.org> Date: Fri, 11 Mar 2022 23:11:46 +0100 In-Reply-To: <20220306054551.19383-1-fatimatoothpaste@disroot.org> (Fatima Toothpaste's message of "Sun, 6 Mar 2022 14:45:51 +0900") Message-ID: <87lexgw34t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647036732; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tDd81XxTocTrPQh617xk87QQtPhFWjh7aSdH+Vr5ppg=; b=UKn7W7tDDu2A/ObIlefxXo0Qfkqq0ZwEGeNtqLcUc2P4JArUPgsNvMJYgBLzVSPrjgPgDN lz68JnFCMJ7AozWbsY6uOECGaTH+WTIetmiYZn5Q4U4A1eI4O5Jzda9hBhwPQh15ASomZR merbgW0WrBlzuHWfo5mPbWGbt5Oz9nwpUBkpfbHRRKnK+GDn6eZeIkSMX3lVDuEZJVuuG+ e2UgxjD0vQ4dnY3N/9nP6I0RvSbZmHNtImo+UU7pzqhGEr34V2rcCqdFvBsGIRw1dztXkm a7IheM/GGCZ5XSKbRbgCii8hIZbO1p/Rmk9/9RilVn2Jgi8mT2CDnuc7czO+5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647036732; a=rsa-sha256; cv=none; b=nS2G3Zw6oTt9PO4YwmBaXrQx/R3fX5KJMy7AsO7p9Hcn+V1bDK0aerhAAvSw1Ce66nhJKg oLa1X1gr8PNAUeinlo6YRbK+gBf6Lmjg4Gv+9EC4RdSGBNlcC7q3ITLo4G7igfLgW6M8UN WYx+vObuqsBpqKOMK40K2Gic9T5A5Uxy4LkbVuZL+QmWf36xCf/vNWq6CukUJO+lASshdZ CcuWfrF2tRDVjAbwa2ULd7M2I5wM73cYCIbfIhgoplqtfqQFzzdBBO50El89W9gAjIfygY fjFkIGXLPMCWyQ28g+dvDwl04bPXo1iuKWKFrt4mF0+WM/FBefQrNTGtM8GQKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KYduy3TD; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.59 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KYduy3TD; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AB7351F9A9 X-Spam-Score: -4.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: nCPlCVIR2ZKV Hi, Fatima Toothpaste skribis: > * gnu/packages/nicotine.scm (nicotine+): Update to 3.2.1. > [arguments]: Delete check phase. > [inputs]: Add bash-minimal. > [home-page]: Update URL. [...] > + ;;Tests require network connection > + (delete 'check)))) Tests should rather be disabled with #:tests? #f. However, could you check if we can just skip (or tweak?) the tests that specifically depend on networking? The rest of the patch looks good to me. Thanks, Ludo=E2=80=99.