From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iO9uLbqsRmLQGwEAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 09:41:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wEbtKbqsRmLVQQEAauVa8A (envelope-from ) for ; Fri, 01 Apr 2022 09:41:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D80714C4A for ; Fri, 1 Apr 2022 09:41:45 +0200 (CEST) Received: from localhost ([::1]:39722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naBui-00011B-1m for larch@yhetil.org; Fri, 01 Apr 2022 03:41:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naBu2-0000d1-M9 for guix-patches@gnu.org; Fri, 01 Apr 2022 03:41:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naBu2-0001Hh-Cm for guix-patches@gnu.org; Fri, 01 Apr 2022 03:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1naBu2-0007v4-Ag for guix-patches@gnu.org; Fri, 01 Apr 2022 03:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54635] [PATCH v2 5/5] gnu: Add wfmash. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Apr 2022 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54635 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner , Maxime Devos Cc: 54635-done@debbugs.gnu.org Received: via spool by 54635-done@debbugs.gnu.org id=D54635.164879881830358 (code D ref 54635); Fri, 01 Apr 2022 07:41:02 +0000 Received: (at 54635-done) by debbugs.gnu.org; 1 Apr 2022 07:40:18 +0000 Received: from localhost ([127.0.0.1]:40755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naBtK-0007ta-3e for submit@debbugs.gnu.org; Fri, 01 Apr 2022 03:40:18 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:51832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naBtH-0007tN-CZ for 54635-done@debbugs.gnu.org; Fri, 01 Apr 2022 03:40:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BOgFBh71lh2DHCw2kJ1HnQE6L6MLQ0DEaJznfMaIujM=; b=PYiRKUaNbMJCUnAEi19b+MZt+u uVL0DBdjqdQ4bqMIf/Fr4oWByz1bve6CNuzqZZYcgmDgbyF13sGWmabmV7rSkQUBRpv9ltTF361f+ VMD4lcQjZLec5kbonFttAQ93OVBpeoF9oE8kZJcrpDjG5k+CXPQ+pBj7vAie11igeOFVLUizMMnbs hVl4lR8RxBCWxfRSv2p1yg+h+kCcuZoXlHm5C/byG8MF7smNCVrFT5pi+hSKGsv6TRMy/pzsF0giK /zH2HNKTReBrf80u4RSe/o1I3zlUCi91Xv60tVrQ5vYOXywixAVKkIBF0bgMXUV6dAcnQdPnJ7+Hk Eyygwq6A==; Received: from [192.168.2.1] (port=41916 helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1naBtD-000WxQ-ME; Fri, 01 Apr 2022 13:10:11 +0530 From: Arun Isaac In-Reply-To: References: <20220331072849.22417-5-arunisaac@systemreboot.net> <41db70e1e90803d02444ea5c0ffae0e0d6309700.camel@telenet.be> Date: Fri, 01 Apr 2022 13:10:11 +0530 Message-ID: <87lewp8d5w.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648798906; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BOgFBh71lh2DHCw2kJ1HnQE6L6MLQ0DEaJznfMaIujM=; b=WLfA57SarzFPlZZDcBJhXRYEFgD7YBfF0ZcZ2sfYRYaZJHU22GhgGE6DDpE6uLm05sh/Rb N/O4wwZ+WAzLidT37fLDPs8FLPULru+A/Qhq83hvTRF0kRoiJqLyJSQ74XFsEySWwEGGGo vanczMd+9tDcW+MJLqy+VvcZbwovBXDUofJiQAEbFH6GZlmnMzHCS3ZS3ykfiCvUakoZ3T Ftjuia/qUg6wuJYzw0Sim9IDvXFKdI35eVgWatxdm+R5wgk9hkIdmAGxT+dbpuM/UOqeWD ftf++1A0oi3P2of8kNLIty5ASOmG61vXaCLP87JrMJg10t18eCpQKS3fHqyFfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648798906; a=rsa-sha256; cv=none; b=SGIyuVTWfhIC87Ls+2dS7WdnTEVa0bjKyZQyhOevH5f7hYqIRn/E7MRDtdKvGEZ2DXQR4x TudxZd9AKRsknuV2iws/3+WAEU0GgcQOQlAYIMyggKy0p6r4c4cJP/Rwr6iAgNS91jbLkO kHLOfRxPKZ/GXu654x/dCLuM89q6j+x1BN4nFygrlUEPx/BSkkTOabL2vR62Xszg7+1spA TbOdn2GzMH0i2PKs4g+DTHViVE6URbh1VDJsmVvnNUybGR6aKyw0iWIR8gLlkfItuLJBcq 5y/6GlwIe1HOu4hVdUiaGbJmvYrHGBL63Oq0szFOWS6RfMCSw/WDi3QywyN+ZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=PYiRKUaN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=PYiRKUaN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3D80714C4A X-Spam-Score: 5.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: IkGpNqLk1WdE Thanks for reviewing and merging this patchset! >> wfmash could be written to detect CPU features at runtime and there is >> also --tune. wfmash's speed is one of the critical features it brings to the table. We might have rendered the package more or less unusable by disabling CPU optimizations. I could try talking to upstream about detecting and using CPU features at runtime. But, I don't know too much about the topic. Any quick links I can share with them? > I've pushed these patches with a few tweaks and an additional patch to > run a test suite based on the github workflow in the repository. The > entire check phase takes ~2 minutes on my pinebook pro, so aarch64 > doesn't seem to need to skip some tests like riscv64 does. I think it is better if upstream provides us a `make check' target to run these tests. I have asked them: https://github.com/ekg/wfmash/issues/130 Hard-coding their CI tests makes the package fragile. In the future, upstream could change the tests they run.