From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gK8lD8SAVWIrhQEAgWs5BA (envelope-from ) for ; Tue, 12 Apr 2022 15:38:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YDqaB8SAVWJa+gAAG6o9tA (envelope-from ) for ; Tue, 12 Apr 2022 15:38:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A039C241D6 for ; Tue, 12 Apr 2022 15:38:11 +0200 (CEST) Received: from localhost ([::1]:35978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neGig-0006Jz-EV for larch@yhetil.org; Tue, 12 Apr 2022 09:38:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neGiZ-0006JT-OE for guix-patches@gnu.org; Tue, 12 Apr 2022 09:38:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1neGiY-0001n7-Jf for guix-patches@gnu.org; Tue, 12 Apr 2022 09:38:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1neGiY-0001OF-Fn for guix-patches@gnu.org; Tue, 12 Apr 2022 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54876] [PATCH] gnu: sbcl-py4cl: Fix path to python3. Resent-From: "Paul A. Patience" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Apr 2022 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54876 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54876@debbugs.gnu.org Received: via spool by 54876-submit@debbugs.gnu.org id=B54876.16497706325279 (code B ref 54876); Tue, 12 Apr 2022 13:38:02 +0000 Received: (at 54876) by debbugs.gnu.org; 12 Apr 2022 13:37:12 +0000 Received: from localhost ([127.0.0.1]:48058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neGhk-0001N4-H7 for submit@debbugs.gnu.org; Tue, 12 Apr 2022 09:37:12 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]:27434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1neGhh-0001Mi-HG for 54876@debbugs.gnu.org; Tue, 12 Apr 2022 09:37:11 -0400 Date: Tue, 12 Apr 2022 13:36:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apatience.com; s=protonmail2; t=1649770622; bh=DXZ+sdniJpkOOfmANQR8W1K3Xu8E1F6C+euQ6eIwVLA=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=AetTM3ei5Bu2ZUdj40/JhzDFpHMWrBXJtnhnv8TMev8FYakd7wXi5Qo7hKc7vxRBD DILV7LhK30mDOtm6wPrNNEglWMxVxiCmcJa0qHuUx8AHCWjYvikhHNy1dPIyxfrUb5 G9N8bm43+XwWSBUVn/o/a60lU1MwGDDAARO/P/YknOLw8ek+tOPMX0GI+IH5UwTXu0 ODctWDGZ7JJh74EuTfAJ8gk+lj3P9JaiWvkEq109MWHLvNj15Tsq0Dn55vjcS9VXax dz05JSyggQhxZp0/V/L5WaHe+iug5b4x6V/Nm58G/dxafYxcO81vQcN3uTmdhPa3cF wKh7L3CgANVsg== From: "Paul A. Patience" Message-ID: <87lewah1gp.fsf@apatience.com> In-Reply-To: <1a38e6e61473683ff134dd477042b061ff605ac0.camel@telenet.be> References: <20220412025518.5253-1-paul@apatience.com> <1a38e6e61473683ff134dd477042b061ff605ac0.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Paul A. Patience" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649770691; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DXZ+sdniJpkOOfmANQR8W1K3Xu8E1F6C+euQ6eIwVLA=; b=DSGgHZsGhF7fNvwO+R9bAPDhUwix0Efq1HPLl8ajy69uUj79216RmD7JV8dJfGowvrskAH h65Rz0iPLiUPhdKJQHXrjt0+TPoGYJTFOKEPazG2y99K/OhGJuh49W9OVpBsYrO+EF2FQa HEy8Uh0/hO2lDlzqCHEdkUPgKNT9FhW5xkQDb5d2y5iZg7dRpHjEigjZMj/UNrpt6fauwS 6pRG9vDYD+8pO6GtgiU9GQpQxnUx7hzmeef6ESwysirzw/maysbvuQItzrKSZP8iX1MEr2 FdJhea3d115mKwl+NDnK3Oj/WmZow68sUEdbRKiaf/LoRZo9HplEH6XEQTWcfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649770691; a=rsa-sha256; cv=none; b=Vln5HldntGRUDo+0eSQeC8FTcCu1/b7CftPXLPDMDo5mTHSH9K5nB0hR1kbx4Dry/9hXnI MKriUsjf2rmD0E/redFI9uubd0zRXtmX5T0vWLutSSStCLur916iYGrUL383Vg4+gTr5Vr 8pMynWaEBalD15hjeOpeg8ZhtDJ1VQg3qoMjbUigr1Am33B3Z+OswoGVvj51CJn0sQlFER D/DiuDUJyUNmJosmNRWkF4J1gxQ6Y1pmbOHLvL6sY7TuTcIJ2GhLmX6OJDeypu2vwCuasX x82nI1Zvd6P7cgf6ZzG6iHhmtsKH4lVKfD2xUvXlZ9vPx2UdkQHaBO/Z9gdd9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=apatience.com header.s=protonmail2 header.b=AetTM3ei; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=apatience.com header.s=protonmail2 header.b=AetTM3ei; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A039C241D6 X-Spam-Score: 0.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: wWHsz0Cug+SL Hello, On 2022-04-12 08:46:23-04:00, Maxime Devos wrote: > This is most likely incorrect when cross-compiling. Do > > (lambda* (#:key inputs #:allow-other-keys) > [...] > (string-append [...] (search-input-file inputs "bin/python3") [...])= [...]) > > instead, such that it looks in 'inputs' instead of 'native-inputs'. > > > Also, now that 'python3' is patched in, is the following still relevant: > > (propagated-inputs > ;; This package doesn't do anything without python available > (list python > > (I mean, does it still need to be propagated?) So you're suggesting we call search-input-file and move the python dependency to inputs rather than propagated-inputs? Right, since the correct path to python3 is now hardcoded, it doesn't need to be propagated. One other thing we could do is move python-numpy to native-inputs. It's required only for the tests and multidimensional array support, but py4cl.py looks up python-numpy at runtime for the latter, and gracefully handles the situation when it is not found. A user could opt-in to the multidimensional array support by explicitly installing python-numpy. However, I'm not familiar with how Guix deals with Python module paths. Would the python3 in sbcl-py4cl's inputs be able to find python-numpy if only sbcl-py4cl and python-numpy are explicitly installed by the user? Best regards, Paul