From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UIC5JV0VjWJvjgAAbAwnHQ (envelope-from ) for ; Tue, 24 May 2022 19:26:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oHSdJV0VjWKTfAAA9RJhRA (envelope-from ) for ; Tue, 24 May 2022 19:26:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3446D14ACC for ; Tue, 24 May 2022 19:26:53 +0200 (CEST) Received: from localhost ([::1]:40190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntYJ2-0006j3-6A for larch@yhetil.org; Tue, 24 May 2022 13:26:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntYHH-0005Ut-4l for guix-patches@gnu.org; Tue, 24 May 2022 13:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntYHG-0006TG-RX for guix-patches@gnu.org; Tue, 24 May 2022 13:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ntYHG-0002Cm-JZ for guix-patches@gnu.org; Tue, 24 May 2022 13:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55606] [PATCH 2/2] gnu: Add hare. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 May 2022 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55606 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Antero Mejr Cc: 55606@debbugs.gnu.org X-Debbugs-Original-Cc: 55606@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16534130618424 (code B ref -1); Tue, 24 May 2022 17:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 May 2022 17:24:21 +0000 Received: from localhost ([127.0.0.1]:53249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntYGb-0002Bo-CL for submit@debbugs.gnu.org; Tue, 24 May 2022 13:24:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:37540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntYGZ-0002Bd-Av for submit@debbugs.gnu.org; Tue, 24 May 2022 13:24:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntYGZ-0004bG-05 for guix-patches@gnu.org; Tue, 24 May 2022 13:24:19 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:52082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntYGX-0006Q6-Ao for guix-patches@gnu.org; Tue, 24 May 2022 13:24:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=ooNUfILOZKrjc +ccmgv1f1aWaTqjBzBs0hqsGSyuv4g=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=UXn4dCxQ+sio5I2CjmyUL6dQDL2iZ3qc+pn0+l B24SK5xYXHl1iYLv9NO49YieO9Srd/U0YfDIwULWL7V9iAsXH/Cr8PqUAJSD6VMNq9PT32 68U5OgwcLjRfH5Am7hjC9m2fDu6EB0eD5drehlMsR1WiNHbHD71AI/xajDFlWZ3ozczHUI R6T7CAOCPu2+472UviSAWdsauIPG3T/D/U6/kz6njXadGb6NUO4MsH/tFgAaqMzSd4/Rwu EH7ohmLIS3CFBQhqLNWXYV53MISVlNM6tRuJWTmnxVe9wRMaXsOyuEvw5+dgSHd8MUuTPp MB2EPsZnakPKt4acAIXArPCA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 05a1cf93 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 24 May 2022 17:24:14 +0000 (UTC) References: <20220524012155.48729-1-antero@mailbox.org> <20220524012155.48729-2-antero@mailbox.org> Date: Tue, 24 May 2022 19:10:24 +0200 In-reply-to: <20220524012155.48729-2-antero@mailbox.org> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87leuqaloi@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653413213; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ooNUfILOZKrjc+ccmgv1f1aWaTqjBzBs0hqsGSyuv4g=; b=gt4sOXdrL/3M5P9o6sjE0Y1AYaLY4NpIgeHsUpfqUYY7qi0R5YlkWUZipFlqfQsY28OB8+ FwPBTLLvVoto59CpXBosnj38wuqW+z8uHe2wKMoD0olP5oCt8nITdZVNdle4wWRE89ArUd MbV8PEuON2ZNvfcD4p1hbxjbl7YKw98p3jcLi6/yXyx0hXUsO0SLiFAcpFp+oKdVozgA1b r1szedrrKtC7CYznVGCDkxs/IR7JdKYHLki2DwSnu8Ls3RXJh5ES1ZgVGl/xDrGGOS/kbG UCtXeJszn1lzthTYlyUVTS7jib0cFDVm06jrXIC9B0BNreKIC7GMnKuyD3M29A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653413213; a=rsa-sha256; cv=none; b=h73JNOYPqEceWm88yjDMlgA9/a25WP8bgQoiEz9ib4NkUgpJOXC7dMpzPrGi+vv4R1jZno TS/WZYsXLzCAv8kBKpHEqo8KouxL7qNw4LfCQqc+I1I6mbOjgwUJU2H7OfrS9alt6NStu7 57ngfAFbB4Jvz9FYHPt8tV/ATz3VCXvdKJVYNsRKWPIs729wAznMs0FvRZRCVMrXdvCEvU lohCk0bH2h1M/u4pBrcw8LwKA2vmvsin8cP5IVhy97hWuID6Z/OxyjVCPXdYsDYjb+4ady yy9RuHAh0X4LKrpD7iqhHh9TXWtbTqhtdzXcRE5cC41ugFO9tHr7Kj3+Lc9yUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=UXn4dCxQ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=UXn4dCxQ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3446D14ACC X-Spam-Score: -5.34 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3CF9TKTjqbrB --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Antero Mejr via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > Guix style was indenting badly when applied to the hare package,=20 > putting the > text far past 80 characters. Corrected it by hand. This caught my attention; I didn't review anything. Guix style just follows the same rules we should follow. Don't=20 =E2=80=98fix=E2=80=99 the result unless there's a real bug in =E2=80=98guix= style=E2=80=99. Instead, work with it, in this case by adding newlines. This: (proc "foo" "bar") reads *wrong* to humans. Worse, it's forever a pain to maintain, because nobody can ever=20 auto-indent any changes they make to your hand-tweaked code. They=20 have to work around it. Instead, when necessary, write: (proc "foo" "bar") > + (list (string-append "DESTDIR=3D" (assoc-ref %outputs=20 > "out")) In this case you'd a newline after the above =E2=80=98string-append=E2=80= =99. > + (string-append "HAREC=3D" > + (string-append (assoc-ref=20 > %build-inputs "harec") > + "/bin/harec")) This is easy to fix: theres no need for the inner string-appends=20 in this section. (string-append "HAREC=3D" (assoc-ref %build-inputs "harec") "/bin/harec") is 100% equivalent. If the line is still too long, add newlines=20 where it keeps the code the clearest. With such changes, you can run =E2=80=98guix style=E2=80=99 (or let your ed= itor=20 indent the code) without worries or manual fix-ups. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYo0UvQ0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15gWcBAO0d9f1GuB1lvmoiFVLoEH9Oe5c1G3ttKJjQtZLn mWeOAQCKHNkcYAwPV5FqDd5lkQpWZjy3JC3400tTyc5Dc/NeBg== =6ISR -----END PGP SIGNATURE----- --=-=-=--