unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: Felix Lechner <felix.lechner@gmail.com>, 55763@debbugs.gnu.org
Subject: [bug#55763] [PATCH] Upgrade nyacc to 1.07.0
Date: Sat, 04 Jun 2022 18:17:37 +0200	[thread overview]
Message-ID: <87leucwggu.fsf@jpoiret.xyz> (raw)
In-Reply-To: <CAFHYt5559tBrB_yM0z3q-FhE6anAXiu7w9LHqbbT0Jnm5j=sUA@mail.gmail.com>

Hello Felix,

Felix Lechner <felix.lechner@gmail.com> writes:

> Control: tags -1 + patch
>
> Hi,
>
> For my work in making PAM configurable in Guile, I rely on the foreign
> function interface (FFI). The automatic generation of that interface
> requires the compile-ffi script in nyacc. Unfortunately, the highest
> version we ship suffers from a bug that prevents the script from
> running on the pam_client.h header in linux-pam.  This patch upgrades
> nyacc to the version Matt Wette released after committing the fix.
>
> The changes are further documented in the commit message.
>
> I am new to Guix and already use the new version of linux-pam locally
> (via Guix System) but I was unable to test the patch according to the
> requirements and recommendations listed for this submission. [1]
>
> This email was sent to -devel in lieu of -mentors, which does not
> exist. Any guidance is much appreciated. Thanks for taking a look!
>
> KInd regards
> Felix Lechner
>
> [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html

While the contents of the patch look good, you're missing the standard
ChangeLog format for the commit message, see "(standards)Change Logs".

I would recommend something along

--8<---------------cut here---------------start------------->8---
[Your message]

* gnu/packages/mes.scm (nyacc): Update to 1.07.0.
--8<---------------cut here---------------end--------------->8---

Also, I think that inline patches are preferred, even though the manual
says that MIME is fine too.  The usual advice is to just use
git-send-email to send patch series, which will take care of everything
itself (you can check out a tutorial at [1]).  You could send a v2
patch, or maybe a maintainer will add the necessary format themselves
and commit, whichever comes first :).

In any case, thanks for your contribution!

[1] https://git-send-email.io/

Best,
-- 
Josselin Poiret




  reply	other threads:[~2022-06-04 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 12:14 [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 Felix Lechner
2022-06-04 16:17 ` Josselin Poiret via Guix-patches via [this message]
2022-06-07 16:22 ` bug#55763: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leucwggu.fsf@jpoiret.xyz \
    --to=guix-patches@gnu.org \
    --cc=55763@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=felix.lechner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).