From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WCOLNU9sx2IpJAEAbAwnHQ (envelope-from ) for ; Fri, 08 Jul 2022 01:29:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eLpqNU9sx2IbBgEAauVa8A (envelope-from ) for ; Fri, 08 Jul 2022 01:29:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 63C28BB51 for ; Fri, 8 Jul 2022 01:29:19 +0200 (CEST) Received: from localhost ([::1]:52574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9avt-0007G8-Tz for larch@yhetil.org; Thu, 07 Jul 2022 19:29:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9avf-0007FJ-1Y for guix-patches@gnu.org; Thu, 07 Jul 2022 19:29:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9ave-0008D5-OX for guix-patches@gnu.org; Thu, 07 Jul 2022 19:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9ave-0004ss-KX for guix-patches@gnu.org; Thu, 07 Jul 2022 19:29:02 -0400 Subject: bug#56361: gnu: srt: Update to 1.4.4 (fix test failure on AArch64) Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 07 Jul 2022 23:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Simon South Cc: 56361-done@debbugs.gnu.org Mail-Followup-To: 56361@debbugs.gnu.org, mail@cbaines.net, simon@simonsouth.net Received: via spool by 56361-done@debbugs.gnu.org id=D56361.165723653518757 (code D ref 56361); Thu, 07 Jul 2022 23:29:02 +0000 Received: (at 56361-done) by debbugs.gnu.org; 7 Jul 2022 23:28:55 +0000 Received: from localhost ([127.0.0.1]:58281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9avX-0004sT-1F for submit@debbugs.gnu.org; Thu, 07 Jul 2022 19:28:55 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9avR-0004sH-2j for 56361-done@debbugs.gnu.org; Thu, 07 Jul 2022 19:28:53 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 692C627BBE9; Fri, 8 Jul 2022 00:28:48 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 724cc5ce; Thu, 7 Jul 2022 23:28:48 +0000 (UTC) References: User-agent: mu4e 1.6.10; emacs 28.1 From: Christopher Baines Date: Fri, 08 Jul 2022 00:20:14 +0100 In-reply-to: Message-ID: <87let4jydu.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657236559; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=pmozxMfWj2vAtJm5Pf7CXCO7DyKazhOgANWMHtmx5xY=; b=GV2xL/Jkg0zpKR1QoSgzdvF6jvWdpRpwB5fegkX4jbqzdYpxPXQjbPM7bNIt4PAedwcRc5 cxQqHSgIVU55/SbzotEL1DPORXVmBr01VFCxGGAencRWTp0HvexM3oZCckeH+nwcZI7iOg YcBCI7EoWncC+tgT2tOQ8ekNuvNnyj9bhTew/zqWhvs35HoX2WYHcaCwMBKLGmsMxnEMc/ Kk1UbjJTQu516f+fZayezmDCQweH4JxAcLkWomPmPE9qjsAS0QFTFJb6vggCuTGLxKO8C4 pTJxWqPgFkZ/iui40D5kc/Y4/K0/7SECf9ulk99Z+RyCKLfrz5LppVsKVzD7Xw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657236559; a=rsa-sha256; cv=none; b=kHiuTMtfqq7Xc+058ZcjsU5YBBdUzpvuuQCLjvqojUfnaf91KvIRTPA/O7beoUab4dxO2J dqAFAi4/sltR53rAvMOOvIPWzoL5hmSOneJCV5nojfo1cspGm3iCL8aDymvHoWZJOL4kAp D3Oz1S1nGZfkOAS0qokgbt1Sn1/cA0Z5+QbJ0TJgXqE/+L6uTMG2kyNwz+ObC8I3lrcseb 7lPGMcCy5UcQhZwGYHuJc4vuxwK9uSxlToJ1koPB94kZ6I+oEG/8Fi7G6T7jZcqdYZ0DE8 +KY4MpyKAMLOnZx6SCvmQuqUxBbT2QNC299dY08DFhNjGbLiotnZz1DRUhWzGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 63C28BB51 X-Spam-Score: -5.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: clsCWB4vVLLw --=-=-= Content-Type: text/plain Simon South writes: > Here's a patch series that > > - Updates SRT, the "Secure Reliable Transport" for audio/video streams, to > 1.4.4, fixing a test failure on AArch64 and likely other non-Intel/AMD > platforms[0]; > > - Updates the srt package itself to remove input labels; > > - Updates the vlc package to use the now-current version of SRT instead of an > older version[1]; > > - Removes that older (and now unnecessary) version of srt from the package > repository; and > > - Updates the vlc package to remove input labels and to add "bash-minimal" to > its inputs, silencing a warning from "guix lint". > > I'm aware SRT 1.5.0 is also available, but > > - Version 1.4.4 is the latest version supported by VLC; > > - Version 1.5.0 introduces API/ABI changes that are likely to cause problems > elsewhere; and > > - I just need to get my systems updating again. (I can look at submitting > another patchset later.) > > I've tested these patches on x86-64 and AArch64 and in general, everything > looks fine. > > With regards to SRT's immediate dependents, ffmpeg@4.4.2, ffmpeg@5.0.1, > gst-plugins-bad and and vlc: > > - All four dependents build without issue on x86-64. > > - On AArch64, VLC and the two FFmpeg packages build just fine. Building > gst-plugins-bad means building the entire Rust toolchain and potentially > other packages that are infeasible to build on garden-variety AArch64 > hardware, so I haven't been able to test this. > > - Nonetheless I've verified that on both architectures, VLC built with these > patches connects to and plays a SRT video stream just fine.[2] > > On x86-64 I've tested building all of SRT's 299 dependent packages and this > completes without any _new_ build failures: ams-lv2, dvdstyler, lv2-mda-piano > and lv2-mda-epiano are all currently broken on x86-64, and it appears my > system is unable to build curl 7.84.0 for i686-linux either with or without > these patches applied. > > [0] The failure involves an unnecessarily-short timeout period in the > "SyncEvent.WaitForTwoNotifyOne" unit test, which was adjusted in upstream > commit e2a00aa: > > https://github.com/Haivision/srt/commit/e2a00aa03a36e153ab8cfe2c0790f7bf43747d8d > > It's unlikely this affects only AArch64. A Debian developer notes in this > GitHub issue that SRT test failures are common on other, older and mostly > non-Intel/AMD architectures as well: > > https://github.com/Haivision/srt/issues/2267 > > [1] VLC was updated to build with SRT version 1.4.4 by default in upstream > commit 9a28929 this past February, making the comment above the srt-1.4.1 > package (in gnu/packages/networking.scm) obsolete. Since neither of the > other packages mentioned still use this older version of SRT, nor does any > other, the package is no longer needed. > > https://code.videolan.org/videolan/vlc/-/commit/9a289291d01a393294c62ee7406487f59e25f4ed > > [2] I'd also like to verify that VLC can _output_ a video stream using SRT but > despite an "SRT" output-access module appearing in the configuration > settings I can't see how this is meant to work, using either the original > or the patched build of VLC. If anyone relies on this functionality and > can give me straightforward instructions for testing it I'll be happy to > do so before this patch series is committed. > > --- > > Simon South (6): > gnu: srt: Remove input labels. > gnu: srt: Update to 1.4.4. > gnu: vlc: Use regular srt. > gnu: Remove srt-1.4.1. > gnu: vlc: Remove input labels. > gnu: vlc: Add bash-minimal as an input. > > gnu/packages/networking.scm | 26 +----- > gnu/packages/video.scm | 155 ++++++++++++++++++------------------ > 2 files changed, 79 insertions(+), 102 deletions(-) > > > base-commit: 48ff4bfcd7491c12248b34a82e0b8e8a50a86308 Thanks for the really comprehensive testing and notes Simon, the patches look good too. I've gone ahead and pushed these in the following commits: 7dfb8dc4c1 * gnu: vlc: Add bash-minimal as an input. f53e14be33 * gnu: vlc: Remove input labels. 07986d0fad * gnu: Remove srt-1.4.1. 6b9d373083 * gnu: vlc: Use regular srt. 5feeb51f1b * gnu: srt: Update to 1.4.4. 70f3914c24 * gnu: srt: Remove input labels. Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmLHbC1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfTVw/+OZc2c+3KcRWzjiItu2lidj2yeMLGHAtN N7DCVu4Z24qKkaYFapCTjwfygyMstRqkqsKEnDpvS77cHVyahK93QsQ+9MzVJDSX 7MaPCq/y9efuSDJ9zK+D10VDGbpnYkUqLKkky+PEI6xRpQcTmqS7Aey/OCJE/0h5 hgginIfpeVrHB79QVZn3FajZ6Kkq6VJAQX8q7PHmBMXgVz3RXpJKRn8eejd2cD/l aW+U/pPqj8eH+aqnd5itg3lzhHzC9r5u0+AcosGs6l1h+Bz4xBz8yyQbPym3MxRA gvchCs6CyGnl5A+FwPNcuwpsvmxa33FPKmX1iXVn5ZBYR6tnlNP7gzed4TRWod1p GBjAPFibAm3F0soLzljLD7NYDQU59u7Jdl577QYaeJWRapo9HXFER/sCMaW6CvUD 8WFmYL8wwcyCnKTuR+584kgMg5iaT2kgeWrbE1i9+MTvo5bCVT2D2txSZwepWHSr en2IBvf/ZEAyaZGLqKRU+OJE5bBHOm8qL+SKMnbbcjxvgoZGoTwf9JOM35sfitnm snbj7pgt7J/2RWIlj/JJgisOdtCxDGBi7Q5ya/XggE7VaSFxOvvNpEYZppclqshg ax/nAXhhncF01FK/y5Eyr5JmizcqR0F4ctvIZjsw/rlSb8eelMLxkh4Nd96ecs8/ ENnnk6cw1n0= =v12r -----END PGP SIGNATURE----- --=-=-=--