From: Oleg Pykhalov <go.wigust@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 56880-done@debbugs.gnu.org
Subject: bug#56880: [PATCH] gnu: system: file-systems: Add shared flag.
Date: Wed, 10 Aug 2022 07:19:38 +0300 [thread overview]
Message-ID: <87lerwd92d.fsf@gmail.com> (raw)
In-Reply-To: <87fsibhvsd.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 05 Aug 2022 11:41:38 +0200")
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
[…]
>> I looked again on this procedure before merge. With applied patch it
>> will return a wrong bitmask according to the manual page:
>>
>> mount(2)
>>
>> The only other flags that can be specified while changing the propaga‐
>> tion type are MS_REC (described below) and MS_SILENT (which is ig‐
>> nored).
>>
>> Also I tried to invoke 'mount' from C code, if MS_SHARED specified and
>> mountpoint does not exist (not mounted without MS_SHARED before), then
>> nothing will happen.
>
> Hmm not sure I follow.
[…]
>> 2. Modify option-string->mount-flags in such way, that it will return
>> multiple bitmasks or in some other way.
[…]
> I’m not sure what option #2 means concretely?
We need to call mount(2) two times, which is not handled by
option-string->mount-flags which returns only one mount(2) bitmask.
I pushed #1 as 4b494878380920c8c7eecccd1f299164dd4a2c3f to master.
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
prev parent reply other threads:[~2022-08-10 4:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 11:23 [bug#56880] [PATCH] gnu: system: file-systems: Add shared flag Oleg Pykhalov
2022-08-03 15:21 ` Ludovic Courtès
2022-08-04 13:20 ` Oleg Pykhalov
2022-08-05 9:41 ` Ludovic Courtès
2022-08-10 4:19 ` Oleg Pykhalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lerwd92d.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=56880-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).