unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: Andy Tai <lichengtai@gmail.com>, 60979@debbugs.gnu.org
Subject: [bug#60979] [PATCH] gnu: wlroots: Update dependencies
Date: Fri, 03 Feb 2023 10:48:51 +0100	[thread overview]
Message-ID: <87lelfw03g.fsf@jpoiret.xyz> (raw)
In-Reply-To: <CAJsg1E_9tM4qWbuynwTdYh5g3V6myVxfUbcU9hyHFU=mZLZGWw@mail.gmail.com>

Hi Andry,

First of all, looking at QA [1], I noticed that none of the WMs
depending on it actually build.  Have you tested this patch on your
machine?

Andy Tai <lichengtai@gmail.com> writes:

> From 2d433dba9ee73707ec71a4209e023e91e10d094d Mon Sep 17 00:00:00 2001
> From: Andy Tai <atai@atai.org>
> Date: Fri, 20 Jan 2023 20:43:50 -0800
> Subject: [PATCH] gnu: wlroots: Update dependencies
>
> gnu/packages/wm.scm (wlroots): Add input xcb-util-renderutil and vulkan
> for XWayland support
> ---
>  gnu/packages/wm.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 201c5994d8..b93c57b888 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -143,6 +143,7 @@ (define-module (gnu packages wm)
>    #:use-module (gnu packages textutils)
>    #:use-module (gnu packages time)
>    #:use-module (gnu packages video)
> +  #:use-module (gnu packages vulkan)
>    #:use-module (gnu packages web)
>    #:use-module (gnu packages xdisorg)
>    #:use-module (gnu packages xml)
> @@ -1555,6 +1556,7 @@ (define-public wlroots
>                                                         "xorg-server-xwayland")
>                                              "/bin/Xwayland")))
>               #t)))))
> +    (inputs (list libpng  mesa-headers vulkan-headers vulkan-loader xcb-util-renderutil))

Here, xcb-util-renderutil should be propagated because it is required by
the wlroots.pc pkg-config file.  Also, looking at the wlroots README, I
don't see libpng mentioned anywhere, as well as mesa-headers, and
removing both of them still lets it build fine. Do you know if those are
actually needed? Reciprocally, glslang is mentioned for the Vulkan
renderer, but I don't see it here.

>      (propagated-inputs
>       (list ;; As required by wlroots.pc.
>             eudev

Best,
-- 
Josselin Poiret




  reply	other threads:[~2023-02-03  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-21  4:48 [bug#60979] [PATCH] gnu: wlroots: Update dependencies Andy Tai
2023-02-03  9:48 ` Josselin Poiret via Guix-patches via [this message]
2023-02-04  4:55   ` Andy Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lelfw03g.fsf@jpoiret.xyz \
    --to=guix-patches@gnu.org \
    --cc=60979@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=lichengtai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).