unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>, 62036@debbugs.gnu.org
Cc: Tobias Geerinckx-Rice <me@tobias.gr>,
	Simon Tournier <zimon.toutoune@gmail.com>,
	Mathieu Othacehe <othacehe@gnu.org>,
	ludo@gnu.org, Christopher Baines <mail@cbaines.net>,
	Ricardo Wurmus <rekado@elephly.net>
Subject: [bug#62036] [PATCH] guix: packages: Consider 'patches' by 'package-direct-sources'.
Date: Thu, 09 Mar 2023 20:43:26 +0100	[thread overview]
Message-ID: <87lek5d82p.fsf@jpoiret.xyz> (raw)
In-Reply-To: <20230307171833.4170067-1-zimon.toutoune@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> writes:

>  (define (package-direct-sources package)
>    "Return all source origins associated with PACKAGE; including origins in
> -PACKAGE's inputs."
> -  `(,@(or (and=> (package-source package) list) '())
> +PACKAGE's inputs and patches."
> +  (define (expand source)
> +    (append
> +     (list source)
> +     (filter origin? (origin-patches source))))

* cough * (cons source (filter ...)) * cough *

Other than that, LGTM!  Tests worked fine on my end.  No idea what this
is used for though :p

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

  reply	other threads:[~2023-03-09 19:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 17:18 [bug#62036] [PATCH] guix: packages: Consider 'patches' by 'package-direct-sources' Simon Tournier
2023-03-09 19:43 ` Josselin Poiret via Guix-patches via [this message]
2023-03-10 11:33   ` Simon Tournier
2023-03-10 12:12     ` Josselin Poiret via Guix-patches via
2023-03-11 16:51 ` [bug#62036] [PATCH v2] " Simon Tournier
2023-03-13 11:14   ` bug#62036: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lek5d82p.fsf@jpoiret.xyz \
    --to=guix-patches@gnu.org \
    --cc=62036@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=ludo@gnu.org \
    --cc=mail@cbaines.net \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=rekado@elephly.net \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).