From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MLy0ItaYvmRdJwAASxT56A (envelope-from ) for ; Mon, 24 Jul 2023 17:29:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mMSUItaYvmSs/wAAauVa8A (envelope-from ) for ; Mon, 24 Jul 2023 17:29:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 649D431ED7 for ; Mon, 24 Jul 2023 17:29:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b="TNMo/yEw"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690212566; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WOLFT0aF669B24ywD+EHBw8a25PTdU5WJztfwBKR3Sk=; b=PRmKOukscZn4z17LWjBv8JebmMasAS5l0urifKXm0ISoKvst9oLuV4JovTtMnWdGqkSwzn oFz7oevU4FFS/BUZvb1DKxFzCs7wdZqOzVKIdQUs/XTP1L+FRDe+SIaeAkaunh6sWrd/NJ bOzTSD44KWlpDwUi1qVF6SaarASfBgTIEHks7BgQU/AO7nZQPqasI1B0yKDsYTW32tNfFI T8Zg/6Nygw0M1+ptdsrPqMzhwAmHzG/nX38Ou69wJ0sOhaVOYGKntutdqvPqhAupsd9b4s CNNk6YE9c6xjsniXOF+Y+lB1SVDDsxDKVhCzb8faw4EAWuI8vNnnHtqgwEeEhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690212566; a=rsa-sha256; cv=none; b=KUxCOGI4t63gRVrLN1UTapyQOF5DN9+L3+hOmLfiP/LTYY+CPOlWdou2ElP/FURvcrhrb6 QJRT9clHxtB6miZE992pNgoNLoGGqGFEkby4Kcwqd/lp40WZRrY1co+2ZWKR/3+MzT3Mwx uTWVDWyjola36i0racpxmGU5/UoaAiWB2NYqKZSH0xrMrmMHXjjP+PYUV2y0Cfvzm+lQO4 bth/xDh3mNAIilUPrB2v6eX4Utiv+/50l17+Eb2AGkwE21IDL5QkarjuUOQ1B14PFb8LCE amNpKzP4M6Gc+Arqnmtshq6DuZF9OhYs+eBjlH9xoDlXDB7YnEIOflyACiz9LA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b="TNMo/yEw"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNxUf-0002cR-0J; Mon, 24 Jul 2023 11:29:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNxUc-0002cI-I6 for guix-patches@gnu.org; Mon, 24 Jul 2023 11:29:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNxUc-0002PN-Ab for guix-patches@gnu.org; Mon, 24 Jul 2023 11:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNxUc-0002wo-23 for guix-patches@gnu.org; Mon, 24 Jul 2023 11:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64688] [PATCH v2] gnu: Add calc. Resent-From: Distopico Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Jul 2023 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64688 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64688@debbugs.gnu.org Cc: Andreas Enge Received: via spool by 64688-submit@debbugs.gnu.org id=B64688.169021251811299 (code B ref 64688); Mon, 24 Jul 2023 15:29:02 +0000 Received: (at 64688) by debbugs.gnu.org; 24 Jul 2023 15:28:38 +0000 Received: from localhost ([127.0.0.1]:43804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNxUE-0002wB-Cl for submit@debbugs.gnu.org; Mon, 24 Jul 2023 11:28:38 -0400 Received: from mx0.riseup.net ([198.252.153.6]:40242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNxU9-0002vs-5E for 64688@debbugs.gnu.org; Mon, 24 Jul 2023 11:28:36 -0400 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4R8kZg1j2Hz9tDM; Mon, 24 Jul 2023 15:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1690212507; bh=uztyay9izTnYtr3QLhFtJazkqlkgS0fc0ue0z4zBpFg=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=TNMo/yEw4ImmhOdpCnVrbD+FH+OC81NZnEOS3f4wr/vzH8g6/y5jIYYmfC+uxnkkG o7NZ77V1t+OKnvkhY/k/8w/pDtTOk//I5CJiqw8EvUeIEU+PMSFFZf7xRNoZT79uvL i3VIw/3Akz4LbZ93Ts8WjdNgm8PxPC122V6XccWs= X-Riseup-User-ID: AABB14080E813DF88FE1BDF493CA32830CF17B556FCA3C95E31A21F6C2C14B8D Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4R8kZf3GwQzFpgy; Mon, 24 Jul 2023 15:28:26 +0000 (UTC) References: <87edl6bctv.fsf@riseup.net> <20230718112911.31050-1-distopico@riseup.net> From: Distopico Date: Mon, 24 Jul 2023 10:27:52 -0500 In-reply-to: Message-ID: <87lef5nxbb.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: 2.16 X-Spam-Score: 2.16 X-Migadu-Queue-Id: 649D431ED7 X-TUID: SlK9pg/iynYm --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-07-24, Andreas Enge wrote: > Hello, > > just a few quick comments, as I do not have the time to look at the > package in detail. > > Am Tue, Jul 18, 2023 at 06:28:14AM -0500 schrieb Distopico: >> + (outputs '("out")) Done, removed > > This is the default and can thus be dropped. > >> + '(#:make-flags (let ((out (assoc-ref %outputs "out"))) > > This should probably be done with a gexp nowadays, but I do not know how; > I suppose there are examples to look up. > Changed, thank you >> + (add-before 'build 'patch-makefile-prefix >> + (lambda _ >> + (substitute* "Makefile" >> + ;; Replace becase there is more or less >> + ;; 5 Makefile vars with /usr as default prefix >> + (("=3D\\s?/usr/") >> + "=3D /"))))))) > > This is strange. The Makefile sets a variable PREFIX, but later uses > things like > BINDIR=3D /usr/bin > except for MacOS, where it uses > BINDIR=3D ${PREFIX}/bin > This line even appears in the general case, but is commented out, which > makes no sense. > > Maybe this could be discussed with upstream? It is also like this in the > latest release 2.14.2.0. > Yeah, maybe, not big fan of github but I'll try to contact upstream in other way, =C2=BFit would be a blocker to add this patch to guix? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmS+mJgVHGRpc3RvcGlj b0ByaXNldXAubmV0AAoJEJgJOoByVGvzxSgH/jji9PN5vGzxyPmCs2H07nXZC/0W IHtO8oDTnIRLjQlCfHiWgSprmQp1eGAWtgyYtJeE8Z6UqGjK4NLK9pj0jgQ7VnuD PDngzzLE8fkjBHQsHtWTrqVMVxpjj0XLjUF9xzxDZzQXI9bOsGRW9RIkLRN8iSyk lMdAEVkRaIvTz67ps0AR6nU5nM/A6w7T5/YViXVjXCt0w2TUMslBpgFpnVdZMet7 R9vulRVmrsebOHVwCO51oNHDL87tKqUHa/8XKxKP47G0FKfM7oZ1aX6NsouDD7// qK8JT6uj0vIi/I/ITREgpp+rd3wTwZOBAmmCqHcZdot1niY09XhIxl3EeAg= =1C/d -----END PGP SIGNATURE----- --=-=-=--