From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WACbGwP17WQzbAEA9RJhRA:P1 (envelope-from ) for ; Tue, 29 Aug 2023 15:39:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WACbGwP17WQzbAEA9RJhRA (envelope-from ) for ; Tue, 29 Aug 2023 15:39:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A29C335074 for ; Tue, 29 Aug 2023 15:39:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693316355; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=VNIE6OoN4xGsR+x/JP2G6FJs99QAGkRiy2jw/+2jYUY=; b=m2mxlNuVTCu+4gOiPLVV2fw+gigJUoDC26HQybYRW/KJflgSnJ17wCgNVeFIBlf5AUkeli YNLAXGrmqthSc3RQWujSEvq2L7pVMsw2kG6wWrjwSdKb8WZoZGr3Aw5gwkys3M3nhhM8q9 ZueRN6E7OQ58NAuObWN/XKyxl1IX+9vVS+6CzXMZMW9cKlUsCRa7+5WVnZV6qH9x0seoCQ cHSRLChDiL17m2tFOjhMz1yeA3KXLFbkQ4y7lVyMcWXGOiHrY9VmR4U1daAvB2x7r2lEdp nphN47S4E3GceVzIYA/mJecZixxZsSJ2MKu+WvgttNLoFu7ASgQCD3KX1dvhYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693316355; a=rsa-sha256; cv=none; b=DSkrthL17n/7CmWYNdJzA/GXFm+eZSx1jHk20YA6Qb2xlEDUFq4OFRkYHTG54HJ3K0YBeD 3HPd4LyOP9dNAC+9xwisupksoWpbHJKGwilUPaLLEy5fc7FjHZ83Ra9bWa6f/NnL4XmfPC OUBWDSzIE4Snpp48rxvGDNcdSyFNtKBqbnPTpfBrMlS4AN1/3pMd/i0a44AkXHExVYWQjH x8DkdYNIW7hasCjNy7JJwhIcKoxQ2KioJUi1yI2qnheQ4BJ3gX+5s2rTHIjT295Qxb2TsW ORDHAmrsyh9JTSylLggYAjzyaRVMJcE9lippUeszS5NYsZNidMljn42OMxfYuA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qayvq-0001IU-1G; Tue, 29 Aug 2023 09:38:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qayvo-0001IJ-2W for guix-patches@gnu.org; Tue, 29 Aug 2023 09:38:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qayvn-0001rd-Mb for guix-patches@gnu.org; Tue, 29 Aug 2023 09:38:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qayvu-0004oq-7w for guix-patches@gnu.org; Tue, 29 Aug 2023 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#60571] [PATCH v2 3/4] gnu: Add icu4c-for-skia. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Aug 2023 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60571 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 60571@debbugs.gnu.org Received: via spool by 60571-submit@debbugs.gnu.org id=B60571.169331628318431 (code B ref 60571); Tue, 29 Aug 2023 13:39:02 +0000 Received: (at 60571) by debbugs.gnu.org; 29 Aug 2023 13:38:03 +0000 Received: from localhost ([127.0.0.1]:49880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qayux-0004nD-JE for submit@debbugs.gnu.org; Tue, 29 Aug 2023 09:38:03 -0400 Received: from 16.mo550.mail-out.ovh.net ([178.33.104.224]:34777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qayus-0004mi-Lv for 60571@debbugs.gnu.org; Tue, 29 Aug 2023 09:38:02 -0400 Received: from director4.ghost.mail-out.ovh.net (unknown [10.108.16.43]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 9958B2592A for <60571@debbugs.gnu.org>; Tue, 29 Aug 2023 13:37:49 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-wd6g8 (unknown [10.110.171.117]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 315B21FE07; Tue, 29 Aug 2023 13:37:49 +0000 (UTC) Received: from ngraves.fr ([37.59.142.106]) by ghost-submission-6684bf9d7b-wd6g8 with ESMTPSA id yFUUCa307WRKDAAAMskE5A (envelope-from ); Tue, 29 Aug 2023 13:37:49 +0000 X-OVh-ClientIp: 81.67.140.142 In-Reply-To: <874jkjgoch.fsf@gmail.com> References: <28d93ea0e4bda4dbbc9a653cfefb7e569b827ada.1693140822.git.ngraves@ngraves.fr> <874jkjgoch.fsf@gmail.com> Date: Tue, 29 Aug 2023 15:37:48 +0200 Message-ID: <87ledunf4j.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 17630748120055079433 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrudefiedgieeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepveekleeujedthefgffekleekhffhffetgfdvheekleeuhfehueeljedtjefhvdfgnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugedtrddugedvpdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeitdehjeduseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -1.91 X-Spam-Score: -1.91 X-Migadu-Queue-Id: A29C335074 X-TUID: 01S5kMC4g6Hi On 2023-08-28 11:48, Maxim Cournoyer wrote: > Hello! > > Nicolas Graves writes: > > > The comments are a bit terse; I'd expound them to complete sentences > with a tad more context. Will try to expand a bit, but that will be hard, the commits are very old and my memory of this mostly faded. > > I'm confused here; we re-run the configure script post installation? > How does that work? If that's really needed it needs a proper > explanatory comment. IIRC, since we use this version of icu4c to run tests, we needed to also build some "data". It's rather a reconfiguration to build data rather than a re-run of the configuration script post-installation. > > The rest looks good! It's seems a tricky package, well done! Could you > please send a v2 with the above suggestions/comments taken into account? Doing so -- Best regards, Nicolas Graves