[bug#65592] [PATCH]: Update sbcl to 2.3.8

[bug#65592] [PATCH]: Update sbcl to 2.3.8

[André A. Gomes]

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Hi Guix,

Please find the patch attached.  Thanks.


-- 
André A. Gomes
"You cannot even find the ruins..."

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-sbcl-Update-to-2.3.8.patch --]
[-- Type: text/x-patch, Size: 1221 bytes --]

From 001395fa5fd21654cadb20e4f9daaa30e000396d Mon Sep 17 00:00:00 2001
From: "Andre A. Gomes" <andremegafone@gmail.com>
Date: Tue, 29 Aug 2023 16:48:10 +0300
Subject: [PATCH] gnu: sbcl: Update to 2.3.8.

* gnu/packages/lisp.scm (sbcl): Update to 2.3.8.
---
 gnu/packages/lisp.scm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 6f425a6e4a..db9c644144 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -433,17 +433,15 @@ (define-public clisp
 (define-public sbcl
   (package
     (name "sbcl")
-    (version "2.3.5")
+    (version "2.3.8")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "mirror://sourceforge/sbcl/sbcl/" version "/sbcl-"
                            version "-source.tar.bz2"))
        (sha256
-        (base32 "11ji5n65l31249r0v7hm0wc0yk2ila0y746nj36xn1cxrwh0gjc9"))
+        (base32 "0a8dranh15gsbq51ssnvccl91mzqmgs5xsmwisz5hvlimjr725a2"))
        (modules '((guix build utils)))
-       ;; backport from upstream.
-       (patches (search-patches "sbcl-riscv-Make-contribs-build-again.patch"))
        (snippet
         '(begin
            ;; Don't force ARMv5.
-- 
2.41.0

[bug#65592] [PATCH]: Update sbcl to 2.3.8

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

I applied a modified version of your patch (to remove the obsolete patch
from the sources) on the lisp-team branch.
When the CI machines have rebuilt the dependents, we'll merge the
lisp-team branch into the master branch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#65592: [PATCH]: Update sbcl to 2.3.8

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
now. It has been merged in master at
4f35ff1275e05be31f5d41464ccf147e9dbfd016.
Let's close this issue and open a new one for a future update of SBCL
(maybe 2.3.9 will fix the build failure).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

[bug#65592] [PATCH]: Update sbcl to 2.3.8

[André A. Gomes]

Guillaume Le Vaillant <glv@posteo.net> writes:

> SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
> now. It has been merged in master at
> 4f35ff1275e05be31f5d41464ccf147e9dbfd016.
> Let's close this issue and open a new one for a future update of SBCL
> (maybe 2.3.9 will fix the build failure).

Hi Guillaume,

Just for future reference, is there a way for me to check whether a SBCL
builds on all platforms when sending a patch?  Thanks.


-- 
André A. Gomes
"You cannot even find the ruins..."

[bug#65592] [PATCH]: Update sbcl to 2.3.8

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]

André A. Gomes <andremegafone@gmail.com> skribis:

> Guillaume Le Vaillant <glv@posteo.net> writes:
>
>> SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
>> now. It has been merged in master at
>> 4f35ff1275e05be31f5d41464ccf147e9dbfd016.
>> Let's close this issue and open a new one for a future update of SBCL
>> (maybe 2.3.9 will fix the build failure).
>
> Hi Guillaume,
>
> Just for future reference, is there a way for me to check whether a SBCL
> builds on all platforms when sending a patch?  Thanks.

For x86_64, i686, aarch64, armhf and powerpc64le, you can check on
<https://qa.guix.gnu.org/issue/ISSUE-NUMBER>.

However so far the CI doesn't have builds for riscv64, because it
doesn't have riscv64 hardware. Efraim Flashner <efraim@flashner.co.il>
has a riscv64 board with Guix on it, and he is the one who tried
building SBCL 2.3.8 and saw the failure.

If you are using a Guix system, you could also add the
qemu-binfmt-service-type to your system definition, which gives the
possibility to build packages for some other architectures with:

  guix build -s riscv64-linux PACKAGE-NAME

Unfortunately, qemu-binfmt has difficulties running SBCL on foreign
architectures, and building SBCL for aarch64 or riscv64 on a x86_64
machine fails with an error about a missing tty or something like that.
However, trying the build with qemu-binfmt can still be useful, because
if compilation fails before getting to the tty error, it usually
indicates that the package has an issue on this architecture.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

[bug#65592] [PATCH]: Update sbcl to 2.3.8

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]


Guillaume Le Vaillant <glv@posteo.net> writes:

> André A. Gomes <andremegafone@gmail.com> skribis:
>
>> Guillaume Le Vaillant <glv@posteo.net> writes:
>>
>>> SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
>>> now. It has been merged in master at
>>> 4f35ff1275e05be31f5d41464ccf147e9dbfd016.
>>> Let's close this issue and open a new one for a future update of SBCL
>>> (maybe 2.3.9 will fix the build failure).
>>
>> Hi Guillaume,
>>
>> Just for future reference, is there a way for me to check whether a SBCL
>> builds on all platforms when sending a patch?  Thanks.
>
> For x86_64, i686, aarch64, armhf and powerpc64le, you can check on
> <https://qa.guix.gnu.org/issue/ISSUE-NUMBER>.

Note that we're lacking sufficient powerpc64 hardware to do QA for that
architecture.

> However so far the CI doesn't have builds for riscv64, because it
> doesn't have riscv64 hardware. Efraim Flashner <efraim@flashner.co.il>
> has a riscv64 board with Guix on it, and he is the one who tried
> building SBCL 2.3.8 and saw the failure.

We do however have RiscV hardware connected to the bordeaux build farm,
I've got a machine and there's also a second connected. We probably need
at least one more machine to enable the system for QA though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]