From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mKJeJTzKKmUbfQEAG6o9tA:P1 (envelope-from ) for ; Sat, 14 Oct 2023 19:05:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mKJeJTzKKmUbfQEAG6o9tA (envelope-from ) for ; Sat, 14 Oct 2023 19:05:00 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 851FE3B961 for ; Sat, 14 Oct 2023 19:05:00 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Nql4jJQT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697303100; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rDwaRCS/W6XVwCLP2oQdeaAfx7h9VlVYXUgVKxtpdvk=; b=I98RGsCq3xwWia5sJSXmphvR1Qh1+LKUYQSB0pWqPNcb1Y8xQPcZ4WDZBVn0ZHeobQZmpY gmcJpOa+ITOX0YqY6r84uosUEMg6EiaxmJMn94wAUkhA/9Mwchq+HKIIjSZaNLWu7/lt5q mJ5bjMXjs566Gn4sKcp6VPbhpx0tQFHO1TMdqKdv+RSbKn8lRQ7Raw93iCw0+DGN9kD7ev E8FM3jwU1fybd6l0wG1Rfb1A4vK5GO+RXVWex97en6B6jOY2j/MKAOf6ciA3wxa6BiRgRA Kf2GpFSo1weMVsRyeI5aTAiQ+WsonwQu5Ztk0ICxwmV3LJ6dyDnYuvAM40+A5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Nql4jJQT; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697303100; a=rsa-sha256; cv=none; b=mWsUkiJ8iwvyKdKHssVRlv/X4OPdCUNRecMtBfq2pGRpil+HI4Ky8aCDGZ/k4jRNpSRIWb MWxRPPB9pK5dULIVSlb6UM6RLWgtXC8EU9FkxJlk7RVrgp1+5GnH11nW5lcmXYAD+hl10H bAY2emwYM2A9BFS7A7jrXoc8S4CoYjTwVZiaisBcjn+HRTDzPSMqZa9iRrsiwqDo443Pp9 Bh5PpdRsDcJuQT5j5RAw6CjYsmWoHWFcM19AAzKhrKW4oYDMpSlj7OkNKfe1rKrPIaZ3Lv O9YY7WZxDeXNT1weZYPMc4Ue5ySZo0NOQj4/W9w8wxqabwUcIWBOmx1OLX4yYg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qri48-0004v9-LZ; Sat, 14 Oct 2023 13:04:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qri46-0004uE-Pw for guix-patches@gnu.org; Sat, 14 Oct 2023 13:04:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qri46-0004Hj-Hl for guix-patches@gnu.org; Sat, 14 Oct 2023 13:04:38 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qri4U-0002Xs-54 for guix-patches@gnu.org; Sat, 14 Oct 2023 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64359] [PATCH] [RFC] --search-paths: emit code compatible with set -u Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2023 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64359 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Zack Weinberg" Cc: 64359@debbugs.gnu.org Received: via spool by 64359-submit@debbugs.gnu.org id=B64359.16973030919746 (code B ref 64359); Sat, 14 Oct 2023 17:05:02 +0000 Received: (at 64359) by debbugs.gnu.org; 14 Oct 2023 17:04:51 +0000 Received: from localhost ([127.0.0.1]:50323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri4I-0002X5-Lo for submit@debbugs.gnu.org; Sat, 14 Oct 2023 13:04:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri4H-0002Wt-27 for 64359@debbugs.gnu.org; Sat, 14 Oct 2023 13:04:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qri3n-0004Dr-SL; Sat, 14 Oct 2023 13:04:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rDwaRCS/W6XVwCLP2oQdeaAfx7h9VlVYXUgVKxtpdvk=; b=Nql4jJQT51xw9oKNiRPZ yATf4FqWCNergvBKguASn4V918urRmY+1PQw71ik44lXyLH+tuW44nR86UJyzx/MR5VpmGbA41yO8 7+oAWOxOso4muW5XJYwYlE3uRU7IwB06sP2U9ogU3i+pyOfIGs4xz9UqkG5t9YCcm9e8g9OyVc79H xWWI+cN4utxUbzlDFTIQrCtv/Ty2m4a6p5gLmUIXqxsym4gjWcP3sul/V/d3zIy2WE3aVJyOL+NhF 37+7ZRLPpNhXEWK4qceMQpme++Y8YbS8sz4rYhyxbo/seZgDzbvXHGPrXHsB/So+5O1hOX03vjpXt T9g/1ckD5sa/AA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Zack Weinberg's message of "Wed, 11 Oct 2023 14:56:55 -0400") References: <877crlyidb.wl-zack@owlfolio.org> <87bkd5t7fr.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 23 =?UTF-8?Q?Vend=C3=A9miaire?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Navet X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 14 Oct 2023 19:04:17 +0200 Message-ID: <87lec5dtke.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.85 X-Spam-Score: -6.85 X-Migadu-Queue-Id: 851FE3B961 X-Migadu-Scanner: mx2.migadu.com X-TUID: aVVmlcdFLrFf Hi Zack, "Zack Weinberg" skribis: >>> +++ b/guix/build/utils.scm >>> @@ -1384,19 +1384,19 @@ (define (export-variable lst) >>> (format #f "export ~a=3D\"~a\"" >>> var (string-join rest sep))) >>> ((var sep 'prefix rest) >>> - (format #f "export ~a=3D\"~a${~a:+~a}$~a\"" >>> + (format #f "export ~a=3D\"~a${~a:+~a}${~a:-}\"" >>> var (string-join rest sep) var sep var)) >> >> This part is a full-rebuild change, so it=E2=80=99d have to wait. Howev= er, it=E2=80=99s >> within =E2=80=98wrap-program=E2=80=99; the script generated by =E2=80=98= wrap-program=E2=80=99 does *not* >> use =E2=80=98set -u=E2=80=99, so I think this change is unnecessary. Am= I right? > > It's not strictly necessary to fix the bug, no. I made this change becau= se > it's the only other appearance of 'export VAR=3D"additional-value${VAR:+:= }$VAR"' > in the guix source code and I thought it would be better to change both of > them the same way. If only so that years from now someone doesn't waste a= ny > time wondering why they're not quite the same and whether it matters. > > Why is it a full-rebuild change? As you point out, it should not actually > change anything? It=E2=80=99s a full-rebuild change because every single package depends on = (guix build utils). When we change it, we have to rebuild literally every package. >>> --- a/tests/guix-environment.sh >>> +++ b/tests/guix-environment.sh >> You can remove this change and keep only the =E2=80=98tests/guix-shell.s= h=E2=80=99 part. > > I know "guix environment" is obsolete, but isn't it appropriate to test it > thoroughly for as long as it still exists? (and again, years from now so= meone > might waste time wondering why this is only tested for "guix shell") No, I think it=E2=80=99s unnecessary because the two share the same code. Eventually we=E2=80=99ll merge the two tests (and remove =E2=80=98guix envi= ronment=E2=80=99, someday). Could you send an updated patch? Thanks, Ludo=E2=80=99.