From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 66605@debbugs.gnu.org
Subject: [bug#66605] [PATCH v2] etc: gitconfig: Run etc/teams.scm from correct environment.
Date: Wed, 18 Oct 2023 21:39:25 -0400 [thread overview]
Message-ID: <87lebzqtki.fsf@gmail.com> (raw)
In-Reply-To: <d409fe3f12ae15b9f663a81221f5bbf254c995ee.1697665843.git.clement@lassieur.org> ("Clément Lassieur"'s message of "Wed, 18 Oct 2023 23:50:43 +0200")
Hi,
Clément Lassieur <clement@lassieur.org> writes:
> * etc/git/gitconfig: Prepend "guix repl" to the etc/teams.scm script so that
> any user that has git:send-email installed can use it in the Guix checkout
> without changing their environment. (teams.scm uses (git) and (guix ui).)
> ---
> etc/git/gitconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/git/gitconfig b/etc/git/gitconfig
> index 907ad0180454..abcd494d62e8 100644
> --- a/etc/git/gitconfig
> +++ b/etc/git/gitconfig
> @@ -14,5 +14,5 @@
>
> [sendemail]
> to = guix-patches@gnu.org
> - headerCmd = etc/teams.scm cc-members-header-cmd
> + headerCmd = guix repl etc/teams.scm cc-members-header-cmd
I had noticed as well that since Guix depends on 'git', we now have to
include git:send-email to the profile to be able to use it, like:
'guix shell -D guix git:send-email'.
I think on foreign distributions, you also need to use mumi or git
send-email in ./pre-inst-env, which is what your patch solves, I
believe. This is not needed on a Guix System because the guix-daemon
used by it adds the Guix modules to the GUILE_LOAD_PATH.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-10-19 1:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 12:05 [bug#66605] [PATCH] etc: gitconfig: Run etc/teams.scm from correct environment Clément Lassieur
2023-10-18 17:54 ` Maxim Cournoyer
2023-10-18 20:52 ` Clément Lassieur
2023-10-18 21:50 ` [bug#66605] [PATCH v2] " Clément Lassieur
2023-10-19 1:39 ` Maxim Cournoyer [this message]
2023-10-19 1:47 ` Maxim Cournoyer
2023-10-19 10:05 ` Clément Lassieur
2023-10-21 3:39 ` [bug#66605] [PATCH v3] teams: Adjust shebang to use 'guix repl' Maxim Cournoyer
2023-10-22 20:07 ` [bug#66605] [PATCH v5] " Maxim Cournoyer
2023-10-22 20:23 ` Clément Lassieur
2023-10-23 0:39 ` bug#66605: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lebzqtki.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=66605@debbugs.gnu.org \
--cc=clement@lassieur.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).