unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Cc: 67570@debbugs.gnu.org
Subject: [bug#67570] [PATCH] gnu: kubo: Fix build.
Date: Sat, 02 Dec 2023 11:04:56 +0100	[thread overview]
Message-ID: <87leacj4xj.fsf@gnu.org> (raw)
In-Reply-To: <878r6deo5c.fsf@gmail.com> (Artyom V. Poptsov's message of "Fri,  01 Dec 2023 22:08:47 +0300")

Hi,

I spoke too fast…

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:

> +     (let ((p (package-input-rewriting
> +               `((,go-golang-org-x-sys . ,go-golang-org-x-sys-0.8))
> +               #:deep? #true)))
> +       (cons go-golang-org-x-sys-0.8
> +             (map p
> +                  (list go-github-com-alecthomas-units
> +                        ;; TODO: needs to be updated first
> +                        ;; go-github-com-blang-semver
> +                        go-github-com-cespare-xxhash

It does fix the build, but it’s a bit heavy-handed: every time we
compute the kubo derivation, we go through that graph rewriting, which
is quite expensive.

Can you think of another way this could be fixed?  What if we don’t
replace go-golang-org-x-sys everywhere?  Or perhaps there’s a trick that
would allow us to build with go-golang-org-x-sys 0.4?

In parallel perhaps we should work on upgrading go-golang-org-x-sys
altogether?

WDYT?

Ludo’.




  reply	other threads:[~2023-12-02 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 19:08 [bug#67570] [PATCH] gnu: kubo: Fix build Artyom V. Poptsov
2023-12-02 10:04 ` Ludovic Courtès [this message]
2023-12-09  8:22   ` [bug#67570] [PATCH] gnu: go-golang-org-x-sys: Update to 0.8.0. (was: [PATCH] gnu: kubo: Fix build.) Artyom V. Poptsov
2023-12-10 21:22     ` [bug#67570] [PATCH] gnu: go-golang-org-x-sys: Update to 0.8.0 Ludovic Courtès
2023-12-29  9:55       ` Artyom V. Poptsov
2024-01-07 14:48         ` bug#67570: " Ludovic Courtès
2024-01-07 15:34           ` [bug#67570] " Christopher Baines
2024-01-08 17:02             ` Ludovic Courtès
2024-01-08 17:13           ` Artyom V. Poptsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leacj4xj.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=67570@debbugs.gnu.org \
    --cc=poptsov.artyom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).