[bug#64408] [PATCH] gnu: Add privacybrowser.

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Soren Stoutner via Guix-patches via]

* gnu/packages/privacybrowser.scm: New file.
---
 gnu/packages/privacybrowser.scm | 58 +++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 gnu/packages/privacybrowser.scm

diff --git a/gnu/packages/privacybrowser.scm b/gnu/packages/privacybrowser.scm
new file mode 100644
index 0000000000..e0cf871f85
--- /dev/null
+++ b/gnu/packages/privacybrowser.scm
@@ -0,0 +1,58 @@
+;;; Privacy Browser PC --- A web browser that respects your privacy.
+;;; Copyright © 2023 Soren Stoutner <soren@stoutner.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages privacybrowser)
+  #:use-module (guix build-system qt)
+  #:use-module (guix download)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (gnu packages kde-frameworks)
+  #:use-module (gnu packages kde-systemtools)
+  #:use-module (gnu packages qt))
+
+(define-public privacybrowser
+  (package
+    (name "privacybrowser")
+    (version "0.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://download.stoutner.com/privacybrowser-pc/privacybrowser-"
+                    version ".tar.xz"))
+              (sha256
+               (base32
+                "1c458n2g4zic5fizn2mir0nah28f0yp7swdyy6xk5hqg7nxk2akc"))))
+    (build-system qt-build-system)
+    (native-inputs (list extra-cmake-modules))
+    (inputs (list breeze-icons
+                  kcrash
+                  kdbusaddons
+                  khelpcenter
+                  ki18n
+                  kio
+                  knotifications
+                  qtsvg-5
+                  qtwebengine-5))
+    (home-page "https://www.stoutner.com/privacy-browser-pc/")
+    (synopsis "Web browser that respects your privacy")
+    (description
+     "Privacy Browser is a web browser based on Qt WebEngine
+with a focus on privacy and security.  Features like JavaScript and
+cookies are disabled by default but are easy to automatically enable
+on-the-fly or by domain.")
+    (license gpl3+)))
-- 
2.39.2

[bug#64408] Next step?

[Soren Stoutner via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 98 bytes --]

What is the next step to get Privacy Browser added to Guix?

-- 
Soren Stoutner
soren@stoutner.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Tobias Geerinckx-Rice via Guix-patches via]

Hi Soren,

Thanks for the patch!  It looks good, but I wonder about ‘khelpcenter’.

Notably, it doesn't enable the ‘Help’ → ‘Privacy Browser Handbook’.  
That prints

   kf.guiaddons: Could not find a suitable handler for "help:/"

in the console and does nothing in the GUI.  Is this something that 
could be fixed?

If it's something that requires a full(er) KDE installation, does adding 
‘khelpcenter’ make a difference?  It doesn't for me.

Kind regards,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

[bug#64408] Availability in Guix Soon?

[martin]

[-- Attachment #1: Type: text/html, Size: 310 bytes --]

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Soren Stoutner via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

I apologize for not responding sooner.  I assumed that when someone commented 
on the issue I would receive an email, but either it never came or I missed it 
somehow.

KHelpCenter is required to be able to open the Handbook (press F1 inside of 
the program).  There is a lot of important information in the Handbook that 
users of Privacy Browser would benefit reading.

-- 
Soren Stoutner
soren@stoutner.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Soren Stoutner via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Note that for KHelpCenter to function, it must be specified at runtime.  For 
example:

guix shell privacybrowser khelpcenter -- privacybrowser

It seems there are a few missing icons and there are some warnings written to 
the console.  I assume that relates to some deficiency in the KHelpCenter 
package.  But all the text of the Handbook can be read.

-- 
Soren Stoutner
soren@stoutner.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Soren Stoutner via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 108 bytes --]

Privacy Browser 0.5 has been released.  Attached is an updated patch.

-- 
Soren Stoutner
soren@stoutner.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-Privacy-Browser.patch --]
[-- Type: text/x-patch; charset="x-UTF_8J"; name="0001-gnu-Add-Privacy-Browser.patch", Size: 3104 bytes --]

From d5358a483d55c54573b336b297ae3728fbcff029 Mon Sep 17 00:00:00 2001
Message-Id: <d5358a483d55c54573b336b297ae3728fbcff029.1697564327.git.soren@stoutner.com>
From: Soren Stoutner <soren@stoutner.com>
Date: Tue, 17 Oct 2023 10:30:53 -0700
Subject: [PATCH] gnu: Add Privacy Browser.

* gnu/packages/privacybrowser.scm: New file.
---
 gnu/packages/privacybrowser.scm | 58 +++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 gnu/packages/privacybrowser.scm

diff --git a/gnu/packages/privacybrowser.scm b/gnu/packages/privacybrowser.scm
new file mode 100644
index 0000000000..6ae7247ed0
--- /dev/null
+++ b/gnu/packages/privacybrowser.scm
@@ -0,0 +1,58 @@
+;;; Privacy Browser PC --- A web browser that respects your privacy.
+;;; Copyright © 2023 Soren Stoutner <soren@stoutner.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages privacybrowser)
+  #:use-module (guix build-system qt)
+  #:use-module (guix download)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (gnu packages kde-frameworks)
+  #:use-module (gnu packages kde-systemtools)
+  #:use-module (gnu packages qt))
+
+(define-public privacybrowser
+  (package
+    (name "privacybrowser")
+    (version "0.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://download.stoutner.com/privacybrowser-pc/privacybrowser-"
+             version ".tar.xz"))
+       (sha256
+        (base32 "1rywfmmw535bs0h3i4yrif3xmz2a4flp04bmhqdlbri4h1pk7x2y"))))
+    (build-system qt-build-system)
+    (native-inputs (list extra-cmake-modules))
+    (inputs (list breeze-icons
+                  kcrash
+                  kdbusaddons
+                  khelpcenter
+                  ki18n
+                  kio
+                  knotifications
+                  qtsvg-5
+                  qtwebengine-5))
+    (home-page "https://www.stoutner.com/privacy-browser-pc/")
+    (synopsis "Web browser that respects your privacy")
+    (description
+     "Privacy Browser is a web browser based on Qt WebEngine
+with a focus on privacy and security.  Features like JavaScript and
+cookies are disabled by default but are easy to automatically enable
+on-the-fly or by domain.")
+    (license gpl3+)))

base-commit: b437896e87a51cc610388d4c462893652dd773e6
-- 
2.39.2


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Clément Lassieur]

Hi,

Thank you for this patch.

On Mon, Oct 16 2023, Soren Stoutner via Guix-patches via wrote:

> Note that for KHelpCenter to function, it must be specified at runtime.  For 
> example:
>
> guix shell privacybrowser khelpcenter -- privacybrowser

Maybe it should be a propagated input then?


Also does it have to be in a specific file?  I imagine it could fit in
qt.scm?

Thanks,
Clément

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Soren Stoutner via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Clément

On Saturday, January 13, 2024 3:45:08 AM MST Clément Lassieur wrote:
> On Mon, Oct 16 2023, Soren Stoutner via Guix-patches via wrote:
> > Note that for KHelpCenter to function, it must be specified at runtime.  
For
> > example:
> > 
> > guix shell privacybrowser khelpcenter -- privacybrowser
> 
> Maybe it should be a propagated input then?

How is that done?

> Also does it have to be in a specific file?  I imagine it could fit in
> qt.scm?

You can put it wherever it makes the most sense.  If you would like to place 
it inside of another scm, I would imagine that web-browsers.scm is probably 
the most logical location.

-- 
Soren Stoutner
soren@stoutner.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Clément Lassieur]

On Sat, Jan 13 2024, Soren Stoutner via Guix-patches via wrote:

> Clément
>
> On Saturday, January 13, 2024 3:45:08 AM MST Clément Lassieur wrote:
>> On Mon, Oct 16 2023, Soren Stoutner via Guix-patches via wrote:
>> > Note that for KHelpCenter to function, it must be specified at runtime.  
> For
>> > example:
>> > 
>> > guix shell privacybrowser khelpcenter -- privacybrowser
>> 
>> Maybe it should be a propagated input then?

You use the propagated-inputs field instead of the inputs field.  The
consequence is that installing "PrivacyBrowser" will install the
propagated inputs too.  Same with "guix shell".  So "guix shell
privacybrowser -- privacybrowser" will work.

> How is that done?
>
>> Also does it have to be in a specific file?  I imagine it could fit in
>> qt.scm?
>
> You can put it wherever it makes the most sense.  If you would like to place 
> it inside of another scm, I would imagine that web-browsers.scm is probably 
> the most logical location.

Indeed, sounds like the right place.

Can you send an updated patch?

[bug#64408] [PATCH] gnu: Add privacybrowser.

[Soren Stoutner via Guix-patches via]

[-- Attachment #1.1: Type: text/plain, Size: 1293 bytes --]

Attached is an updated patch.

On Sunday, January 14, 2024 2:17:00 AM MST Clément Lassieur wrote:
> On Sat, Jan 13 2024, Soren Stoutner via Guix-patches via wrote:
> > Clément
> > 
> > On Saturday, January 13, 2024 3:45:08 AM MST Clément Lassieur wrote:
> >> On Mon, Oct 16 2023, Soren Stoutner via Guix-patches via wrote:
> >> > Note that for KHelpCenter to function, it must be specified at runtime.
> > 
> > For
> > 
> >> > example:
> >> > 
> >> > guix shell privacybrowser khelpcenter -- privacybrowser
> >> 
> >> Maybe it should be a propagated input then?
> 
> You use the propagated-inputs field instead of the inputs field.  The
> consequence is that installing "PrivacyBrowser" will install the
> propagated inputs too.  Same with "guix shell".  So "guix shell
> privacybrowser -- privacybrowser" will work.
> 
> > How is that done?
> > 
> >> Also does it have to be in a specific file?  I imagine it could fit in
> >> qt.scm?
> > 
> > You can put it wherever it makes the most sense.  If you would like to 
place
> > it inside of another scm, I would imagine that web-browsers.scm is 
probably
> > the most logical location.
> 
> Indeed, sounds like the right place.
> 
> Can you send an updated patch?


-- 
Soren Stoutner
soren@stoutner.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-privacybrowser-Add-Privacy-Browser-0.5.patch --]
[-- Type: text/x-patch; charset="x-UTF_8J"; name="0001-gnu-privacybrowser-Add-Privacy-Browser-0.5.patch", Size: 3369 bytes --]

From e194cdf0955c66f2eb2d41cece5b8e4c0ed465b3 Mon Sep 17 00:00:00 2001
Message-Id: <e194cdf0955c66f2eb2d41cece5b8e4c0ed465b3.1705989200.git.soren@stoutner.com>
From: Soren Stoutner <soren@stoutner.com>
Date: Mon, 22 Jan 2024 22:48:55 -0700
Subject: [PATCH] gnu: privacybrowser: Add Privacy Browser 0.5.

* gnu/packages/web-browsers.scm: (privacybrowser): Add Privacy
Browser 0.5.

Change-Id: I4e8d624ef10acb15a6d699f4b9432e6bce4e1322
---
 gnu/packages/web-browsers.scm | 41 +++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 71289dbb2b..4d0f1c1ea5 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2020 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;; Copyright © 2021 Christopher Howard <christopher@librehacker.com>
 ;;; Copyright © 2023 Herman Rimm <herman@rimm.ee>
+;;; Copyright © 2023-2024 Soren Stoutner <soren@stoutner.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -44,6 +45,7 @@ (define-module (gnu packages web-browsers)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system go)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system qt)
   #:use-module (guix download)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
@@ -73,6 +75,8 @@ (define-module (gnu packages web-browsers)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages image)
   #:use-module (gnu packages imagemagick)
+  #:use-module (gnu packages kde-frameworks)
+  #:use-module (gnu packages kde-systemtools)
   #:use-module (gnu packages libevent)
   #:use-module (gnu packages libidn)
   #:use-module (gnu packages libunistring)
@@ -458,6 +462,43 @@ (define-public kristall
                      ;; for breeze-stylesheet
                      license:expat)))))
 
+(define-public privacybrowser
+  (package
+    (name "privacybrowser")
+    (version "0.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://download.stoutner.com/"
+                           "privacybrowser-pc/privacybrowser-" version
+                           ".tar.xz"))
+       (sha256
+        (base32 "1rywfmmw535bs0h3i4yrif3xmz2a4flp04bmhqdlbri4h1pk7x2y"))))
+    (build-system qt-build-system)
+    (native-inputs
+     (list extra-cmake-modules))
+    (inputs
+     (list breeze-icons
+           kcrash
+           kdbusaddons
+           khelpcenter
+           ki18n
+           kio
+           knotifications
+           qtsvg-5
+           qtwebengine-5))
+    (propagated-inputs
+     (list khelpcenter))
+     ; khelpcenter needs to be propagates so that F1 work inside
+     ; privacybrowser.
+    (home-page "https://www.stoutner.com/privacy-browser-pc/")
+    (synopsis "Web browser that respects your privacy")
+    (description "Privacy Browser is a web browser based on Qt WebEngine
+with a focus on privacy and security.  Features like JavaScript and
+cookies are disabled by default but are easy to automatically enable
+on-the-fly or by domain.")
+    (license license:gpl3+)))
+
 (define-public qutebrowser
   (package
     (name "qutebrowser")

base-commit: f7c0ccb1866b559dc2ce0c538d10a150822824c8
-- 
2.39.2


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]