unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: Hartmut Goebel <h.goebel@crazy-compilers.com>,
	57311-done@debbugs.gnu.org
Subject: bug#57311: [PATCH v2] gnu: Add snapper.
Date: Sun, 18 Feb 2024 15:50:35 +0100	[thread overview]
Message-ID: <87le7hn7wk.fsf@gnu.org> (raw)
In-Reply-To: <20240203133159.16379-1-ngraves@ngraves.fr> (Nicolas Graves's message of "Sat, 3 Feb 2024 14:31:59 +0100")

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

Hi Nicolas,

Nicolas Graves <ngraves@ngraves.fr> skribis:

> * gnu/packages/file-systems.scm (snapper): New variable.

Applied with the changes below, most of which suggested by Hartmut.

Thanks!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2989 bytes --]

diff --git a/gnu/packages/file-systems.scm b/gnu/packages/file-systems.scm
index f1035ac86a..40f1383a56 100644
--- a/gnu/packages/file-systems.scm
+++ b/gnu/packages/file-systems.scm
@@ -1250,28 +1250,41 @@ (define-public snapper
              (("zypp-plugin") ""))))))
     (build-system gnu-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'relative-file-locations
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((out (assoc-ref outputs "out")))
-               (substitute* (list "scripts/Makefile.am" "data/Makefile.am")
-                 (("/usr/share") (string-append out "/share"))
-                 (("/usr/lib") (string-append out "/lib"))
-                 (("/etc/") (string-append out "/etc/"))))
-               (substitute* "client/Makefile.am"
-                 (("/usr/lib") "@libdir@")))))))
+     (list #:phases #~(modify-phases %standard-phases
+                        (add-after 'unpack 'relative-file-locations
+                          (lambda* (#:key outputs #:allow-other-keys)
+                            (let* ((out (assoc-ref outputs "out")))
+                              (substitute* (list "scripts/Makefile.am"
+                                                 "data/Makefile.am")
+                                (("/usr/share")
+                                 (string-append out "/share"))
+                                (("/usr/lib")
+                                 (string-append out "/lib"))
+                                (("/etc/")
+                                 (string-append out "/etc/"))))
+                            (substitute* "client/Makefile.am"
+                              (("/usr/lib")
+                               "@libdir@")))))))
     (home-page "https://snapper.io")
     (native-inputs
      (list glibc-locales autoconf automake libtool pkg-config))
     (inputs
-     (list btrfs-progs e2fsprogs `(,util-linux "lib") linux-pam
-           dbus libxml2 json-c acl boost ncurses/tinfo
-           libxslt docbook-xsl gettext-minimal))
-    (synopsis "Manage filesystem snapshots and allow roll-backs")
-    (description "\
-This package provides Snapper, a tool that helps with managing
-snapshots of Btrfs subvolumes and thin-provisioned LVM volumes.  It
+     (list btrfs-progs
+           e2fsprogs
+           `(,util-linux "lib")
+           linux-pam
+           dbus
+           libxml2
+           json-c
+           acl
+           boost
+           ncurses/tinfo
+           libxslt
+           docbook-xsl
+           gettext-minimal))
+    (synopsis "Manage Btrfs file system snapshots and allow roll-backs")
+    (description "This package provides Snapper, a tool that helps with
+managing snapshots of Btrfs subvolumes and thin-provisioned LVM volumes.  It
 can create and compare snapshots, revert differences between them, and
 supports automatic snapshots timelines.")
     (license license:gpl2)))

  reply	other threads:[~2024-02-18 14:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-20 21:39 [bug#57311] [PATCH] gnu: Add snapper Nicolas Graves via Guix-patches via
2023-02-10 16:43 ` Nicolas Graves via Guix-patches via
2024-02-03 13:31 ` [bug#57311] [PATCH v2] " Nicolas Graves via Guix-patches via
2024-02-18 14:50   ` Ludovic Courtès [this message]
2024-02-16 21:06 ` [bug#57311] QA review for 57311 Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le7hn7wk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=57311-done@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).