unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#69820] [PATCH] gnu: Add guile-gsl.
@ 2024-03-15 21:31 Artyom Bologov
  2024-03-20 20:15 ` Artyom Bologov
  2024-04-04 11:25 ` bug#69820: " Sharlatan Hellseher
  0 siblings, 2 replies; 3+ messages in thread
From: Artyom Bologov @ 2024-03-15 21:31 UTC (permalink / raw)
  To: 69820

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

Hi y'all,

This is another shot at packaging Guile GSL bindings. See the attached
patch. The related bugs 69443 and 69737 are resolved then.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add guile-gsl --]
[-- Type: text/x-patch, Size: 2557 bytes --]

From 0185af4d2c467a45de568d1193f76cfcf23e8bab Mon Sep 17 00:00:00 2001
From: Artyom Bologov <aartaka@protonmail.com>
Date: Sat, 16 Mar 2024 01:11:09 +0400
Subject: [PATCH] gnu: Add guile-gsl.

* gnu/packages/guile-xyz.scm (guile-gsl): New variable.
---
 gnu/packages/guile-xyz.scm | 40 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 9d683199ac..3c85c35b45 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1438,6 +1438,46 @@ (define-public guile-algorithms
     (home-page "https://guile-algorithms.lajszczak.dev/")
     (license license:gpl3+)))
 
+(define-public guile-gsl
+  (let ((commit "739a0ddcf00fdf4bdd409e6dd75de23e01aceded")
+        (revision "0"))
+    (package
+      (name "guile-gsl")
+      (version (git-version "0.0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/aartaka/guile-gsl")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0x0z5xx6jx5zhjy83zi7l9mzi65v58wl2khf11q5d2vf4hya16bb"))))
+      (build-system guile-build-system)
+      (arguments
+       (list #:source-directory "modules"
+             #:phases
+             #~(modify-phases %standard-phases
+                 (add-before 'build 'substitute-gsl-so
+                   (lambda _
+                     (let ((gsl (string-append #$(this-package-input "gsl")
+                                               "/lib/libgsl.so"))
+                           (gslcblas (string-append #$(this-package-input "gsl")
+                                                    "/lib/libgslcblas.so")))
+                       (substitute* '("modules/gsl/core.scm")
+                         (("libgsl.so")
+                          gsl)
+                         (("libgslcblas.so")
+                          gslcblas))
+                       #t))))))
+      (native-inputs (list guile-3.0))
+      (inputs (list guile-3.0 gsl))
+      (home-page "https://github.com/aartaka/guile-gsl")
+      (synopsis "Bindings for GNU Scientific library.")
+      (description "Scheme wrapper around @code{libgsl.so}.
+Implements vector, matrix, and BLAS operations.")
+      (license license:gpl3+))))
+
 (define-public guile-aws
   (let ((commit "f32bea12333e1054b97ab50e58a72636edabb5b7")
         (revision "1"))
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 20 bytes --]


Thanks,
--
Artyom.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#69820] [PATCH] gnu: Add guile-gsl.
  2024-03-15 21:31 [bug#69820] [PATCH] gnu: Add guile-gsl Artyom Bologov
@ 2024-03-20 20:15 ` Artyom Bologov
  2024-04-04 11:25 ` bug#69820: " Sharlatan Hellseher
  1 sibling, 0 replies; 3+ messages in thread
From: Artyom Bologov @ 2024-03-20 20:15 UTC (permalink / raw)
  To: 69820

[-- Attachment #1: Type: text/plain, Size: 90 bytes --]

Hi y'all,

Sorry, I added the wrong email to the previous patch, here's the updated
one:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add guile-gsl --]
[-- Type: text/x-patch, Size: 2550 bytes --]

From 0185af4d2c467a45de568d1193f76cfcf23e8bab Mon Sep 17 00:00:00 2001
From: Artyom Bologov <mail@aartaka.me>
Date: Sat, 16 Mar 2024 01:11:09 +0400
Subject: [PATCH] gnu: Add guile-gsl.

* gnu/packages/guile-xyz.scm (guile-gsl): New variable.
---
 gnu/packages/guile-xyz.scm | 40 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 9d683199ac..3c85c35b45 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1438,6 +1438,46 @@ (define-public guile-algorithms
     (home-page "https://guile-algorithms.lajszczak.dev/")
     (license license:gpl3+)))
 
+(define-public guile-gsl
+  (let ((commit "739a0ddcf00fdf4bdd409e6dd75de23e01aceded")
+        (revision "0"))
+    (package
+      (name "guile-gsl")
+      (version (git-version "0.0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/aartaka/guile-gsl")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0x0z5xx6jx5zhjy83zi7l9mzi65v58wl2khf11q5d2vf4hya16bb"))))
+      (build-system guile-build-system)
+      (arguments
+       (list #:source-directory "modules"
+             #:phases
+             #~(modify-phases %standard-phases
+                 (add-before 'build 'substitute-gsl-so
+                   (lambda _
+                     (let ((gsl (string-append #$(this-package-input "gsl")
+                                               "/lib/libgsl.so"))
+                           (gslcblas (string-append #$(this-package-input "gsl")
+                                                    "/lib/libgslcblas.so")))
+                       (substitute* '("modules/gsl/core.scm")
+                         (("libgsl.so")
+                          gsl)
+                         (("libgslcblas.so")
+                          gslcblas))
+                       #t))))))
+      (native-inputs (list guile-3.0))
+      (inputs (list guile-3.0 gsl))
+      (home-page "https://github.com/aartaka/guile-gsl")
+      (synopsis "Bindings for GNU Scientific library.")
+      (description "Scheme wrapper around @code{libgsl.so}.
+Implements vector, matrix, and BLAS operations.")
+      (license license:gpl3+))))
+
 (define-public guile-aws
   (let ((commit "f32bea12333e1054b97ab50e58a72636edabb5b7")
         (revision "1"))
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#69820: [PATCH] gnu: Add guile-gsl.
  2024-03-15 21:31 [bug#69820] [PATCH] gnu: Add guile-gsl Artyom Bologov
  2024-03-20 20:15 ` Artyom Bologov
@ 2024-04-04 11:25 ` Sharlatan Hellseher
  1 sibling, 0 replies; 3+ messages in thread
From: Sharlatan Hellseher @ 2024-04-04 11:25 UTC (permalink / raw)
  To: 69820-done; +Cc: Artyom V. Poptsov

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]


Hi Artyom (avp) and Artyom B.

Thank you for the patches.

I've fixed patch apply conflict by adding new commit with amended
author, added Co-authored-by filed and copyright header.

Some minor changes applied:
- Update to the latest commit
- Fix lint warnings for synopsis and description
- Remove trailing #t from lambda.

Pushed as 2931967720848082769002351d2a18c7ad43e811 to master.

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-04 11:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-15 21:31 [bug#69820] [PATCH] gnu: Add guile-gsl Artyom Bologov
2024-03-20 20:15 ` Artyom Bologov
2024-04-04 11:25 ` bug#69820: " Sharlatan Hellseher

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).